1. 10 8月, 2015 1 次提交
  2. 08 8月, 2015 1 次提交
    • R
      mitigate blow-up of heap size under malloc/free contention · c3761622
      Rich Felker 提交于
      during calls to free, any free chunks adjacent to the chunk being
      freed are momentarily held in allocated state for the purpose of
      merging, possibly leaving little or no available free memory for other
      threads to allocate. under this condition, other threads will attempt
      to expand the heap rather than waiting to use memory that will soon be
      available. the race window where this happens is normally very small,
      but became huge when free chooses to use madvise to release unused
      physical memory, causing unbounded heap size growth.
      
      this patch drastically shrinks the race window for unwanted heap
      expansion by performing madvise with the bin lock held and marking the
      bin non-empty in the binmask before making the expensive madvise
      syscall. testing by Timo Teräs has shown this approach to be a
      suitable mitigation.
      
      more invasive changes to the synchronization between malloc and free
      would be needed to completely eliminate the problem. it's not clear
      whether such changes would improve or worsen typical-case performance,
      or whether this would be a worthwhile direction to take malloc
      development.
      c3761622
  3. 29 7月, 2015 1 次提交
    • R
      fix missing synchronization in atomic store on i386 and x86_64 · 3c43c076
      Rich Felker 提交于
      despite being strongly ordered, the x86 memory model does not preclude
      reordering of loads across earlier stores. while a plain store
      suffices as a release barrier, we actually need a full barrier, since
      users of a_store subsequently load a waiter count to determine whether
      to issue a futex wait, and using a stale count will result in soft
      (fail-to-wake) deadlocks. these deadlocks were observed in malloc and
      possible with stdio locks and other libc-internal locking.
      
      on i386, an atomic operation on the caller's stack is used as the
      barrier rather than performing the store itself using xchg; this
      avoids the need to read the cache line on which the store is being
      performed. mfence is used on x86_64 where it's always available, and
      could be used on i386 with the appropriate cpu model checks if it's
      shown to perform better.
      3c43c076
  4. 25 7月, 2015 2 次提交
    • R
      fe7582f4
    • R
      fix atexit when it is called from an atexit handler · 57243b30
      Rich Felker 提交于
      The old code accepted atexit handlers after exit, but did not run them
      reliably. C11 seems to explicitly allow atexit to fail (and report
      such failure) in this case, but this situation can easily come up in
      C++ if a destructor has a local static object with a destructor so it
      should be handled.
      
      Note that the memory usage can grow linearly with the overall number
      of registered atexit handlers instead of with the worst case list
      length. (This only matters if atexit handlers keep registering atexit
      handlers which should not happen in practice).
      
      Commit message/rationale based on text by Szabolcs Nagy.
      57243b30
  5. 22 7月, 2015 3 次提交
  6. 10 7月, 2015 2 次提交
    • R
      handle loss of syslog socket connection · 0f9c2666
      Rich Felker 提交于
      when traditional syslogd implementations are restarted, the old server
      socket ceases to exist and a new unix socket with the same pathname is
      created. when this happens, the default destination address associated
      with the client socket via connect is no longer valid, and attempts to
      send produce errors. this happens despite the socket being datagram
      type, and is in contrast to the behavior that would be seen with an IP
      datagram (UDP) socket.
      
      in order to avoid a situation where the application is unable to send
      further syslog messages without calling closelog, this patch makes
      syslog attempt to reconnect the socket when send returns an error
      indicating a lost connection.
      
      additionally, initial failure to connect the socket no longer results
      in the socket being closed. this ensures that an application which
      calls openlog to reserve the socket file descriptor will not run into
      a situation where transient connection failure (e.g. due to syslogd
      restart) prevents fd reservation. however, applications which may be
      unable to connect the socket later (e.g. due to chroot, restricted
      permissions, seccomp, etc.) will still fail to log if the syslog
      socket cannot be connected at openlog time or if it has to be
      reconnected later.
      0f9c2666
    • R
      fix incorrect void return type for syncfs function · 11894f6d
      Rich Felker 提交于
      being nonstandard, the closest thing to a specification for this
      function is its man page, which documents it as returning int. it can
      fail with EBADF if the file descriptor passed is invalid.
      11894f6d
  7. 08 7月, 2015 1 次提交
  8. 07 7月, 2015 4 次提交
    • S
      add musl-clang, a wrapper for system clang installs · fb58545f
      Shiz 提交于
      musl-clang allows the user to compile musl-powered programs using their
      already existent clang install, without the need of a special cross compiler.
      it achieves this by wrapping around both the system clang install and the
      linker and passing them special flags to re-target musl at runtime.
      it does only affect invocations done through the special musl-clang wrapper
      script, so that the user setup remains fully intact otherwise.
      
      the clang wrapper consists of the compiler frontend wrapper script,
      musl-clang, and the linker wrapper script, ld.musl-clang.
      musl-clang makes sure clang invokes ld.musl-clang to link objects; neither
      script needs to be in PATH for the wrapper to work.
      fb58545f
    • S
      build: fix musl-targeting toolchain test · f8db6f74
      Shiz 提交于
      the old test was broken in that it would never fail on a toolchains built
      without dynamic linking support, leading to the wrapper script possibly being
      installed on compilers that do not support it. in addition, the new test is
      portable across compilers: the old test only worked on GCC.
      
      the new test works by testing whether the toolchain libc defines __GLIBC__:
      most non-musl Linux libc's do define this for compatibility even when they
      are not glibc, so this is a safe bet to check for musl. in addition, the
      compiler runtime would need to have a somewhat glibc-compatible ABI in the
      first place, so any non-glibc compatible libc's compiler runtime might not
      work. it is safer to disable these cases by default and have the user enable
      the wrappers manually there using --enable-wrapper if they certain it works.
      f8db6f74
    • S
      build: overhaul wrapper script system for multiple wrapper support · b3cd7d13
      Shiz 提交于
      this overhauls part of the build system in order to support multiple
      toolchain wrapper scripts, as opposed to solely the musl-gcc wrapper as
      before. it thereby replaces --enable-gcc-wrapper with --enable-wrapper=...,
      which has the options 'auto' (the default, detect whether to use wrappers),
      'all' (build and install all wrappers), 'no' (don't build any) and finally
      the options named after the individual compiler scripts (currently only
      'gcc' is available) to build and install only that wrapper.
      the old --enable-gcc-wrapper is removed from --help, but still available.
      
      it also modifies the wrappers to use the C compiler specified to the build
      system as 'inner' compiler, when applicable. as wrapper detection works by
      probing this compiler, it may not work with any other.
      b3cd7d13
    • R
      treat empty TZ environment variable as GMT rather than default · 2a780aa3
      Rich Felker 提交于
      this improves compatibility with the behavior of other systems and
      with some applications which set an empty TZ var to disable use of
      local time by mktime, etc.
      2a780aa3
  9. 28 6月, 2015 4 次提交
    • A
      dynlink.c: pass gnu-hash table pointer to gnu_lookup · 8f08a58c
      Alexander Monakov 提交于
      The callers need to check the value of the pointer anyway, so make
      them pass the pointer to gnu_lookup instead of reloading it there.
      
      Reorder gnu_lookup arguments so that always-used ones are listed
      first. GCC can choose a calling convention with arguments in registers
      (e.g. up to 3 arguments in eax, ecx, edx on x86), but cannot reorder
      the arguments for static functions.
      8f08a58c
    • A
      dynlink.c: slim down gnu_lookup · 5b4286e1
      Alexander Monakov 提交于
      Do not reference dso->syms and dso->strings until point of use.
      Check 'h1 == (h2|1)', the simplest condition, before the others.
      5b4286e1
    • A
      dynlink.c: use bloom filter in gnu hash lookup · 84389c64
      Alexander Monakov 提交于
      Introduce gnu_lookup_filtered and use it to speed up symbol lookups in
      find_sym (do_dlsym is left as is, based on an expectation that
      frequently dlsym queries will use a dlopen handle rather than
      RTLD_NEXT or RTLD_DEFAULT, and will not need to look at more than one
      DSO).
      84389c64
    • A
      dynlink.c: use a faster expression in gnu_hash · 66d45787
      Alexander Monakov 提交于
      With -Os, GCC uses a multiply rather than a shift and addition for 'h*33'.
      Use a more efficient expression explicitely.
      66d45787
  10. 26 6月, 2015 1 次提交
    • R
      fix local-dynamic model TLS on mips and powerpc · 6ba5517a
      Rich Felker 提交于
      the TLS ABI spec for mips, powerpc, and some other (presently
      unsupported) RISC archs has the return value of __tls_get_addr offset
      by +0x8000 and the result of DTPOFF relocations offset by -0x8000. I
      had previously assumed this part of the ABI was actually just an
      implementation detail, since the adjustments cancel out. however, when
      the local dynamic model is used for accessing TLS that's known to be
      in the same DSO, either of the following may happen:
      
      1. the -0x8000 offset may already be applied to the argument structure
      passed to __tls_get_addr at ld time, without any opportunity for
      runtime relocations.
      
      2. __tls_get_addr may be used with a zero offset argument to obtain a
      base address for the module's TLS, to which the caller then applies
      immediate offsets for individual objects accessed using the local
      dynamic model. since the immediate offsets have the -0x8000 adjustment
      applied to them, the base address they use needs to include the
      +0x8000 offset.
      
      it would be possible, but more complex, to store the pointers in the
      dtv[] array with the +0x8000 offset pre-applied, to avoid the runtime
      cost of adding 0x8000 on each call to __tls_get_addr. this change
      could be made later if measurements show that it would help.
      6ba5517a
  11. 23 6月, 2015 4 次提交
    • R
      make dynamic linker work around MAP_FAILED mmap failure on nommu kernels · ce337daa
      Rich Felker 提交于
      previously, loading of additional libraries beyond libc/ldso did not
      work on nommu kernels, nor did loading programs via invocation of the
      dynamic linker as a command.
      ce337daa
    • R
      reimplement strverscmp to fix corner cases · a5934142
      Rich Felker 提交于
      this interface is non-standardized and is a GNU invention, and as
      such, our implementation should match the behavior of the GNU
      function. one peculiarity the old implementation got wrong was the
      handling of all-zero digit sequences: they are supposed to compare
      greater than digit sequences of which they are a proper prefix, as in
      009 < 00.
      
      in addition, high bytes were treated with char signedness rather than
      as unsigned. this was wrong regardless of what the GNU function does
      since the resulting order relation varied by arch.
      
      the new strverscmp implementation makes explicit the cases where the
      order differs from what strcmp would produce, of which there are only
      two.
      a5934142
    • R
      fix regression/typo that disabled __simple_malloc when calloc is used · 153e952e
      Rich Felker 提交于
      commit ba819787 introduced this
      regression. since the __malloc0 weak alias was not properly provided
      by __simple_malloc, use of calloc forced the full malloc to be linked.
      153e952e
    • R
      fix calloc when __simple_malloc implementation is used · ba819787
      Rich Felker 提交于
      previously, calloc's implementation encoded assumptions about the
      implementation of malloc, accessing a size_t word just prior to the
      allocated memory to determine if it was obtained by mmap to optimize
      out the zero-filling. when __simple_malloc is used (static linking a
      program with no realloc/free), it doesn't matter if the result of this
      check is wrong, since all allocations are zero-initialized anyway. but
      the access could be invalid if it crosses a page boundary or if the
      pointer is not sufficiently aligned, which can happen for very small
      allocations.
      
      this patch fixes the issue by moving the zero-fill logic into malloc.c
      with the full malloc, as a new function named __malloc0, which is
      provided by a weak alias to __simple_malloc (which always gives
      zero-filled memory) when the full malloc is not in use.
      ba819787
  12. 20 6月, 2015 2 次提交
    • R
      provide __stack_chk_fail_local in libc.a · 55d061f0
      Rich Felker 提交于
      this symbol is needed only on archs where the PLT call ABI is klunky,
      and only for position-independent code compiled with stack protector.
      thus references usually only appear in shared libraries or PIE
      executables, but they can also appear when linking statically if some
      of the object files being linked were built as PIC/PIE.
      
      normally libssp_nonshared.a from the compiler toolchain should provide
      __stack_chk_fail_local, but reportedly it appears prior to -lc in the
      link order, thus failing to satisfy references from libc itself (which
      arise only if libc.a was built as PIC/PIE with stack protector
      enabled).
      55d061f0
    • R
      work around mips detached thread exit breakage due to kernel regression · ce3688ec
      Rich Felker 提交于
      linux kernel commit 46e12c07b3b9603c60fc1d421ff18618241cb081 caused
      the mips syscall mechanism to fail with EFAULT when the userspace
      stack pointer is invalid, breaking __unmapself used for detached
      thread exit. the workaround is to set $sp to a known-valid, readable
      address, and the simplest one to obtain is the address of the current
      function, which is available (per o32 calling convention) in $25.
      ce3688ec
  13. 18 6月, 2015 1 次提交
  14. 16 6月, 2015 8 次提交
    • R
      switch to using trap number 31 for syscalls on sh · 10d0268c
      Rich Felker 提交于
      nominally the low bits of the trap number on sh are the number of
      syscall arguments, but they have never been used by the kernel, and
      some code making syscalls does not even know the number of arguments
      and needs to pass an arbitrary high number anyway.
      
      sh3/sh4 traditionally used the trap range 16-31 for syscalls, but part
      of this range overlapped with hardware exceptions/interrupts on sh2
      hardware, so an incompatible range 32-47 was chosen for sh2.
      
      using trap number 31 everywhere, since it's in the existing sh3/sh4
      range and does not conflict with sh2 hardware, is a proposed
      unification of the kernel syscall convention that will allow binaries
      to be shared between sh2 and sh3/sh4. if this is not accepted into the
      kernel, we can refit the sh2 target with runtime selection mechanisms
      for the trap number, but doing so would be invasive and would entail
      non-trivial overhead.
      10d0268c
    • R
      switch sh port's __unmapself to generic version when running on sh2/nommu · 3366a99b
      Rich Felker 提交于
      due to the way the interrupt and syscall trap mechanism works,
      userspace on sh2 must never set the stack pointer to an invalid value.
      thus, the approach used on most archs, where __unmapself executes with
      no stack for the interval between SYS_munmap and SYS_exit, is not
      viable on sh2.
      
      in order not to pessimize sh3/sh4, the sh asm version of __unmapself
      is not removed. instead it's renamed and redirected through code that
      calls either the generic (safe) __unmapself or the sh3/sh4 asm,
      depending on compile-time and run-time conditions.
      3366a99b
    • R
      add support for sh2 interrupt-masking-based atomics to sh port · f9d84554
      Rich Felker 提交于
      the sh2 target is being considered an ISA subset of sh3/sh4, in the
      sense that binaries built for sh2 are intended to be usable on later
      cpu models/kernels with mmu support. so rather than hard-coding
      sh2-specific atomics, the runtime atomic selection mechanisms that was
      already in place has been extended to add sh2 atomics.
      
      at this time, the sh2 atomics are not SMP-compatible; since the ISA
      lacks actual atomic operations, the new code instead masks interrupts
      for the duration of the atomic operation, producing an atomic result
      on single-core. this is only possible because the kernel/hardware does
      not impose protections against userspace doing so. additional changes
      will be needed to support future SMP systems.
      
      care has been taken to avoid producing significant additional code
      size in the case where it's known at compile-time that the target is
      not sh2 and does not need sh2-specific code.
      f9d84554
    • R
      refactor stdio open file list handling, move it out of global libc struct · 1b0cdc87
      Rich Felker 提交于
      functions which open in-memory FILE stream variants all shared a tail
      with __fdopen, adding the FILE structure to stdio's open file list.
      replacing this common tail with a function call reduces code size and
      duplication of logic. the list is also partially encapsulated now.
      
      function signatures were chosen to facilitate tail call optimization
      and reduce the need for additional accessor functions.
      
      with these changes, static linked programs that do not use stdio no
      longer have an open file list at all.
      1b0cdc87
    • R
      byte-based C locale, phase 3: make MB_CUR_MAX variable to activate code · f22a9eda
      Rich Felker 提交于
      this patch activates the new byte-based C locale (high bytes treated
      as abstract code unit "characters" rather than decoded as multibyte
      characters) by making the value of MB_CUR_MAX depend on the active
      locale. for the C locale, the LC_CTYPE category pointer is null,
      yielding a value of 1. all other locales yield a value of 4.
      f22a9eda
    • R
      byte-based C locale, phase 2: stdio and iconv (multibyte callers) · 16f18d03
      Rich Felker 提交于
      this patch adjusts libc components which use the multibyte functions
      internally, and which depend on them operating in a particular
      encoding, to make the appropriate locale changes before calling them
      and restore the calling thread's locale afterwards. activating the
      byte-based C locale without these changes would cause regressions in
      stdio and iconv.
      
      in the case of iconv, the current implementation was simply using the
      multibyte functions as UTF-8 conversions. setting a multibyte UTF-8
      locale for the duration of the iconv operation allows the code to
      continue working.
      
      in the case of stdio, POSIX requires that FILE streams have an
      encoding rule bound at the time of setting wide orientation. as long
      as all locales, including the C locale, used the same encoding,
      treating high bytes as UTF-8, there was no need to store an encoding
      rule as part of the stream's state.
      
      a new locale field in the FILE structure points to the locale that
      should be made active during fgetwc/fputwc/ungetwc on the stream. it
      cannot point to the locale active at the time the stream becomes
      oriented, because this locale could be mutable (the global locale) or
      could be destroyed (locale_t objects produced by newlocale) before the
      stream is closed. instead, a pointer to the static C or C.UTF-8 locale
      object added in commit commit aeeac9ca
      is used. this is valid since categories other than LC_CTYPE will not
      affect these functions.
      16f18d03
    • R
      byte-based C locale, phase 1: multibyte character handling functions · 1507ebf8
      Rich Felker 提交于
      this patch makes the functions which work directly on multibyte
      characters treat the high bytes as individual abstract code units
      rather than as multibyte sequences when MB_CUR_MAX is 1. since
      MB_CUR_MAX is presently defined as a constant 4, all of the new code
      added is dead code, and optimizing compilers' code generation should
      not be affected at all. a future commit will activate the new code.
      
      as abstract code units, bytes 0x80 to 0xff are represented by wchar_t
      values 0xdf80 to 0xdfff, at the end of the surrogates range. this
      ensures that they will never be misinterpreted as Unicode characters,
      and that all wctype functions return false for these "characters"
      without needing locale-specific logic. a high range outside of Unicode
      such as 0x7fffff80 to 0x7fffffff was also considered, but since C11's
      char16_t also needs to be able to represent conversions of these
      bytes, the surrogate range was the natural choice.
      1507ebf8
    • R
      fix btowc corner case · 38e2f727
      Rich Felker 提交于
      btowc is required to interpret its argument by conversion to unsigned
      char, unless the argument is equal to EOF. since the conversion to
      produces a non-character value anyway, we can just unconditionally
      convert, for now.
      38e2f727
  15. 14 6月, 2015 3 次提交
    • S
      arm: add vdso support · ee59c296
      Szabolcs Nagy 提交于
      vdso will be available on arm in linux v4.2, the user-space code
      for it is in kernel commit 8512287a8165592466cb9cb347ba94892e9c56a5
      ee59c296
    • R
      refactor malloc's expand_heap to share with __simple_malloc · e3bc22f1
      Rich Felker 提交于
      this extends the brk/stack collision protection added to full malloc
      in commit 276904c2 to also protect the
      __simple_malloc function used in static-linked programs that don't
      reference the free function.
      
      it also extends support for using mmap when brk fails, which full
      malloc got in commit 54463033, to
      __simple_malloc.
      
      since __simple_malloc may expand the heap by arbitrarily large
      increments, the stack collision detection is enhanced to detect
      interval overlap rather than just proximity of a single address to the
      stack. code size is increased a bit, but this is partly offset by the
      sharing of code between the two malloc implementations, which due to
      linking semantics, both get linked in a program that needs the full
      malloc with realloc/free support.
      e3bc22f1
    • R
      remove cancellation points in stdio · 4ef9b828
      Rich Felker 提交于
      commit 58165923 added these optional
      cancellation points on the basis that cancellable stdio could be
      useful, to unblock threads stuck on stdio operations that will never
      complete. however, the only way to ensure that cancellation can
      achieve this is to violate the rules for side effects when
      cancellation is acted upon, discarding knowledge of any partial data
      transfer already completed. our implementation exhibited this behavior
      and was thus non-conforming.
      
      in addition to improving correctness, removing these cancellation
      points moderately reduces code size, and should significantly improve
      performance on i386, where sysenter/syscall instructions can be used
      instead of "int $128" for non-cancellable syscalls.
      4ef9b828
  16. 13 6月, 2015 2 次提交
    • R
      fix idiom for setting stdio stream orientation to wide · 536c6d5a
      Rich Felker 提交于
      the old idiom, f->mode |= f->mode+1, was adapted from the idiom for
      setting byte orientation, f->mode |= f->mode-1, but the adaptation was
      incorrect. unless the stream was alreasdy set byte-oriented, this code
      incremented f->mode each time it was executed, which would eventually
      lead to overflow. it could be fixed by changing it to f->mode |= 1,
      but upcoming changes will require slightly more work at the time of
      wide orientation, so it makes sense to just call fwide. as an
      optimization in the single-character functions, fwide is only called
      if the stream is not already wide-oriented.
      536c6d5a
    • R
      add printing of null %s arguments as "(null)" in wide printf · f8f565df
      Rich Felker 提交于
      this is undefined, but supported in our implementation of the normal
      printf, so for consistency the wide variant should support it too.
      f8f565df