• R
    fix failure to obtain EOWNERDEAD status for process-shared robust mutexes · 384d103d
    Rich Felker 提交于
    Linux's documentation (robust-futex-ABI.txt) claims that, when a
    process dies with a futex on the robust list, bit 30 (0x40000000) is
    set to indicate the status. however, what actually happens is that
    bits 0-30 are replaced with the value 0x40000000, i.e. bits 0-29
    (containing the old owner tid) are cleared at the same time bit 30 is
    set.
    
    our userspace-side code for robust mutexes was written based on that
    documentation, assuming that kernel would never produce a futex value
    of 0x40000000, since the low (owner) bits would always be non-zero.
    commit d338b506 introduced this
    assumption explicitly while fixing another bug in how non-recoverable
    status for robust mutexes was tracked. presumably the tests conducted
    at that time only checked non-process-shared robust mutexes, which are
    handled in pthread_exit (which implemented the documented kernel
    protocol, not the actual one) rather than by the kernel.
    
    change pthread_exit robust list processing to match the kernel
    behavior, clearing bits 0-29 while setting bit 30, and use the value
    0x7fffffff instead of 0x40000000 to encode non-recoverable status. the
    choice of value here is arbitrary; any value with at least one of bits
    0-29 set should work just as well,
    384d103d
pthread_create.c 8.4 KB