• R
    remove useless check of bin match in malloc · 064898cf
    Rich Felker 提交于
    this re-check idiom seems to have been copied from the alloc_fwd and
    alloc_rev functions, which guess a bin based on non-synchronized
    memory access to adjacent chunk headers then need to confirm, after
    locking the bin, that the chunk is actually in the bin they locked.
    
    the check being removed, however, was being performed on a chunk
    obtained from the already-locked bin. there is no race to account for
    here; the check could only fail in the event of corrupt free lists,
    and even then it would not catch them but simply continue running.
    
    since the bin_index function is mildly expensive, it seems preferable
    to remove the check rather than trying to convert it into a useful
    consistency check. casual testing shows a 1-5% reduction in run time.
    064898cf
malloc.c 11.7 KB