- 15 9月, 2018 1 次提交
-
-
由 Behdad Esfahbod 提交于
An offset to unsized arrayis not safe to be redirected to our fixed-sized null pool. Plus, we want to reject, not repair, bad-looking dfonts.
-
- 14 9月, 2018 10 次提交
-
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
Just to disagree with myself re being done with this code...
-
由 Behdad Esfahbod 提交于
Previously, ResourceForkHeader was defined as 30 bytes, having the typeCountM1 as last member. There was a mysterious offset-by-2 in the code, derived from FontTools and JDK code this was ported from. In testing, I observed that typeListZ offset is actually 28. Suggesting that the typeCountM1 does NOT actually belong to ResourceForkHeader, but belongs to the array itself. Adjusting for that resolves the mystery +2 offset hack, so everything is clean and good now. This, concludes my dfont hacking. The code looks great now, and I'm happy to leave it. Fuzzers might disagree though, we will see!
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
Offset 0 is not null in this context.
-
由 Behdad Esfahbod 提交于
-
- 13 9月, 2018 1 次提交
-
-
由 Behdad Esfahbod 提交于
I don't think I broke anything. Fuzzers will let me know..
-
- 12 9月, 2018 1 次提交
-
-
由 Behdad Esfahbod 提交于
-
- 11 9月, 2018 5 次提交
-
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
I have no way to authoritatively know, but looks like test font only has one face. So, adjust test expectation instead.
-
-
由 Behdad Esfahbod 提交于
-
- 08 9月, 2018 1 次提交
-
-
由 Behdad Esfahbod 提交于
Technically, static const needs an out-of-class definition. Eg: CXXLD libharfbuzz-subset.la Undefined symbols for architecture x86_64: "OT::FeatureVariationRecord::min_size", referenced from: bool OT::GSUBGPOS::subset<OT::PosLookup>(hb_subset_context_t*) constin libharfbuzz_subset_la-hb-subset.o bool OT::GSUBGPOS::subset<OT::SubstLookup>(hb_subset_context_t*) constin libharfbuzz_subset_la-hb-subset.o "OT::Record<OT::LangSys>::min_size", referenced from: OT::Script::subset(hb_subset_context_t*) constin libharfbuzz_subset_la-hb-subset.o "OT::IntType<unsigned short, 2u>::min_size", referenced from: OT::Script::subset(hb_subset_context_t*) constin libharfbuzz_subset_la-hb-subset.o OT::RecordListOf<OT::Feature>::subset(hb_subset_context_t*) const in libharfbuzz_subset_la-hb-subset.o ld: symbol(s) not found for architecture x86_64 collect2: ld returned 1 exit status make[4]: *** [libharfbuzz-subset.la] Error 1 make[3]: *** [all-recursive] Error 1 make[2]: *** [all] Error 2 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 Exited with code 2
-
- 01 9月, 2018 1 次提交
-
-
由 Behdad Esfahbod 提交于
-
- 26 8月, 2018 1 次提交
-
-
由 Behdad Esfahbod 提交于
Sorry for the noise, downstream custom builders. Please adjust.
-
- 23 7月, 2018 1 次提交
-
-
由 Behdad Esfahbod 提交于
-
- 03 7月, 2018 1 次提交
-
-
由 Behdad Esfahbod 提交于
The get_table imple was wrong, as table offsets in a dfont are relative to the resource. We were treating them as relative to the big blob itself. To be fixed. Part of https://github.com/harfbuzz/harfbuzz/pull/1085
-
- 01 7月, 2018 1 次提交
-
-
由 Ebrahim Byagowi 提交于
-
- 09 5月, 2018 1 次提交
-
-
由 Behdad Esfahbod 提交于
-
- 11 4月, 2018 1 次提交
-
-
由 Ebrahim Byagowi 提交于
-
- 23 3月, 2018 1 次提交
-
-
由 Ebrahim Byagowi 提交于
-
- 24 2月, 2018 2 次提交
-
-
由 Behdad Esfahbod 提交于
Test still fails, because we do not serialize tables in the same order that fonttools subsetter does.
-
由 Behdad Esfahbod 提交于
-
- 21 2月, 2018 1 次提交
-
-
由 Garret Rieger 提交于
-
- 13 2月, 2018 1 次提交
-
-
由 Rod Sheeter 提交于
-
- 11 2月, 2018 1 次提交
-
-
由 Behdad Esfahbod 提交于
-
- 09 2月, 2018 2 次提交
-
-
由 Rod Sheeter 提交于
-
由 Rod Sheeter 提交于
-
- 08 2月, 2018 5 次提交
-
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
- 10 1月, 2018 1 次提交
-
-
由 Behdad Esfahbod 提交于
Such a headache that Windows defines UINT8, ...; Just prefix it.
-