1. 24 2月, 2016 7 次提交
  2. 23 2月, 2016 4 次提交
  3. 22 2月, 2016 13 次提交
  4. 19 2月, 2016 6 次提交
  5. 18 2月, 2016 2 次提交
  6. 16 2月, 2016 2 次提交
    • B
      [USE] Zero mark advances by GDEF early · da41e48f
      Behdad Esfahbod 提交于
      This is what Microsoft's implementation does.  Marks that need advance
      need to add it back using 'dist' or other feature in GPOS.  Update tests to
      match.
      da41e48f
    • B
      [GPOS] Fix interaction of mark attachments and cursive chaining · 86c68c7a
      Behdad Esfahbod 提交于
      Fixes https://github.com/behdad/harfbuzz/issues/211
      
      What happens in that bug is that a mark is attached to base first,
      then a second mark is cursive-chained to the first mark.  This only
      "works" because it's in the Indic shaper where mark advances are
      not zeroed.
      
      Before, we didn't allow cursive to run on marks at all.  Fix that.
      We also where updating mark major offsets at the end of GPOS, such
      that changes in advance of base will not change the mark attachment
      position.  That was superior to the alternative (which is what Uniscribe
      does BTW), but made it hard to apply cursive to the mark after it
      was positioned.  We could track major-direction offset changes and
      apply that to cursive in the post process, but that's a much trickier
      thing to do than the fix here, which is to immediately apply the
      major-direction advance-width offsets...  Ie.:
      
      https://github.com/behdad/harfbuzz/issues/211#issuecomment-183194739
      
      If this breaks any fonts, the font should be fixed to do mark attachment
      after all the advances are set up first (kerning, etc).
      
      Finally, this, still doesn't make us match Uniscribe, for I explained
      in that bug.  Looks like Uniscribe applies minor-direction cursive
      adjustment immediate as well.  We don't, and we like it our way, at
      least for now.  Eg. the sequence in the test case does this:
      
      - The first subscript attaches with mark-to-base, moving in x only,
      - The second subscript attaches with cursive attachment to first subscript
        moving in x only,
      - A final context rule moves the first subscript up by 104 units.
      
      The way we do, the final shift-up, also shifts up the second subscript
      mark because it's cursively-attached.  Uniscribe doesn't.  We get:
      
      [ttaorya=0+1307|casubscriptorya=0@-242,104+-231|casubscriptnarroworya=0@20,104+507]
      
      while Uniscribe gets:
      
      [ttaorya=0+1307|casubscriptorya=0@-242,104+-211|casubscriptnarroworya=0+487]
      
      note the different y-offset of the last glyph.  In our view, after cursive,
      things move together, period.
      86c68c7a
  7. 12 2月, 2016 1 次提交
  8. 11 2月, 2016 5 次提交