- 30 10月, 2018 18 次提交
-
-
由 Behdad Esfahbod 提交于
I keep forgetting that primitive types are NOT initialized during construction. :|
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
See a85641446c30247c4e948263f0f8c1147ed4efb9
-
由 Behdad Esfahbod 提交于
Disable copy/assign on them, as they shouldn't. Make constructor / destructor call init_shallow/fini_shallow, and make those idempotent. So, these three can be constructed on stack now and no init/fini call is needed. As such, hb_auto_t<> is not needed anymore. I'll remove that separately.
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
It was arbitrary that this struct had it and not dozens of others.
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
Older C++ doesn't allow struct-with-constructor in union.
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
Newer compilers / language allows structs with constructor in union. So, this was not actually testing anything. Indeed, the recent change in DISALLOW_COPY *is* making some of our types non-POD. That broke some bots. Just remove this since it wasn't doing much, and I'd rather have DISALLOW_COPY.
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
Finally! Catches hard-to-find errors like this: - const SortedArrayOf<SVGDocumentIndexEntry> docs = this+svgDocEntries; + const SortedArrayOf<SVGDocumentIndexEntry> &docs = this+svgDocEntries; We implement this for our array types. This, in turn, trickles down into all types that embed the arrays. So, as long as we define all open-ended structs in terms of Array types (all can be done using UnsizedArrayOf), this achieves the goal of making uncopyable all structs that are variable-sized. Yay!
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
- 29 10月, 2018 22 次提交
-
-
由 Ebrahim Byagowi 提交于
-
由 Ebrahim Byagowi 提交于
-
由 Ebrahim Byagowi 提交于
Revive and rename dump-emoji to test-ot-color but use public APIs instead
-
由 Ebrahim Byagowi 提交于
-
由 Ebrahim Byagowi 提交于
-
由 Ebrahim Byagowi 提交于
-
由 Ebrahim Byagowi 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Ebrahim Byagowi 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-