- 19 3月, 2013 1 次提交
-
-
由 Behdad Esfahbod 提交于
After the Ngapi hackfest work, we were assuming that fonts won't use presentation features to choose specific forms (eg. conjuncts). As such, we were using auto-joiner behavior for such features. It proved to be troublesome as many fonts used presentation forms ('pres') for example to form conjuncts, which need to be disabled when a ZWJ is inserted. Two examples: U+0D2F,U+200D,U+0D4D,U+0D2F with kartika.ttf U+0995,U+09CD,U+200D,U+09B7 with vrinda.ttf What we do now is to never do magic to ZWJ during GSUB's main input match for Indic-style shapers. Note that backtrack/lookahead are still matched liberally, as is GPOS. This seems to be an acceptable compromise. As to the bug that initially started this work, that one needs to be fixed differently: Bug 58714 - Kannada u+0cb0 u+200d u+0ccd u+0c95 u+0cbe does not provide same results as Windows8 https://bugs.freedesktop.org/show_bug.cgi?id=58714 New numbers: BENGALI: 353689 out of 354188 tests passed. 499 failed (0.140886%) DEVANAGARI: 707305 out of 707394 tests passed. 89 failed (0.0125814%) GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%) GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%) KANNADA: 951030 out of 951913 tests passed. 883 failed (0.0927606%) KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1048102 out of 1048334 tests passed. 232 failed (0.0221304%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271666 out of 271847 tests passed. 181 failed (0.0665816%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
-
- 15 2月, 2013 3 次提交
-
-
由 Behdad Esfahbod 提交于
Surprisingly, if user ever tried to turn a default feature off partially (say, disable liga for a range), the feature was being turned off globally! Fixed now.
-
由 Behdad Esfahbod 提交于
Not for Arabic, but for Indic-like scripts. ZWJ/ZWNJ have special meanings in those scripts, so let font lookups take full control. This undoes the regression caused by automatic-joiners handling introduced two commits ago. We only disable automatic joiner handling for the "basic shaping features" of Indic, Myanmar, and SEAsian shapers. The "presentation forms" and other features are still applied with automatic-joiner handling. This change also changes the test suite failure statistics, such that a few scripts show more "failures". The most affected is Kannada. However, upon inspection, we believe that in most, if not all, of the new failures, we are producing results superior to Uniscribe. Hard to count those! Here's an example of what is fixed by the recent joiner-handling changes: https://bugs.freedesktop.org/show_bug.cgi?id=58714 New numbers, for future reference: BENGALI: 353892 out of 354188 tests passed. 296 failed (0.0835714%) DEVANAGARI: 707336 out of 707394 tests passed. 58 failed (0.00819911%) GUJARATI: 366262 out of 366457 tests passed. 195 failed (0.0532122%) GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%) KANNADA: 950680 out of 951913 tests passed. 1233 failed (0.129529%) KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%) LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%) MALAYALAM: 1047983 out of 1048334 tests passed. 351 failed (0.0334817%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271539 out of 271847 tests passed. 308 failed (0.113299%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%) TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
-
由 Behdad Esfahbod 提交于
Code cleanup. No (intended) functional change.
-
- 16 11月, 2012 2 次提交
-
-
由 Behdad Esfahbod 提交于
API additions: hb_segment_properties_t HB_SEGMENT_PROPERTIES_DEFAULT hb_segment_properties_equal() hb_segment_properties_hash() hb_buffer_set_segment_properties() hb_buffer_get_segment_properties() hb_ot_layout_glyph_class_t hb_shape_plan_t hb_shape_plan_create() hb_shape_plan_create_cached() hb_shape_plan_get_empty() hb_shape_plan_reference() hb_shape_plan_destroy() hb_shape_plan_set_user_data() hb_shape_plan_get_user_data() hb_shape_plan_execute() hb_ot_shape_plan_collect_lookups() API changes: Rename hb_ot_layout_feature_get_lookup_indexes() to hb_ot_layout_feature_get_lookups(). New header file: hb-shape-plan.h And a bunch of prototyped but not implemented stuff. Coming soon. (Tests fail because of the prototypes right now.)
-
由 Behdad Esfahbod 提交于
To match upcoming API.
-
- 15 11月, 2012 1 次提交
-
-
由 Behdad Esfahbod 提交于
-
- 13 11月, 2012 1 次提交
-
-
由 Behdad Esfahbod 提交于
-
- 06 9月, 2012 1 次提交
-
-
由 Behdad Esfahbod 提交于
All of init/medi/fina/isol and rlig implemented. Let there be dragons... ⻯
-
- 05 9月, 2012 1 次提交
-
-
由 Behdad Esfahbod 提交于
-
- 24 8月, 2012 1 次提交
-
-
由 Behdad Esfahbod 提交于
To be used in the next patch.
-
- 02 8月, 2012 6 次提交
-
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
We need the font for glyph lookup during GSUB pauses in Indic shaper. Could perhaps be avoided, but at this point, we don't mean to support separate substitute()/position() entry points (anymore), so there is no point in not providing the font to GSUB.
-
由 Behdad Esfahbod 提交于
It was impossible to meaningfully use them from the outside these days.
-
由 Behdad Esfahbod 提交于
Comes with some 10% speedup for Devanagari even!
-
- 30 7月, 2012 1 次提交
-
-
由 Behdad Esfahbod 提交于
-
- 09 6月, 2012 1 次提交
-
-
由 Behdad Esfahbod 提交于
-
- 24 4月, 2012 2 次提交
-
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
- 05 8月, 2011 1 次提交
-
-
由 Behdad Esfahbod 提交于
Where causing issues for people with MSVC.
-
- 31 7月, 2011 1 次提交
-
-
由 Behdad Esfahbod 提交于
-
- 08 7月, 2011 3 次提交
-
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=644184 among others. Shapers now can request segmented feature application by calling add_gsub_pause() or add_gpos_pause(). They can also provide a callback to be called at the pause. Currently the Arabic shaper uses pauses to enforce certain feature application. The Indic shaper can use the same facility to pause and do reordering in the callback.
-
- 15 6月, 2011 1 次提交
-
-
由 Behdad Esfahbod 提交于
-
- 28 5月, 2011 2 次提交
-
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
Respectively, separate planner from the actual plan.
-
- 06 5月, 2011 3 次提交
-
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
- 22 4月, 2011 1 次提交
-
-
由 Behdad Esfahbod 提交于
-
- 19 4月, 2011 1 次提交
-
-
由 Behdad Esfahbod 提交于
This simplifies the code, reduces static data, and makes the design more extensible to future additions of new scripts.
-
- 14 10月, 2010 2 次提交
-
-
由 Behdad Esfahbod 提交于
Previously boolean features turned on the entire feature mask. This is wrong if feature is Alternate and user has provided values bigger than one. Though, I don't think other engines support such corner cases.
-
由 Behdad Esfahbod 提交于
Previously if a default global feature was overrided by a non-global user feature, we were not setting any default mask for the feature, essentially disabling the feature by default. Fix that.
-
- 13 10月, 2010 4 次提交
-
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-