1. 28 2月, 2013 6 次提交
  2. 27 2月, 2013 3 次提交
    • B
      [Indic] Sort pre-base reordering consonants with post-forms · 94789fd6
      Behdad Esfahbod 提交于
      Before, we were marking them as below-form for initial reordering.
      However, there is a rule that says "post consonants should follow
      below consonsnts" for base determination purposes.  Malayalam has
      port-form YA/VA, and RA is pre-base.  As such, for a sequence like
      YA,Virama,YA,Virama,RA, the correct base is at index 0.  But
      because the code was seeing RA as a below-base, it was stopping at
      the second YA as base, instead of jumping it as a post-base.
      
      By treating prebase-reordering consonants like post-forms, this
      is fixed.
      
      MALAYALAM went down from 351 to 265.  Other numbers didn't change:
      
      BENGALI: 353686 out of 354188 tests passed. 502 failed (0.141733%)
      DEVANAGARI: 707305 out of 707394 tests passed. 89 failed (0.0125814%)
      GUJARATI: 366262 out of 366457 tests passed. 195 failed (0.0532122%)
      GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%)
      KANNADA: 950680 out of 951913 tests passed. 1233 failed (0.129529%)
      KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%)
      LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%)
      MALAYALAM: 1048069 out of 1048334 tests passed. 265 failed (0.0252782%)
      ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
      SINHALA: 271539 out of 271847 tests passed. 308 failed (0.113299%)
      TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
      TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
      TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
      94789fd6
    • B
      [tests] Add Malayalam tests frim cibu · 6d69a2ce
      Behdad Esfahbod 提交于
      6d69a2ce
    • B
      Update Android.mk · 1edc6b97
      Behdad Esfahbod 提交于
      1edc6b97
  3. 26 2月, 2013 6 次提交
    • B
      Fix "comparison between signed and unsigned" warnings · 05d5d3cd
      Behdad Esfahbod 提交于
      Patch from Jonathan Kew.
      05d5d3cd
    • B
      Give up sanitizing after 100 edit requests · 07a52b62
      Behdad Esfahbod 提交于
      Such fonts are *definitely* really broken.  Give up.
      Limits time spent in sanitize for extremely / deliberately broken
      fonts.  For example, two fonts with these md5sum / names:
      
        9343f0a1b8c84b8123e7d201cae62ffd.ttf
        eb8c978547f09d368fc204194fb34688.ttf
      
      were spending over a second in sanitize!  Not anymore.
      07a52b62
    • B
      Add HB_DEBUG_VERBOSE · 29ff2548
      Behdad Esfahbod 提交于
      Only affects the verbosity of function name printing right now.
      29ff2548
    • B
      0.9.13 · 05686b5f
      Behdad Esfahbod 提交于
      05686b5f
    • B
      Fix blob test to match c3ba49b6 · 9e5ac7b8
      Behdad Esfahbod 提交于
      9e5ac7b8
    • B
      Always create sub-blobs in MEMORY_MODE_READONLY · c3ba49b6
      Behdad Esfahbod 提交于
      This fixes a design bug with sanitize and sub-blobs that can
      cause crashes.  Jonathan and I found and debugged this issue
      when we tested a corrupt font with the md5sum / filename:
      ea395483d37af0cb933f40689ff7b60a.  Two hours of intense
      debugging we found out that the font has overlapping GSUB/GPOS
      tables, and as such, sanitizing the second table can modify
      the first one, which can cause all kinds of undefined behavior.
      
      The correct way to fix this is to make sure sub-blobs are
      always created readonly, since we consider the parent blob
      to be a shared resource and can't modify it, even if it *is*
      writable.
      
      This essentially makes the READONLY_MAY_MAKE_WRITABLE mode
      unused...  Maybe we should simply remove / deprecate it.
      c3ba49b6
  4. 22 2月, 2013 6 次提交
    • B
      Minor · 57542d7f
      Behdad Esfahbod 提交于
      57542d7f
    • B
      Port TrueType-kerning to use skippy iterator · d46606e1
      Behdad Esfahbod 提交于
      It skips joiners and default ignorables now.  Skips marks too, but only
      if there is proper GDEF classes for marks.
      d46606e1
    • B
      Fixup previous commit · 722e8b85
      Behdad Esfahbod 提交于
      Was not decreasing num_items.  Ouch!
      722e8b85
    • B
      Move code around · ba87b8fc
      Behdad Esfahbod 提交于
      ba87b8fc
    • B
      [OTLayout] Correctly skip Default_Ignorable when match_func not set · 2b2a6e89
      Behdad Esfahbod 提交于
      When a match_func was not set on the matcher_t object (ie. from GPOS),
      then the Default_Ignorables (including joiners) were never skipped.
      This meant that they were not skipped as they should during GPOS
      matching.  Fix that.
      
      A few Indic numbers have "regressed": BENGALI and DEVANAGARI went
      up from 290 and 58 respectively, but in both cases new results are
      superior to Uniscribe, as they apply GPOS when we weren't (and
      Uniscribe isn't) before.
      BENGALI: 353686 out of 354188 tests passed. 502 failed (0.141733%)
      DEVANAGARI: 707305 out of 707394 tests passed. 89 failed (0.0125814%)
      GUJARATI: 366262 out of 366457 tests passed. 195 failed (0.0532122%)
      GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%)
      KANNADA: 950680 out of 951913 tests passed. 1233 failed (0.129529%)
      KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%)
      LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%)
      MALAYALAM: 1047983 out of 1048334 tests passed. 351 failed (0.0334817%)
      ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
      SINHALA: 271539 out of 271847 tests passed. 308 failed (0.113299%)
      TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
      TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
      TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
      2b2a6e89
    • B
      Minor · ff93ac8c
      Behdad Esfahbod 提交于
      ff93ac8c
  5. 19 2月, 2013 2 次提交
  6. 18 2月, 2013 1 次提交
  7. 16 2月, 2013 2 次提交
  8. 15 2月, 2013 14 次提交
    • B
      Remove TODO items that don't make sense · ebb77b9c
      Behdad Esfahbod 提交于
      The spec says those features need to be disabled by default.
      ebb77b9c
    • B
      [Arabic] Fix shaping of left-joining 'Phags-Pa U+A872 · c2a1cdc4
      Behdad Esfahbod 提交于
      This is the first character in Unicode to have Arabic left-joining
      behavior.  Update the machine to recognize that.
      
      Test case: U+A840,U+A872,U+A840.
      c2a1cdc4
    • B
      [tests] Add Syriac Alaph shaping test cases · 05ac8781
      Behdad Esfahbod 提交于
      05ac8781
    • B
      Disable automatic segment properties guessing · c462b32d
      Behdad Esfahbod 提交于
      Before, if one called hb_shape() without setting script, language, and
      direction on the buffer, hb_shape() was calling
      hb_buffer_guess_segment_properties() on the user's behalf to guess
      these.
      
      This is very dangerous, since any serious user of HarfBuzz must set
      these properly (specially important is direction).  So now, we don't
      guess properties by default.  People not setting direction will get
      an abort() now.  If the old behavior is desired (fragile, good for
      simple testing only), users can call
      hb_buffer_guess_segment_properties() on the buffer just before calling
      hb_shape().
      c462b32d
    • B
      Add assertions for a couple programmer errors · 7abddbb4
      Behdad Esfahbod 提交于
      7abddbb4
    • B
      Allow disabling of TrueType kerning · 038c98f6
      Behdad Esfahbod 提交于
      Responds to the same feature tag that GPOS kerning does:
      'kern' for horizontal and 'vkrn' for vertical.
      038c98f6
    • B
      Fix partial disabling of default-on features · 398238a2
      Behdad Esfahbod 提交于
      Surprisingly, if user ever tried to turn a default feature off partially
      (say, disable liga for a range), the feature was being turned off
      globally!  Fixed now.
      398238a2
    • B
      [OTLayout] Respect syllable boundaries for backtrack/lookahead matching · cb90b1bb
      Behdad Esfahbod 提交于
      Originally we meant to match backtrack/lookahead across syllable
      boundaries.  But a bug in the code meant that this was NOT done for
      backtrack.  We "fixed" that in 2c7d0b6b,
      but that broke Myanmar shaping.
      
      We now believe that for Indic-like shapers (which is where syllables are
      used), all basic shaping forms should be fully contained within their
      syllables, so now we limit backtrack/lookahead matching to the syllable
      too.  Unbreaks Myanmar.
      cb90b1bb
    • B
      Minor refactoring · ee9c3a17
      Behdad Esfahbod 提交于
      ee9c3a17
    • B
      [Indic-like] Disable automatic joiner handling for basic shaping features · cfc507c5
      Behdad Esfahbod 提交于
      Not for Arabic, but for Indic-like scripts.  ZWJ/ZWNJ have special
      meanings in those scripts, so let font lookups take full control.
      
      This undoes the regression caused by automatic-joiners handling
      introduced two commits ago.
      
      We only disable automatic joiner handling for the "basic shaping
      features" of Indic, Myanmar, and SEAsian shapers.  The "presentation
      forms" and other features are still applied with automatic-joiner
      handling.
      
      This change also changes the test suite failure statistics, such that
      a few scripts show more "failures".  The most affected is Kannada.
      However, upon inspection, we believe that in most, if not all, of the
      new failures, we are producing results superior to Uniscribe.  Hard to
      count those!
      
      Here's an example of what is fixed by the recent joiner-handling
      changes:
      
        https://bugs.freedesktop.org/show_bug.cgi?id=58714
      
      New numbers, for future reference:
      
      BENGALI: 353892 out of 354188 tests passed. 296 failed (0.0835714%)
      DEVANAGARI: 707336 out of 707394 tests passed. 58 failed (0.00819911%)
      GUJARATI: 366262 out of 366457 tests passed. 195 failed (0.0532122%)
      GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%)
      KANNADA: 950680 out of 951913 tests passed. 1233 failed (0.129529%)
      KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%)
      LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%)
      MALAYALAM: 1047983 out of 1048334 tests passed. 351 failed (0.0334817%)
      ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
      SINHALA: 271539 out of 271847 tests passed. 308 failed (0.113299%)
      TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
      TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
      TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
      cfc507c5
    • B
      [OTLayout] Add fine-grained control over ZWJ matching · 0b454791
      Behdad Esfahbod 提交于
      Not used yet.  Next commit...
      0b454791
    • B
      [OTLayout] Ignore default-ignorables when matching GSUB/GPOS · 607feb7c
      Behdad Esfahbod 提交于
      When matching lookups, be smart about default-ignorable characters.
      In particular:
      
      Do nothing specific about ZWNJ, but for the other default-ignorables:
      
      If the lookup in question uses the ignorable character in a sequence,
      then match it as we used to do.  However, if the sequence match will
      fail because the default-ignorable blocked it, try skipping the
      ignorable character and continue.
      
      The most immediate thing it means is that if Lam-Alef forms a ligature,
      then Lam-ZWJ-Alef will do to.  Finally!
      
      One exception: when matching for GPOS, or for backtrack/lookahead of
      GSUB, we ignore ZWNJ too.  That's the right thing to do.
      
      It certainly is possible to build fonts that this feature will result
      in undesirable glyphs, but it's hard to think of a real-world case
      that that would happen.
      
      This *does* break Indic shaping right now, since Indic Unicode has
      specific rules for what ZWJ/ZWNJ mean, and skipping ZWJ is breaking
      those rules.  That will be fixed in upcoming commits.
      607feb7c
    • B
      Add hb_ot_map_feature_flags_t · ec544866
      Behdad Esfahbod 提交于
      Code cleanup.  No (intended) functional change.
      ec544866
    • B
      Clean-up add_bool_feature · e7ffcfaf
      Behdad Esfahbod 提交于
      e7ffcfaf