- 17 9月, 2018 6 次提交
-
-
由 Behdad Esfahbod 提交于
Some clang versions define static_assert as a macro apparently, so we cannot redefine it... This reverts commit 94bfea0c. This reverts commit 4e626278.
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
"Unused private member" warning turned error. ugh.
-
由 Behdad Esfahbod 提交于
So we don't accidentally break it again.
-
由 Behdad Esfahbod 提交于
-
- 16 9月, 2018 3 次提交
-
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
...like UnsizedArrayOf<>. This fixes a class of crasher bugs, mostly with color and AAT tables. We cannot use nullable offsets to varsized data that does not declare min_size, because it's nost safe to use our fixed-size null pool for types that have their size external. So, use non_null'able offsets for these. A further enhancement would be to make use of min_size in Null<> itself. Will try that after.
-
由 Behdad Esfahbod 提交于
Does NOT apply user-selected features. But at least now enables correct subtables.
-
- 15 9月, 2018 3 次提交
-
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
An offset to unsized arrayis not safe to be redirected to our fixed-sized null pool. Plus, we want to reject, not repair, bad-looking dfonts.
-
- 14 9月, 2018 16 次提交
-
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
Not sure how I didn't add before...
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
Just to disagree with myself re being done with this code...
-
由 Behdad Esfahbod 提交于
Previously, ResourceForkHeader was defined as 30 bytes, having the typeCountM1 as last member. There was a mysterious offset-by-2 in the code, derived from FontTools and JDK code this was ported from. In testing, I observed that typeListZ offset is actually 28. Suggesting that the typeCountM1 does NOT actually belong to ResourceForkHeader, but belongs to the array itself. Adjusting for that resolves the mystery +2 offset hack, so everything is clean and good now. This, concludes my dfont hacking. The code looks great now, and I'm happy to leave it. Fuzzers might disagree though, we will see!
-
由 Behdad Esfahbod 提交于
So it doesn't accidentally match our templates, etc.
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
Offset 0 is not null in this context.
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
- 13 9月, 2018 6 次提交
-
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
I don't think I broke anything. Fuzzers will let me know..
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
- 12 9月, 2018 1 次提交
-
-
由 Behdad Esfahbod 提交于
-
- 11 9月, 2018 5 次提交
-
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
-
由 Behdad Esfahbod 提交于
I have no way to authoritatively know, but looks like test font only has one face. So, adjust test expectation instead.
-
由 Ebrahim Byagowi 提交于
-
-