1. 02 10月, 2018 9 次提交
  2. 01 10月, 2018 16 次提交
  3. 30 9月, 2018 15 次提交
    • B
      Fix bug introduced in 9b0b40b3 · 5c65ed80
      Behdad Esfahbod 提交于
      Also discovered by msan bot.
      5c65ed80
    • B
      Fix glib-mkenum warning · 247756a7
      Behdad Esfahbod 提交于
        GEN      hb-gobject-enums.h
      WARNING: Failed to parse "/*< private >*/" in ../../src/hb-buffer.h
      247756a7
    • E
      0a89f957
    • E
      ad701f05
    • E
      [circleci] Another on fixing msan · 57aabbc2
      Ebrahim Byagowi 提交于
      57aabbc2
    • E
      [circleci] minor · 24f148df
      Ebrahim Byagowi 提交于
      24f148df
    • E
      [circleci] Try to fix msan bot · 0a9aab67
      Ebrahim Byagowi 提交于
      0a9aab67
    • B
      [util] Remove unneeded virtual · b5285b34
      Behdad Esfahbod 提交于
      clang warning:
      
      ../../util/options.hh:72:13: warning: destination for this 'memset' call is a pointer to dynamic class
            'option_parser_t'; vtable pointer will be overwritten [-Wdynamic-class-memaccess]
          memset (this, 0, sizeof (*this));
          ~~~~~~  ^
      ../../util/options.hh:72:13: note: explicitly cast the pointer to silence this warning
          memset (this, 0, sizeof (*this));
                  ^
                  (void*)
      b5285b34
    • B
      [util] Fix more non-virtual-destructor warnings · 89ed040b
      Behdad Esfahbod 提交于
      89ed040b
    • B
      Minor · 2382dd07
      Behdad Esfahbod 提交于
      2382dd07
    • B
      [util] Use HB_FALLTHROUGH · 9caa432d
      Behdad Esfahbod 提交于
      Sure, gcc knows to warn about this as well:
      
      ../../util/options.cc:175:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
           case 1: m.r = m.t;
                   ~~~~^~~~~
      ../../util/options.cc:176:5: note: here
           case 2: m.b = m.t;
           ^~~~
      
      But HOLY SMOKES, look at clang -Weverything bot message:
      
      options.cc:176:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
          case 2: m.b = m.t;
          ^
      options.cc:176:5: note: insert 'HB_FALLTHROUGH;' to silence this warning
          case 2: m.b = m.t;
          ^
          HB_FALLTHROUGH;
      
      Right, it's telling me to insert "HB_FALLTHROUGH;" there!!!!!!!!!
      9caa432d
    • B
      [util] Mark var static · 2e728a7d
      Behdad Esfahbod 提交于
      From clang -Weverything bot:
      
      options.cc:39:3: warning: no previous extern declaration for non-static variable 'supported_font_funcs' [-Wmissing-variable-declarations]
      2e728a7d
    • B
      [util] Add empty virtual destructor to option_group_t · e910a1ae
      Behdad Esfahbod 提交于
      From clang -Weverything bot:
      
      ./options.hh:57:8: warning: 'option_group_t' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
      struct option_group_t
             ^
      e910a1ae
    • B
      [indic/khmer] Remove use of global constructors · b1e07e1e
      Behdad Esfahbod 提交于
      Alternative woul have been to resurrect F_COMBINE that I removed in
      70136a78
      
      But this does it for now.  I'm not sure why check-static-inits.sh didn't
      catch this before.  Clang -Weverything bot did:
      
        CXX      libharfbuzz_la-hb-ot-shape-complex-indic.lo
      hb-ot-shape-complex-indic.cc:99:1: warning: declaration requires a global constructor [-Wglobal-constructors]
      indic_features[] =
      ^
      1 warning generated.
        CXX      libharfbuzz_la-hb-ot-shape-complex-khmer.lo
      hb-ot-shape-complex-khmer.cc:36:1: warning: declaration requires a global constructor [-Wglobal-constructors]
      khmer_features[] =
      ^
      1 warning generated.
      b1e07e1e
    • B
      Tweak HB_TAG and HB_UNTAG · 00cd00e6
      Behdad Esfahbod 提交于
      uint32_t was getting promoted to signed int, which is not what we wanted...
      
      Wow, clang has become good at generating warnings...
      
      ../../src/hb-common.h:349:29: warning: signed shift result (0xFF000000) sets the sign bit of the shift expression's type ('int') and becomes negative [-Wshift-sign-overflow]
        _HB_SCRIPT_MAX_VALUE                          = HB_TAG_MAX, /*< skip >*/
                                                        ^~~~~~~~~~
      ../../src/hb-common.h:93:20: note: expanded from macro 'HB_TAG_MAX'
       define HB_TAG_MAX HB_TAG(0xff,0xff,0xff,0xff)
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
      ../../src/hb-common.h:89:57: note: expanded from macro 'HB_TAG'
       define HB_TAG(c1,c2,c3,c4) ((hb_tag_t)((((uint8_t)(c1))<<24)|(((uint8_t)(c2))<<16)|(((uint8_t)(c3))<<8)|((uint8_t)(c4))))
                                               ~~~~~~~~~~~~~~~^ ~~
      ../../src/hb-common.h:349:3: warning: ISO C restricts enumerator values to range of 'int' (4294967295 is too large) [-Wpedantic]
        _HB_SCRIPT_MAX_VALUE                          = HB_TAG_MAX, /*< skip >*/
        ^                                               ~~~~~~~~~~
      00cd00e6