提交 583d7f95 编写于 作者: B Behdad Esfahbod

Cosmetic

上级 705e2152
...@@ -100,7 +100,8 @@ typedef struct OffsetTable ...@@ -100,7 +100,8 @@ typedef struct OffsetTable
public: public:
inline bool sanitize (hb_sanitize_context_t *context) { inline bool sanitize (hb_sanitize_context_t *context) {
TRACE_SANITIZE (); TRACE_SANITIZE ();
return SANITIZE_SELF () && SANITIZE_ARRAY (tableDir, TableDirectory::get_size (), numTables); return SANITIZE_SELF ()
&& SANITIZE_ARRAY (tableDir, TableDirectory::get_size (), numTables);
} }
private: private:
......
...@@ -555,7 +555,8 @@ struct GenericArrayOf ...@@ -555,7 +555,8 @@ struct GenericArrayOf
private: private:
inline bool sanitize_shallow (hb_sanitize_context_t *context) { inline bool sanitize_shallow (hb_sanitize_context_t *context) {
TRACE_SANITIZE (); TRACE_SANITIZE ();
return SANITIZE_SELF() && SANITIZE_ARRAY (this, Type::get_size (), len); return SANITIZE_SELF()
&& SANITIZE_ARRAY (this, Type::get_size (), len);
} }
public: public:
...@@ -622,7 +623,8 @@ struct HeadlessArrayOf ...@@ -622,7 +623,8 @@ struct HeadlessArrayOf
{ return len.get_size () + (len ? len - 1 : 0) * Type::get_size (); } { return len.get_size () + (len ? len - 1 : 0) * Type::get_size (); }
inline bool sanitize_shallow (hb_sanitize_context_t *context) { inline bool sanitize_shallow (hb_sanitize_context_t *context) {
return SANITIZE_SELF() && SANITIZE_ARRAY (this, Type::get_size (), len); return SANITIZE_SELF()
&& SANITIZE_ARRAY (this, Type::get_size (), len);
} }
inline bool sanitize (hb_sanitize_context_t *context) { inline bool sanitize (hb_sanitize_context_t *context) {
......
...@@ -166,7 +166,8 @@ struct LangSys ...@@ -166,7 +166,8 @@ struct LangSys
inline bool sanitize (hb_sanitize_context_t *context) { inline bool sanitize (hb_sanitize_context_t *context) {
TRACE_SANITIZE (); TRACE_SANITIZE ();
return SANITIZE_SELF () && SANITIZE (featureIndex); return SANITIZE_SELF ()
&& SANITIZE (featureIndex);
} }
Offset lookupOrder; /* = Null (reserved for an offset to a Offset lookupOrder; /* = Null (reserved for an offset to a
...@@ -234,7 +235,8 @@ struct Feature ...@@ -234,7 +235,8 @@ struct Feature
inline bool sanitize (hb_sanitize_context_t *context) { inline bool sanitize (hb_sanitize_context_t *context) {
TRACE_SANITIZE (); TRACE_SANITIZE ();
return SANITIZE_SELF () && SANITIZE (lookupIndex); return SANITIZE_SELF ()
&& SANITIZE (lookupIndex);
} }
/* LONGTERMTODO: implement get_feature_parameters() */ /* LONGTERMTODO: implement get_feature_parameters() */
...@@ -285,7 +287,8 @@ struct Lookup ...@@ -285,7 +287,8 @@ struct Lookup
inline bool sanitize (hb_sanitize_context_t *context) { inline bool sanitize (hb_sanitize_context_t *context) {
TRACE_SANITIZE (); TRACE_SANITIZE ();
/* Real sanitize of the subtables is done by GSUB/GPOS/... */ /* Real sanitize of the subtables is done by GSUB/GPOS/... */
if (!(SANITIZE_SELF () && likely (subTable.sanitize (context)))) return false; if (!(SANITIZE_SELF ()
&& likely (subTable.sanitize (context)))) return false;
if (unlikely (lookupFlag & LookupFlag::UseMarkFilteringSet)) if (unlikely (lookupFlag & LookupFlag::UseMarkFilteringSet))
{ {
USHORT &markFilteringSet = StructAfter<USHORT> (subTable); USHORT &markFilteringSet = StructAfter<USHORT> (subTable);
...@@ -454,7 +457,8 @@ struct ClassDefFormat1 ...@@ -454,7 +457,8 @@ struct ClassDefFormat1
inline bool sanitize (hb_sanitize_context_t *context) { inline bool sanitize (hb_sanitize_context_t *context) {
TRACE_SANITIZE (); TRACE_SANITIZE ();
return SANITIZE_SELF () && SANITIZE (classValue); return SANITIZE_SELF ()
&& SANITIZE (classValue);
} }
USHORT classFormat; /* Format identifier--format = 1 */ USHORT classFormat; /* Format identifier--format = 1 */
...@@ -594,7 +598,8 @@ struct Device ...@@ -594,7 +598,8 @@ struct Device
inline bool sanitize (hb_sanitize_context_t *context) { inline bool sanitize (hb_sanitize_context_t *context) {
TRACE_SANITIZE (); TRACE_SANITIZE ();
return SANITIZE_SELF() && SANITIZE_MEM (this, this->get_size ()); return SANITIZE_SELF()
&& SANITIZE_MEM (this, this->get_size ());
} }
private: private:
......
...@@ -159,9 +159,8 @@ struct ValueFormat : USHORT ...@@ -159,9 +159,8 @@ struct ValueFormat : USHORT
inline bool sanitize_value (hb_sanitize_context_t *context, void *base, const Value *values) { inline bool sanitize_value (hb_sanitize_context_t *context, void *base, const Value *values) {
TRACE_SANITIZE (); TRACE_SANITIZE ();
return SANITIZE_MEM (values, get_size ())
return SANITIZE_MEM (values, get_size ()) && && (!has_device () || sanitize_value_devices (context, base, values));
(!has_device () || sanitize_value_devices (context, base, values));
} }
inline bool sanitize_values (hb_sanitize_context_t *context, void *base, const Value *values, unsigned int count) { inline bool sanitize_values (hb_sanitize_context_t *context, void *base, const Value *values, unsigned int count) {
......
...@@ -428,7 +428,8 @@ struct Ligature ...@@ -428,7 +428,8 @@ struct Ligature
public: public:
inline bool sanitize (hb_sanitize_context_t *context) { inline bool sanitize (hb_sanitize_context_t *context) {
TRACE_SANITIZE (); TRACE_SANITIZE ();
return SANITIZE (ligGlyph) && SANITIZE (component); return SANITIZE (ligGlyph)
&& SANITIZE (component);
} }
private: private:
......
...@@ -287,8 +287,9 @@ struct Rule ...@@ -287,8 +287,9 @@ struct Rule
public: public:
inline bool sanitize (hb_sanitize_context_t *context) { inline bool sanitize (hb_sanitize_context_t *context) {
TRACE_SANITIZE (); TRACE_SANITIZE ();
if (!(SANITIZE (inputCount) && SANITIZE (lookupCount))) return false; return SANITIZE (inputCount)
return SANITIZE_MEM (input, && SANITIZE (lookupCount)
&& SANITIZE_MEM (input,
input[0].get_size () * inputCount + input[0].get_size () * inputCount +
lookupRecordX[0].get_size () * lookupCount); lookupRecordX[0].get_size () * lookupCount);
} }
...@@ -444,10 +445,10 @@ struct ContextFormat3 ...@@ -444,10 +445,10 @@ struct ContextFormat3
TRACE_SANITIZE (); TRACE_SANITIZE ();
if (!SANITIZE_SELF ()) return false; if (!SANITIZE_SELF ()) return false;
unsigned int count = glyphCount; unsigned int count = glyphCount;
if (!SANITIZE_ARRAY (coverage, OffsetTo<Coverage>::get_size (), glyphCount)) return false; if (!SANITIZE_ARRAY (coverage, OffsetTo<Coverage>::get_size (), count)) return false;
for (unsigned int i = 0; i < count; i++) for (unsigned int i = 0; i < count; i++)
if (!SANITIZE_WITH_BASE (this, coverage[i])) return false; if (!SANITIZE_WITH_BASE (this, coverage[i])) return false;
LookupRecord *lookupRecord = &StructAtOffset<LookupRecord> (coverage, OffsetTo<Coverage>::get_size () * glyphCount); LookupRecord *lookupRecord = &StructAtOffset<LookupRecord> (coverage, OffsetTo<Coverage>::get_size () * count);
return SANITIZE_ARRAY (lookupRecord, LookupRecord::get_size (), lookupCount); return SANITIZE_ARRAY (lookupRecord, LookupRecord::get_size (), lookupCount);
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册