hb-ot-shape-complex-indic.cc 51.6 KB
Newer Older
B
Behdad Esfahbod 已提交
1
/*
B
Minor  
Behdad Esfahbod 已提交
2
 * Copyright © 2011,2012  Google, Inc.
B
Behdad Esfahbod 已提交
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26
 *
 *  This is part of HarfBuzz, a text shaping library.
 *
 * Permission is hereby granted, without written agreement and without
 * license or royalty fees, to use, copy, modify, and distribute this
 * software and its documentation for any purpose, provided that the
 * above copyright notice and the following two paragraphs appear in
 * all copies of this software.
 *
 * IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE TO ANY PARTY FOR
 * DIRECT, INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES
 * ARISING OUT OF THE USE OF THIS SOFTWARE AND ITS DOCUMENTATION, EVEN
 * IF THE COPYRIGHT HOLDER HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH
 * DAMAGE.
 *
 * THE COPYRIGHT HOLDER SPECIFICALLY DISCLAIMS ANY WARRANTIES, INCLUDING,
 * BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
 * FITNESS FOR A PARTICULAR PURPOSE.  THE SOFTWARE PROVIDED HEREUNDER IS
 * ON AN "AS IS" BASIS, AND THE COPYRIGHT HOLDER HAS NO OBLIGATION TO
 * PROVIDE MAINTENANCE, SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 *
 * Google Author(s): Behdad Esfahbod
 */

27 28
#include "hb-ot-shape-complex-indic.hh"
#include "hb-ot-layout.hh"
29

B
Behdad Esfahbod 已提交
30 31 32 33 34 35

/*
 * Indic shaper.
 */


36 37 38 39 40 41 42 43 44
/*
 * Indic configurations.  Note that we do not want to keep every single script-specific
 * behavior in these tables necessarily.  This should mainly be used for per-script
 * properties that are cheaper keeping here, than in the code.  Ie. if, say, one and
 * only one script has an exception, that one script can be if'ed directly in the code,
 * instead of adding a new flag in these structs.
 */

enum base_position_t {
45
  BASE_POS_LAST_SINHALA,
46 47 48 49 50 51 52
  BASE_POS_LAST
};
enum reph_position_t {
  REPH_POS_AFTER_MAIN  = POS_AFTER_MAIN,
  REPH_POS_BEFORE_SUB  = POS_BEFORE_SUB,
  REPH_POS_AFTER_SUB   = POS_AFTER_SUB,
  REPH_POS_BEFORE_POST = POS_BEFORE_POST,
53
  REPH_POS_AFTER_POST  = POS_AFTER_POST
54 55 56 57 58 59
};
enum reph_mode_t {
  REPH_MODE_IMPLICIT,  /* Reph formed out of initial Ra,H sequence. */
  REPH_MODE_EXPLICIT,  /* Reph formed out of initial Ra,H,ZWJ sequence. */
  REPH_MODE_LOG_REPHA  /* Encoded Repha character, needs reordering. */
};
60 61 62 63
enum blwf_mode_t {
  BLWF_MODE_PRE_AND_POST, /* Below-forms feature applied to pre-base and post-base. */
  BLWF_MODE_POST_ONLY     /* Below-forms feature applied to post-base only. */
};
64 65 66 67 68 69 70 71
struct indic_config_t
{
  hb_script_t     script;
  bool            has_old_spec;
  hb_codepoint_t  virama;
  base_position_t base_pos;
  reph_position_t reph_pos;
  reph_mode_t     reph_mode;
72
  blwf_mode_t     blwf_mode;
73 74 75 76 77
};

static const indic_config_t indic_configs[] =
{
  /* Default.  Should be first. */
78 79 80 81 82 83 84 85 86 87
  {HB_SCRIPT_INVALID,	false,      0,BASE_POS_LAST, REPH_POS_BEFORE_POST,REPH_MODE_IMPLICIT, BLWF_MODE_PRE_AND_POST},
  {HB_SCRIPT_DEVANAGARI,true, 0x094Du,BASE_POS_LAST, REPH_POS_BEFORE_POST,REPH_MODE_IMPLICIT, BLWF_MODE_PRE_AND_POST},
  {HB_SCRIPT_BENGALI,	true, 0x09CDu,BASE_POS_LAST, REPH_POS_AFTER_SUB,  REPH_MODE_IMPLICIT, BLWF_MODE_PRE_AND_POST},
  {HB_SCRIPT_GURMUKHI,	true, 0x0A4Du,BASE_POS_LAST, REPH_POS_BEFORE_SUB, REPH_MODE_IMPLICIT, BLWF_MODE_PRE_AND_POST},
  {HB_SCRIPT_GUJARATI,	true, 0x0ACDu,BASE_POS_LAST, REPH_POS_BEFORE_POST,REPH_MODE_IMPLICIT, BLWF_MODE_PRE_AND_POST},
  {HB_SCRIPT_ORIYA,	true, 0x0B4Du,BASE_POS_LAST, REPH_POS_AFTER_MAIN, REPH_MODE_IMPLICIT, BLWF_MODE_PRE_AND_POST},
  {HB_SCRIPT_TAMIL,	true, 0x0BCDu,BASE_POS_LAST, REPH_POS_AFTER_POST, REPH_MODE_IMPLICIT, BLWF_MODE_PRE_AND_POST},
  {HB_SCRIPT_TELUGU,	true, 0x0C4Du,BASE_POS_LAST, REPH_POS_AFTER_POST, REPH_MODE_EXPLICIT, BLWF_MODE_POST_ONLY},
  {HB_SCRIPT_KANNADA,	true, 0x0CCDu,BASE_POS_LAST, REPH_POS_AFTER_POST, REPH_MODE_IMPLICIT, BLWF_MODE_POST_ONLY},
  {HB_SCRIPT_MALAYALAM,	true, 0x0D4Du,BASE_POS_LAST, REPH_POS_AFTER_MAIN, REPH_MODE_LOG_REPHA,BLWF_MODE_PRE_AND_POST},
88
  {HB_SCRIPT_SINHALA,	false,0x0DCAu,BASE_POS_LAST_SINHALA,
89
						     REPH_POS_AFTER_POST, REPH_MODE_EXPLICIT, BLWF_MODE_PRE_AND_POST},
90 91 92 93 94 95 96
};



/*
 * Indic shaper.
 */
B
Behdad Esfahbod 已提交
97

B
Behdad Esfahbod 已提交
98
static const hb_ot_map_feature_t
99
indic_features[] =
B
Behdad Esfahbod 已提交
100
{
101 102 103 104
  /*
   * Basic features.
   * These features are applied in order, one at a time, after initial_reordering.
   */
105 106 107 108 109 110 111 112 113 114 115
  {HB_TAG('n','u','k','t'), F_GLOBAL_MANUAL_JOINERS},
  {HB_TAG('a','k','h','n'), F_GLOBAL_MANUAL_JOINERS},
  {HB_TAG('r','p','h','f'),        F_MANUAL_JOINERS},
  {HB_TAG('r','k','r','f'), F_GLOBAL_MANUAL_JOINERS},
  {HB_TAG('p','r','e','f'),        F_MANUAL_JOINERS},
  {HB_TAG('b','l','w','f'),        F_MANUAL_JOINERS},
  {HB_TAG('a','b','v','f'),        F_MANUAL_JOINERS},
  {HB_TAG('h','a','l','f'),        F_MANUAL_JOINERS},
  {HB_TAG('p','s','t','f'),        F_MANUAL_JOINERS},
  {HB_TAG('v','a','t','u'), F_GLOBAL_MANUAL_JOINERS},
  {HB_TAG('c','j','c','t'), F_GLOBAL_MANUAL_JOINERS},
116 117 118
  /*
   * Other features.
   * These features are applied all at once, after final_reordering.
119 120
   * Default Bengali font in Windows for example has intermixed
   * lookups for init,pres,abvs,blws features.
121
   */
122 123 124 125 126 127
  {HB_TAG('i','n','i','t'),        F_MANUAL_JOINERS},
  {HB_TAG('p','r','e','s'), F_GLOBAL_MANUAL_JOINERS},
  {HB_TAG('a','b','v','s'), F_GLOBAL_MANUAL_JOINERS},
  {HB_TAG('b','l','w','s'), F_GLOBAL_MANUAL_JOINERS},
  {HB_TAG('p','s','t','s'), F_GLOBAL_MANUAL_JOINERS},
  {HB_TAG('h','a','l','n'), F_GLOBAL_MANUAL_JOINERS},
B
Behdad Esfahbod 已提交
128 129 130 131
  /*
   * Positioning features.
   * We don't care about the types.
   */
B
Behdad Esfahbod 已提交
132 133 134
  {HB_TAG('d','i','s','t'), F_GLOBAL},
  {HB_TAG('a','b','v','m'), F_GLOBAL},
  {HB_TAG('b','l','w','m'), F_GLOBAL},
135 136
};

137 138 139
/*
 * Must be in the same order as the indic_features array.
 */
140 141
enum {
  _NUKT,
B
Behdad Esfahbod 已提交
142
  _AKHN,
143
  RPHF,
B
Minor  
Behdad Esfahbod 已提交
144
  _RKRF,
145
  PREF,
146
  BLWF,
B
Behdad Esfahbod 已提交
147
  ABVF,
148
  HALF,
149
  PSTF,
150
  _VATU,
151
  _CJCT,
152 153 154 155 156 157 158

  INIT,
  _PRES,
  _ABVS,
  _BLWS,
  _PSTS,
  _HALN,
B
Behdad Esfahbod 已提交
159

160 161 162 163 164
  _DIST,
  _ABVM,
  _BLWM,

  INDIC_NUM_FEATURES,
B
Behdad Esfahbod 已提交
165
  INDIC_BASIC_FEATURES = INIT, /* Don't forget to update this! */
B
Behdad Esfahbod 已提交
166 167
};

168 169 170 171
static void
setup_syllables (const hb_ot_shape_plan_t *plan,
		 hb_font_t *font,
		 hb_buffer_t *buffer);
B
Behdad Esfahbod 已提交
172
static void
173
initial_reordering (const hb_ot_shape_plan_t *plan,
174
		    hb_font_t *font,
B
Behdad Esfahbod 已提交
175
		    hb_buffer_t *buffer);
176
static void
177
final_reordering (const hb_ot_shape_plan_t *plan,
178
		  hb_font_t *font,
B
Behdad Esfahbod 已提交
179
		  hb_buffer_t *buffer);
180 181 182 183
static void
clear_syllables (const hb_ot_shape_plan_t *plan,
		 hb_font_t *font,
		 hb_buffer_t *buffer);
B
Behdad Esfahbod 已提交
184

185
static void
186
collect_features_indic (hb_ot_shape_planner_t *plan)
B
Behdad Esfahbod 已提交
187
{
188 189
  hb_ot_map_builder_t *map = &plan->map;

190 191 192
  /* Do this before any lookups have been applied. */
  map->add_gsub_pause (setup_syllables);

B
Behdad Esfahbod 已提交
193
  map->enable_feature (HB_TAG('l','o','c','l'));
B
Minor  
Behdad Esfahbod 已提交
194 195
  /* The Indic specs do not require ccmp, but we apply it here since if
   * there is a use of it, it's typically at the beginning. */
B
Behdad Esfahbod 已提交
196
  map->enable_feature (HB_TAG('c','c','m','p'));
197 198


199 200
  unsigned int i = 0;
  map->add_gsub_pause (initial_reordering);
B
Behdad Esfahbod 已提交
201

202
  for (; i < INDIC_BASIC_FEATURES; i++) {
B
Behdad Esfahbod 已提交
203
    map->add_feature (indic_features[i]);
B
Behdad Esfahbod 已提交
204
    map->add_gsub_pause (nullptr);
205
  }
B
Behdad Esfahbod 已提交
206

B
Behdad Esfahbod 已提交
207
  map->add_gsub_pause (final_reordering);
B
Behdad Esfahbod 已提交
208 209

  for (; i < INDIC_NUM_FEATURES; i++)
B
Behdad Esfahbod 已提交
210
    map->add_feature (indic_features[i]);
211

B
Behdad Esfahbod 已提交
212 213
  map->enable_feature (HB_TAG('c','a','l','t'));
  map->enable_feature (HB_TAG('c','l','i','g'));
214

215
  map->add_gsub_pause (clear_syllables);
B
Behdad Esfahbod 已提交
216 217
}

218
static void
219
override_features_indic (hb_ot_shape_planner_t *plan)
220
{
B
Behdad Esfahbod 已提交
221
  plan->map.disable_feature (HB_TAG('l','i','g','a'));
222 223
}

224

225
struct would_substitute_feature_t
226
{
227
  inline void init (const hb_ot_map_t *map, hb_tag_t feature_tag, bool zero_context_)
228
  {
229
    zero_context = zero_context_;
230 231 232 233 234
    map->get_stage_lookups (0/*GSUB*/,
			    map->get_feature_stage (0/*GSUB*/, feature_tag),
			    &lookups, &count);
  }

235 236 237
  inline bool would_substitute (const hb_codepoint_t *glyphs,
				unsigned int          glyphs_count,
				hb_face_t            *face) const
238 239
  {
    for (unsigned int i = 0; i < count; i++)
240
      if (hb_ot_layout_lookup_would_substitute_fast (face, lookups[i].index, glyphs, glyphs_count, zero_context))
241 242 243 244 245 246 247
	return true;
    return false;
  }

  private:
  const hb_ot_map_t::lookup_map_t *lookups;
  unsigned int count;
248
  bool zero_context;
249 250 251 252
};

struct indic_shape_plan_t
{
253
  ASSERT_POD ();
254

255
  inline bool load_virama_glyph (hb_font_t *font, hb_codepoint_t *pglyph) const
256
  {
257 258
    hb_codepoint_t glyph = virama_glyph.get_relaxed ();
    if (unlikely (glyph == (hb_codepoint_t) -1))
259
    {
260
      if (!config->virama || !font->get_nominal_glyph (config->virama, &glyph))
261 262 263 264
	glyph = 0;
      /* Technically speaking, the spec says we should apply 'locl' to virama too.
       * Maybe one day... */

265
      /* Our get_nominal_glyph() function needs a font, so we can't get the virama glyph
266 267
       * during shape planning...  Instead, overwrite it here. */
      virama_glyph.set_relaxed ((int) glyph);
268 269 270 271 272
    }

    *pglyph = glyph;
    return glyph != 0;
  }
273

274
  const indic_config_t *config;
275 276

  bool is_old_spec;
277
  bool uniscribe_bug_compatible;
278
  mutable hb_atomic_int_t virama_glyph;
279

280
  would_substitute_feature_t rphf;
281 282 283 284 285
  would_substitute_feature_t pref;
  would_substitute_feature_t blwf;
  would_substitute_feature_t pstf;

  hb_mask_t mask_array[INDIC_NUM_FEATURES];
286 287 288 289 290
};

static void *
data_create_indic (const hb_ot_shape_plan_t *plan)
{
291 292
  indic_shape_plan_t *indic_plan = (indic_shape_plan_t *) calloc (1, sizeof (indic_shape_plan_t));
  if (unlikely (!indic_plan))
B
Behdad Esfahbod 已提交
293
    return nullptr;
294

295 296 297 298 299
  indic_plan->config = &indic_configs[0];
  for (unsigned int i = 1; i < ARRAY_LENGTH (indic_configs); i++)
    if (plan->props.script == indic_configs[i].script) {
      indic_plan->config = &indic_configs[i];
      break;
300
    }
301

302
  indic_plan->is_old_spec = indic_plan->config->has_old_spec && ((plan->map.chosen_script[0] & 0x000000FFu) != '2');
303
  indic_plan->uniscribe_bug_compatible = hb_options ().uniscribe_bug_compatible;
304
  indic_plan->virama_glyph.set_relaxed (-1);
305

306
  /* Use zero-context would_substitute() matching for new-spec of the main
307 308 309 310 311 312 313 314 315
   * Indic scripts, and scripts with one spec only, but not for old-specs.
   * The new-spec for all dual-spec scripts says zero-context matching happens.
   *
   * However, testing with Malayalam shows that old and new spec both allow
   * context.  Testing with Bengali new-spec however shows that it doesn't.
   * So, the heuristic here is the way it is.  It should *only* be changed,
   * as we discover more cases of what Windows does.  DON'T TOUCH OTHERWISE.
   */
  bool zero_context = !indic_plan->is_old_spec && plan->props.script != HB_SCRIPT_MALAYALAM;
316 317 318 319
  indic_plan->rphf.init (&plan->map, HB_TAG('r','p','h','f'), zero_context);
  indic_plan->pref.init (&plan->map, HB_TAG('p','r','e','f'), zero_context);
  indic_plan->blwf.init (&plan->map, HB_TAG('b','l','w','f'), zero_context);
  indic_plan->pstf.init (&plan->map, HB_TAG('p','s','t','f'), zero_context);
320 321

  for (unsigned int i = 0; i < ARRAY_LENGTH (indic_plan->mask_array); i++)
B
Behdad Esfahbod 已提交
322 323
    indic_plan->mask_array[i] = (indic_features[i].flags & F_GLOBAL) ?
				 0 : plan->map.get_1_mask (indic_features[i].tag);
324

325
  return indic_plan;
326 327 328 329 330 331 332 333 334 335
}

static void
data_destroy_indic (void *data)
{
  free (data);
}

static indic_position_t
consonant_position_from_face (const indic_shape_plan_t *indic_plan,
336 337
			      const hb_codepoint_t consonant,
			      const hb_codepoint_t virama,
338
			      hb_face_t *face)
339
{
340 341 342 343 344 345 346 347 348 349
  /* For old-spec, the order of glyphs is Consonant,Virama,
   * whereas for new-spec, it's Virama,Consonant.  However,
   * some broken fonts (like Free Sans) simply copied lookups
   * from old-spec to new-spec without modification.
   * And oddly enough, Uniscribe seems to respect those lookups.
   * Eg. in the sequence U+0924,U+094D,U+0930, Uniscribe finds
   * base at 0.  The font however, only has lookups matching
   * 930,94D in 'blwf', not the expected 94D,930 (with new-spec
   * table).  As such, we simply match both sequences.  Seems
   * to work. */
350
  hb_codepoint_t glyphs[3] = {virama, consonant, virama};
351
  if (indic_plan->blwf.would_substitute (glyphs  , 2, face) ||
352
      indic_plan->blwf.would_substitute (glyphs+1, 2, face))
353
    return POS_BELOW_C;
354
  if (indic_plan->pstf.would_substitute (glyphs  , 2, face) ||
355
      indic_plan->pstf.would_substitute (glyphs+1, 2, face))
356
    return POS_POST_C;
357 358
  if (indic_plan->pref.would_substitute (glyphs  , 2, face) ||
      indic_plan->pref.would_substitute (glyphs+1, 2, face))
359
    return POS_POST_C;
360 361 362 363
  return POS_BASE_C;
}


364 365 366 367
enum syllable_type_t {
  consonant_syllable,
  vowel_syllable,
  standalone_cluster,
368
  symbol_cluster,
369 370 371 372 373 374 375
  broken_cluster,
  non_indic_cluster,
};

#include "hb-ot-shape-complex-indic-machine.hh"


376
static void
377 378 379
setup_masks_indic (const hb_ot_shape_plan_t *plan HB_UNUSED,
		   hb_buffer_t              *buffer,
		   hb_font_t                *font HB_UNUSED)
380 381 382 383 384 385 386 387
{
  HB_BUFFER_ALLOCATE_VAR (buffer, indic_category);
  HB_BUFFER_ALLOCATE_VAR (buffer, indic_position);

  /* We cannot setup masks here.  We save information about characters
   * and setup masks later on in a pause-callback. */

  unsigned int count = buffer->len;
B
Behdad Esfahbod 已提交
388
  hb_glyph_info_t *info = buffer->info;
389
  for (unsigned int i = 0; i < count; i++)
B
Behdad Esfahbod 已提交
390
    set_indic_properties (info[i]);
391 392
}

393 394 395 396 397 398
static void
setup_syllables (const hb_ot_shape_plan_t *plan HB_UNUSED,
		 hb_font_t *font HB_UNUSED,
		 hb_buffer_t *buffer)
{
  find_syllables (buffer);
399 400
  foreach_syllable (buffer, start, end)
    buffer->unsafe_to_break (start, end);
401 402
}

403 404 405 406 407 408 409 410 411 412 413
static int
compare_indic_order (const hb_glyph_info_t *pa, const hb_glyph_info_t *pb)
{
  int a = pa->indic_position();
  int b = pb->indic_position();

  return a < b ? -1 : a == b ? 0 : +1;
}



414
static void
415
update_consonant_positions (const hb_ot_shape_plan_t *plan,
416 417
			    hb_font_t         *font,
			    hb_buffer_t       *buffer)
418
{
419
  const indic_shape_plan_t *indic_plan = (const indic_shape_plan_t *) plan->data;
420

421 422 423
  if (indic_plan->config->base_pos != BASE_POS_LAST)
    return;

424
  hb_codepoint_t virama;
425
  if (indic_plan->load_virama_glyph (font, &virama))
426 427 428
  {
    hb_face_t *face = font->face;
    unsigned int count = buffer->len;
B
Behdad Esfahbod 已提交
429
    hb_glyph_info_t *info = buffer->info;
430
    for (unsigned int i = 0; i < count; i++)
B
Behdad Esfahbod 已提交
431 432 433 434
      if (info[i].indic_position() == POS_BASE_C)
      {
	hb_codepoint_t consonant = info[i].codepoint;
	info[i].indic_position() = consonant_position_from_face (indic_plan, consonant, virama, face);
435 436 437 438
      }
  }
}

439

B
Minor  
Behdad Esfahbod 已提交
440
/* Rules from:
441
 * https://docs.microsqoft.com/en-us/typography/script-development/devanagari */
B
Minor  
Behdad Esfahbod 已提交
442

B
Behdad Esfahbod 已提交
443
static void
444 445 446
initial_reordering_consonant_syllable (const hb_ot_shape_plan_t *plan,
				       hb_face_t *face,
				       hb_buffer_t *buffer,
447
				       unsigned int start, unsigned int end)
B
Behdad Esfahbod 已提交
448
{
449
  const indic_shape_plan_t *indic_plan = (const indic_shape_plan_t *) plan->data;
B
Minor  
Behdad Esfahbod 已提交
450
  hb_glyph_info_t *info = buffer->info;
B
Behdad Esfahbod 已提交
451

452
  /* https://github.com/harfbuzz/harfbuzz/issues/435#issuecomment-335560167
U
Unknown 已提交
453
   * // For compatibility with legacy usage in Kannada,
454 455 456 457 458 459 460 461 462 463 464 465 466
   * // Ra+h+ZWJ must behave like Ra+ZWJ+h...
   */
  if (buffer->props.script == HB_SCRIPT_KANNADA &&
      start + 3 <= end &&
      is_one_of (info[start  ], FLAG (OT_Ra)) &&
      is_one_of (info[start+1], FLAG (OT_H)) &&
      is_one_of (info[start+2], FLAG (OT_ZWJ)))
  {
    buffer->merge_clusters (start+1, start+3);
    hb_glyph_info_t tmp = info[start+1];
    info[start+1] = info[start+2];
    info[start+2] = tmp;
  }
B
Behdad Esfahbod 已提交
467

B
Behdad Esfahbod 已提交
468 469 470 471 472 473
  /* 1. Find base consonant:
   *
   * The shaping engine finds the base consonant of the syllable, using the
   * following algorithm: starting from the end of the syllable, move backwards
   * until a consonant is found that does not have a below-base or post-base
   * form (post-base forms have to follow below-base forms), or that is not a
474
   * pre-base-reordering Ra, or arrive at the first consonant. The consonant
B
Behdad Esfahbod 已提交
475 476 477 478 479 480 481
   * stopped at will be the base.
   *
   *   o If the syllable starts with Ra + Halant (in a script that has Reph)
   *     and has more than one consonant, Ra is excluded from candidates for
   *     base consonants.
   */

482
  unsigned int base = end;
B
Behdad Esfahbod 已提交
483
  bool has_reph = false;
B
Behdad Esfahbod 已提交
484

B
Behdad Esfahbod 已提交
485
  {
B
Behdad Esfahbod 已提交
486 487 488 489
    /* -> If the syllable starts with Ra + Halant (in a script that has Reph)
     *    and has more than one consonant, Ra is excluded from candidates for
     *    base consonants. */
    unsigned int limit = start;
490
    if (indic_plan->mask_array[RPHF] &&
B
Behdad Esfahbod 已提交
491
	start + 3 <= end &&
492
	(
493 494
	 (indic_plan->config->reph_mode == REPH_MODE_IMPLICIT && !is_joiner (info[start + 2])) ||
	 (indic_plan->config->reph_mode == REPH_MODE_EXPLICIT && info[start + 2].indic_category() == OT_ZWJ)
495
	))
B
Behdad Esfahbod 已提交
496
    {
497
      /* See if it matches the 'rphf' feature. */
498 499 500 501 502 503 504
      hb_codepoint_t glyphs[3] = {info[start].codepoint,
				  info[start + 1].codepoint,
				  indic_plan->config->reph_mode == REPH_MODE_EXPLICIT ?
				    info[start + 2].codepoint : 0};
      if (indic_plan->rphf.would_substitute (glyphs, 2, face) ||
	  (indic_plan->config->reph_mode == REPH_MODE_EXPLICIT &&
	   indic_plan->rphf.would_substitute (glyphs, 3, face)))
505 506 507 508 509 510 511
      {
	limit += 2;
	while (limit < end && is_joiner (info[limit]))
	  limit++;
	base = start;
	has_reph = true;
      }
512 513 514 515 516 517 518 519
    } else if (indic_plan->config->reph_mode == REPH_MODE_LOG_REPHA && info[start].indic_category() == OT_Repha)
    {
	limit += 1;
	while (limit < end && is_joiner (info[limit]))
	  limit++;
	base = start;
	has_reph = true;
    }
B
Behdad Esfahbod 已提交
520

B
Behdad Esfahbod 已提交
521
    switch (indic_plan->config->base_pos)
522
    {
523 524 525 526 527 528 529 530 531
      case BASE_POS_LAST:
      {
	/* -> starting from the end of the syllable, move backwards */
	unsigned int i = end;
	bool seen_below = false;
	do {
	  i--;
	  /* -> until a consonant is found */
	  if (is_consonant (info[i]))
532
	  {
533 534 535 536 537 538 539 540 541 542 543
	    /* -> that does not have a below-base or post-base form
	     * (post-base forms have to follow below-base forms), */
	    if (info[i].indic_position() != POS_BELOW_C &&
		(info[i].indic_position() != POS_POST_C || seen_below))
	    {
	      base = i;
	      break;
	    }
	    if (info[i].indic_position() == POS_BELOW_C)
	      seen_below = true;

544
	    /* -> or that is not a pre-base-reordering Ra,
545 546 547
	     *
	     * IMPLEMENTATION NOTES:
	     *
548
	     * Our pre-base-reordering Ra's are marked POS_POST_C, so will be skipped
549 550 551 552 553
	     * by the logic above already.
	     */

	    /* -> or arrive at the first consonant. The consonant stopped at will
	     * be the base. */
554 555
	    base = i;
	  }
556 557 558 559 560 561
	  else
	  {
	    /* A ZWJ after a Halant stops the base search, and requests an explicit
	     * half form.
	     * A ZWJ before a Halant, requests a subjoined form instead, and hence
	     * search continues.  This is particularly important for Bengali
B
Typo  
Behdad Esfahbod 已提交
562
	     * sequence Ra,H,Ya that should form Ya-Phalaa by subjoining Ya. */
563 564 565 566 567 568 569 570
	    if (start < i &&
		info[i].indic_category() == OT_ZWJ &&
		info[i - 1].indic_category() == OT_H)
	      break;
	  }
	} while (i > limit);
      }
      break;
571

572
      case BASE_POS_LAST_SINHALA:
573
      {
574
        /* Sinhala base positioning is slightly different from main Indic, in that:
B
Typo  
Behdad Esfahbod 已提交
575
	 * 1. Its ZWJ behavior is different,
576 577
	 * 2. We don't need to look into the font for consonant positions.
	 */
578

579 580
	if (!has_reph)
	  base = limit;
581

582 583 584
	/* Find the last base consonant that is not blocked by ZWJ.  If there is
	 * a ZWJ right before a base consonant, that would request a subjoined form. */
	for (unsigned int i = limit; i < end; i++)
585
	  if (is_consonant (info[i]))
586 587 588 589 590 591
	  {
	    if (limit < i && info[i - 1].indic_category() == OT_ZWJ)
	      break;
	    else
	      base = i;
	  }
592

593 594
	/* Mark all subsequent consonants as below. */
	for (unsigned int i = base + 1; i < end; i++)
595
	  if (is_consonant (info[i]))
596 597 598
	    info[i].indic_position() = POS_BELOW_C;
      }
      break;
599
    }
B
Behdad Esfahbod 已提交
600

B
Behdad Esfahbod 已提交
601 602
    /* -> If the syllable starts with Ra + Halant (in a script that has Reph)
     *    and has more than one consonant, Ra is excluded from candidates for
603 604 605
     *    base consonants.
     *
     *  Only do this for unforced Reph. (ie. not for Ra,H,ZWJ. */
606
    if (has_reph && base == start && limit - base <= 2) {
B
Behdad Esfahbod 已提交
607 608 609
      /* Have no other consonant, so Reph is not formed and Ra becomes base. */
      has_reph = false;
    }
B
Behdad Esfahbod 已提交
610
  }
611

612

B
Behdad Esfahbod 已提交
613 614
  /* 2. Decompose and reorder Matras:
   *
615 616
   * Each matra and any syllable modifier sign in the syllable are moved to the
   * appropriate position relative to the consonant(s) in the syllable. The
B
Behdad Esfahbod 已提交
617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644
   * shaping engine decomposes two- or three-part matras into their constituent
   * parts before any repositioning. Matra characters are classified by which
   * consonant in a conjunct they have affinity for and are reordered to the
   * following positions:
   *
   *   o Before first half form in the syllable
   *   o After subjoined consonants
   *   o After post-form consonant
   *   o After main consonant (for above marks)
   *
   * IMPLEMENTATION NOTES:
   *
   * The normalize() routine has already decomposed matras for us, so we don't
   * need to worry about that.
   */


  /* 3.  Reorder marks to canonical order:
   *
   * Adjacent nukta and halant or nukta and vedic sign are always repositioned
   * if necessary, so that the nukta is first.
   *
   * IMPLEMENTATION NOTES:
   *
   * We don't need to do this: the normalize() routine already did this for us.
   */


B
Behdad Esfahbod 已提交
645 646
  /* Reorder characters */

B
Minor  
Behdad Esfahbod 已提交
647
  for (unsigned int i = start; i < base; i++)
B
Minor  
Behdad Esfahbod 已提交
648
    info[i].indic_position() = MIN (POS_PRE_C, (indic_position_t) info[i].indic_position());
649

650 651
  if (base < end)
    info[base].indic_position() = POS_BASE_C;
B
Behdad Esfahbod 已提交
652

653 654
  /* Mark final consonants.  A final consonant is one appearing after a matra.
   * Happens in Sinhala. */
655 656 657
  for (unsigned int i = base + 1; i < end; i++)
    if (info[i].indic_category() == OT_M) {
      for (unsigned int j = i + 1; j < end; j++)
658 659 660 661
	if (is_consonant (info[j])) {
	 info[j].indic_position() = POS_FINAL_C;
	 break;
       }
662 663 664
      break;
    }

665
  /* Handle beginning Ra */
B
Behdad Esfahbod 已提交
666
  if (has_reph)
667
    info[start].indic_position() = POS_RA_TO_BECOME_REPH;
668

669
  /* For old-style Indic script tags, move the first post-base Halant after
670 671 672
   * last consonant.
   *
   * Reports suggest that in some scripts Uniscribe does this only if there
673 674 675
   * is *not* a Halant after last consonant already.  We know that is the
   * case for Kannada, while it reorders unconditionally in other scripts,
   * eg. Malayalam, Bengali, and Devanagari.  We don't currently know about
676
   * other scripts, so we blacklist Kannada.
677 678 679 680 681 682 683 684 685
   *
   * Kannada test case:
   * U+0C9A,U+0CCD,U+0C9A,U+0CCD
   * With some versions of Lohit Kannada.
   * https://bugs.freedesktop.org/show_bug.cgi?id=59118
   *
   * Malayalam test case:
   * U+0D38,U+0D4D,U+0D31,U+0D4D,U+0D31,U+0D4D
   * With lohit-ttf-20121122/Lohit-Malayalam.ttf
686
   *
687
   * Bengali test case:
688 689 690
   * U+0998,U+09CD,U+09AF,U+09CD
   * With Windows XP vrinda.ttf
   * https://github.com/harfbuzz/harfbuzz/issues/1073
691 692 693 694 695
   *
   * Devanagari test case:
   * U+091F,U+094D,U+0930,U+094D
   * With chandas.ttf
   * https://github.com/harfbuzz/harfbuzz/issues/1071
696 697 698
   */
  if (indic_plan->is_old_spec)
  {
699
    bool disallow_double_halants = buffer->props.script == HB_SCRIPT_KANNADA;
B
Minor  
Behdad Esfahbod 已提交
700
    for (unsigned int i = base + 1; i < end; i++)
701 702
      if (info[i].indic_category() == OT_H)
      {
703 704
        unsigned int j;
        for (j = end - 1; j > i; j--)
705 706
	  if (is_consonant (info[j]) ||
	      (disallow_double_halants && info[j].indic_category() == OT_H))
707
	    break;
708
	if (info[j].indic_category() != OT_H && j > i) {
709 710 711 712 713 714 715 716 717
	  /* Move Halant to after last consonant. */
	  hb_glyph_info_t t = info[i];
	  memmove (&info[i], &info[i + 1], (j - i) * sizeof (info[0]));
	  info[j] = t;
	}
        break;
      }
  }

718
  /* Attach misc marks to previous char to move with them. */
719
  {
720 721 722
    indic_position_t last_pos = POS_START;
    for (unsigned int i = start; i < end; i++)
    {
723
      if ((FLAG_UNSAFE (info[i].indic_category()) & (JOINER_FLAGS | FLAG (OT_N) | FLAG (OT_RS) | FLAG (OT_H))))
724 725
      {
	info[i].indic_position() = last_pos;
726
	if (unlikely (info[i].indic_category() == OT_H &&
727 728 729 730 731
		      info[i].indic_position() == POS_PRE_M))
	{
	  /*
	   * Uniscribe doesn't move the Halant with Left Matra.
	   * TEST: U+092B,U+093F,U+094DE
732 733 734 735 736
	   * We follow.  This is important for the Sinhala
	   * U+0DDA split matra since it decomposes to U+0DD9,U+0DCA
	   * where U+0DD9 is a left matra and U+0DCA is the virama.
	   * We don't want to move the virama with the left matra.
	   * TEST: U+0D9A,U+0DDA
737
	   */
738
	  for (unsigned int j = i; j > start; j--)
739
	    if (info[j - 1].indic_position() != POS_PRE_M) {
740 741 742
	      info[i].indic_position() = info[j - 1].indic_position();
	      break;
	    }
743 744 745
	}
      } else if (info[i].indic_position() != POS_SMVD) {
        last_pos = (indic_position_t) info[i].indic_position();
746
      }
747
    }
748
  }
749 750
  /* For post-base consonants let them own anything before them
   * since the last consonant or matra. */
751
  {
752
    unsigned int last = base;
753
    for (unsigned int i = base + 1; i < end; i++)
754 755 756 757
      if (is_consonant (info[i]))
      {
	for (unsigned int j = last + 1; j < i; j++)
	  if (info[j].indic_position() < POS_SMVD)
758
	    info[j].indic_position() = info[i].indic_position();
759 760 761
	last = i;
      } else if (info[i].indic_category() == OT_M)
        last = i;
762
  }
B
Behdad Esfahbod 已提交
763

764

765
  {
766 767 768 769 770
    /* Use syllable() for sort accounting temporarily. */
    unsigned int syllable = info[start].syllable();
    for (unsigned int i = start; i < end; i++)
      info[i].syllable() = i - start;

771
    /* Sit tight, rock 'n roll! */
772
    hb_stable_sort (info + start, end - start, compare_indic_order);
773 774
    /* Find base again */
    base = end;
B
Minor  
Behdad Esfahbod 已提交
775
    for (unsigned int i = start; i < end; i++)
776 777 778
      if (info[i].indic_position() == POS_BASE_C)
      {
	base = i;
779 780
	break;
      }
781 782 783 784
    /* Things are out-of-control for post base positions, they may shuffle
     * around like crazy.  In old-spec mode, we move halants around, so in
     * that case merge all clusters after base.  Otherwise, check the sort
     * order and merge as needed.
785 786 787 788 789
     * For pre-base stuff, we handle cluster issues in final reordering.
     *
     * We could use buffer->sort() for this, if there was no special
     * reordering of pre-base stuff happening later...
     */
790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814
    if (indic_plan->is_old_spec || end - base > 127)
      buffer->merge_clusters (base, end);
    else
    {
      /* Note!  syllable() is a one-byte field. */
      for (unsigned int i = base; i < end; i++)
        if (info[i].syllable() != 255)
	{
	  unsigned int max = i;
	  unsigned int j = start + info[i].syllable();
	  while (j != i)
	  {
	    max = MAX (max, j);
	    unsigned int next = start + info[j].syllable();
	    info[j].syllable() = 255; /* So we don't process j later again. */
	    j = next;
	  }
	  if (i != max)
	    buffer->merge_clusters (i, max + 1);
	}
    }

    /* Put syllable back in. */
    for (unsigned int i = start; i < end; i++)
      info[i].syllable() = syllable;
815
  }
B
Behdad Esfahbod 已提交
816

B
Behdad Esfahbod 已提交
817 818
  /* Setup masks now */

B
Behdad Esfahbod 已提交
819 820 821
  {
    hb_mask_t mask;

822
    /* Reph */
823
    for (unsigned int i = start; i < end && info[i].indic_position() == POS_RA_TO_BECOME_REPH; i++)
824
      info[i].mask |= indic_plan->mask_array[RPHF];
825

B
Behdad Esfahbod 已提交
826
    /* Pre-base */
827
    mask = indic_plan->mask_array[HALF];
828 829
    if (!indic_plan->is_old_spec &&
	indic_plan->config->blwf_mode == BLWF_MODE_PRE_AND_POST)
830
      mask |= indic_plan->mask_array[BLWF];
B
Minor  
Behdad Esfahbod 已提交
831
    for (unsigned int i = start; i < base; i++)
B
Behdad Esfahbod 已提交
832 833
      info[i].mask  |= mask;
    /* Base */
B
Behdad Esfahbod 已提交
834
    mask = 0;
835 836
    if (base < end)
      info[base].mask |= mask;
B
Behdad Esfahbod 已提交
837
    /* Post-base */
838
    mask = indic_plan->mask_array[BLWF] | indic_plan->mask_array[ABVF] | indic_plan->mask_array[PSTF];
B
Minor  
Behdad Esfahbod 已提交
839
    for (unsigned int i = base + 1; i < end; i++)
B
Behdad Esfahbod 已提交
840 841
      info[i].mask  |= mask;
  }
B
Behdad Esfahbod 已提交
842

843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874
  if (indic_plan->is_old_spec &&
      buffer->props.script == HB_SCRIPT_DEVANAGARI)
  {
    /* Old-spec eye-lash Ra needs special handling.  From the
     * spec:
     *
     * "The feature 'below-base form' is applied to consonants
     * having below-base forms and following the base consonant.
     * The exception is vattu, which may appear below half forms
     * as well as below the base glyph. The feature 'below-base
     * form' will be applied to all such occurrences of Ra as well."
     *
     * Test case: U+0924,U+094D,U+0930,U+094d,U+0915
     * with Sanskrit 2003 font.
     *
     * However, note that Ra,Halant,ZWJ is the correct way to
     * request eyelash form of Ra, so we wouldbn't inhibit it
     * in that sequence.
     *
     * Test case: U+0924,U+094D,U+0930,U+094d,U+200D,U+0915
     */
    for (unsigned int i = start; i + 1 < base; i++)
      if (info[i  ].indic_category() == OT_Ra &&
	  info[i+1].indic_category() == OT_H  &&
	  (i + 2 == base ||
	   info[i+2].indic_category() != OT_ZWJ))
      {
	info[i  ].mask |= indic_plan->mask_array[BLWF];
	info[i+1].mask |= indic_plan->mask_array[BLWF];
      }
  }

875
  unsigned int pref_len = 2;
876
  if (indic_plan->mask_array[PREF] && base + pref_len < end)
877
  {
878
    /* Find a Halant,Ra sequence and mark it for pre-base-reordering processing. */
879 880 881 882 883
    for (unsigned int i = base + 1; i + pref_len - 1 < end; i++) {
      hb_codepoint_t glyphs[2];
      for (unsigned int j = 0; j < pref_len; j++)
        glyphs[j] = info[i + j].codepoint;
      if (indic_plan->pref.would_substitute (glyphs, pref_len, face))
884
      {
885 886
	for (unsigned int j = 0; j < pref_len; j++)
	  info[i++].mask |= indic_plan->mask_array[PREF];
887 888
	break;
      }
889
    }
890 891
  }

B
Behdad Esfahbod 已提交
892
  /* Apply ZWJ/ZWNJ effects */
B
Minor  
Behdad Esfahbod 已提交
893
  for (unsigned int i = start + 1; i < end; i++)
B
Behdad Esfahbod 已提交
894 895
    if (is_joiner (info[i])) {
      bool non_joiner = info[i].indic_category() == OT_ZWNJ;
896
      unsigned int j = i;
B
Behdad Esfahbod 已提交
897 898 899

      do {
	j--;
900

901 902
	/* ZWJ/ZWNJ should disable CJCT.  They do that by simply
	 * being there, since we don't skip them for the CJCT
903
	 * feature (ie. F_MANUAL_ZWJ) */
B
Behdad Esfahbod 已提交
904 905

	/* A ZWNJ disables HALF. */
906
	if (non_joiner)
907
	  info[j].mask &= ~indic_plan->mask_array[HALF];
908

B
Behdad Esfahbod 已提交
909 910
      } while (j > start && !is_consonant (info[j]));
    }
B
Behdad Esfahbod 已提交
911 912 913
}

static void
914
initial_reordering_standalone_cluster (const hb_ot_shape_plan_t *plan,
915
				       hb_face_t *face,
B
Behdad Esfahbod 已提交
916
				       hb_buffer_t *buffer,
917
				       unsigned int start, unsigned int end)
B
Behdad Esfahbod 已提交
918
{
919 920
  const indic_shape_plan_t *indic_plan = (const indic_shape_plan_t *) plan->data;

921 922
  /* We treat placeholder/dotted-circle as if they are consonants, so we
   * should just chain.  Only if not in compatibility mode that is... */
923

924
  if (indic_plan->uniscribe_bug_compatible)
925 926 927 928 929 930 931 932
  {
    /* For dotted-circle, this is what Uniscribe does:
     * If dotted-circle is the last glyph, it just does nothing.
     * Ie. It doesn't form Reph. */
    if (buffer->info[end - 1].indic_category() == OT_DOTTEDCIRCLE)
      return;
  }

933
  initial_reordering_consonant_syllable (plan, face, buffer, start, end);
B
Behdad Esfahbod 已提交
934 935
}

936 937
static void
initial_reordering_syllable (const hb_ot_shape_plan_t *plan,
938
			     hb_face_t *face,
939 940 941 942
			     hb_buffer_t *buffer,
			     unsigned int start, unsigned int end)
{
  syllable_type_t syllable_type = (syllable_type_t) (buffer->info[start].syllable() & 0x0F);
943 944 945 946 947 948 949 950 951 952 953 954 955 956 957
  switch (syllable_type)
  {
    case vowel_syllable: /* We made the vowels look like consonants.  So let's call the consonant logic! */
    case consonant_syllable:
     initial_reordering_consonant_syllable (plan, face, buffer, start, end);
     break;

    case broken_cluster: /* We already inserted dotted-circles, so just call the standalone_cluster. */
    case standalone_cluster:
     initial_reordering_standalone_cluster (plan, face, buffer, start, end);
     break;

    case symbol_cluster:
    case non_indic_cluster:
      break;
958 959 960
  }
}

961
static inline void
B
Behdad Esfahbod 已提交
962
insert_dotted_circles (const hb_ot_shape_plan_t *plan HB_UNUSED,
963 964 965
		       hb_font_t *font,
		       hb_buffer_t *buffer)
{
B
Minor  
Behdad Esfahbod 已提交
966 967
  /* Note: This loop is extra overhead, but should not be measurable.
   * TODO Use a buffer scratch flag to remove the loop. */
968 969
  bool has_broken_syllables = false;
  unsigned int count = buffer->len;
B
Behdad Esfahbod 已提交
970
  hb_glyph_info_t *info = buffer->info;
971
  for (unsigned int i = 0; i < count; i++)
B
Behdad Esfahbod 已提交
972 973
    if ((info[i].syllable() & 0x0F) == broken_cluster)
    {
974 975 976 977 978 979 980
      has_broken_syllables = true;
      break;
    }
  if (likely (!has_broken_syllables))
    return;


981
  hb_codepoint_t dottedcircle_glyph;
982
  if (!font->get_nominal_glyph (0x25CCu, &dottedcircle_glyph))
983 984
    return;

985
  hb_glyph_info_t dottedcircle = {0};
986
  dottedcircle.codepoint = 0x25CCu;
987 988 989 990 991 992 993
  set_indic_properties (dottedcircle);
  dottedcircle.codepoint = dottedcircle_glyph;

  buffer->clear_output ();

  buffer->idx = 0;
  unsigned int last_syllable = 0;
B
Behdad Esfahbod 已提交
994
  while (buffer->idx < buffer->len && buffer->successful)
995 996 997 998 999
  {
    unsigned int syllable = buffer->cur().syllable();
    syllable_type_t syllable_type = (syllable_type_t) (syllable & 0x0F);
    if (unlikely (last_syllable != syllable && syllable_type == broken_cluster))
    {
1000 1001
      last_syllable = syllable;

1002 1003 1004 1005
      hb_glyph_info_t ginfo = dottedcircle;
      ginfo.cluster = buffer->cur().cluster;
      ginfo.mask = buffer->cur().mask;
      ginfo.syllable() = buffer->cur().syllable();
B
Minor  
Behdad Esfahbod 已提交
1006
      /* TODO Set glyph_props? */
1007 1008

      /* Insert dottedcircle after possible Repha. */
B
Behdad Esfahbod 已提交
1009
      while (buffer->idx < buffer->len && buffer->successful &&
1010 1011 1012 1013
	     last_syllable == buffer->cur().syllable() &&
	     buffer->cur().indic_category() == OT_Repha)
        buffer->next_glyph ();

1014
      buffer->output_info (ginfo);
1015
    }
1016 1017
    else
      buffer->next_glyph ();
1018 1019 1020 1021 1022
  }

  buffer->swap_buffers ();
}

B
Behdad Esfahbod 已提交
1023
static void
1024
initial_reordering (const hb_ot_shape_plan_t *plan,
1025
		    hb_font_t *font,
B
Behdad Esfahbod 已提交
1026
		    hb_buffer_t *buffer)
B
Behdad Esfahbod 已提交
1027
{
1028
  update_consonant_positions (plan, font, buffer);
1029
  insert_dotted_circles (plan, font, buffer);
1030

1031 1032
  foreach_syllable (buffer, start, end)
    initial_reordering_syllable (plan, font->face, buffer, start, end);
B
Behdad Esfahbod 已提交
1033 1034
}

B
Behdad Esfahbod 已提交
1035
static void
1036 1037
final_reordering_syllable (const hb_ot_shape_plan_t *plan,
			   hb_buffer_t *buffer,
1038
			   unsigned int start, unsigned int end)
B
Behdad Esfahbod 已提交
1039
{
1040
  const indic_shape_plan_t *indic_plan = (const indic_shape_plan_t *) plan->data;
1041 1042
  hb_glyph_info_t *info = buffer->info;

1043 1044

  /* This function relies heavily on halant glyphs.  Lots of ligation
1045
   * and possibly multiple substitutions happened prior to this
1046 1047 1048
   * phase, and that might have messed up our properties.  Recover
   * from a particular case of that where we're fairly sure that a
   * class of OT_H is desired but has been lost. */
1049 1050 1051 1052
  /* We don't call load_virama_glyph(), since we know it's already
   * loaded. */
  hb_codepoint_t virama_glyph = indic_plan->virama_glyph.get_relaxed ();
  if (virama_glyph)
1053 1054 1055 1056 1057 1058
  {
    for (unsigned int i = start; i < end; i++)
      if (info[i].codepoint == virama_glyph &&
	  _hb_glyph_info_ligated (&info[i]) &&
	  _hb_glyph_info_multiplied (&info[i]))
      {
1059
        /* This will make sure that this glyph passes is_halant() test. */
1060 1061 1062 1063 1064 1065
	info[i].indic_category() = OT_H;
	_hb_glyph_info_clear_ligated_and_multiplied (&info[i]);
      }
  }


1066 1067 1068 1069 1070
  /* 4. Final reordering:
   *
   * After the localized forms and basic shaping forms GSUB features have been
   * applied (see below), the shaping engine performs some final glyph
   * reordering before applying all the remaining font features to the entire
1071
   * syllable.
1072 1073
   */

1074 1075
  bool try_pref = !!indic_plan->mask_array[PREF];

1076
  /* Find base again */
1077 1078
  unsigned int base;
  for (base = start; base < end; base++)
1079 1080
    if (info[base].indic_position() >= POS_BASE_C)
    {
1081
      if (try_pref && base + 1 < end)
1082 1083 1084 1085 1086 1087 1088 1089 1090 1091
      {
	for (unsigned int i = base + 1; i < end; i++)
	  if ((info[i].mask & indic_plan->mask_array[PREF]) != 0)
	  {
	    if (!(_hb_glyph_info_substituted (&info[i]) &&
		  _hb_glyph_info_ligated_and_didnt_multiply (&info[i])))
	    {
	      /* Ok, this was a 'pref' candidate but didn't form any.
	       * Base is around here... */
	      base = i;
1092
	      while (base < end && is_halant (info[base]))
1093 1094 1095 1096 1097 1098 1099 1100
		base++;
	      info[base].indic_position() = POS_BASE_C;

	      try_pref = false;
	    }
	    break;
	  }
      }
1101 1102 1103 1104 1105 1106 1107
      /* For Malayalam, skip over unformed below- (but NOT post-) forms. */
      if (buffer->props.script == HB_SCRIPT_MALAYALAM)
      {
	for (unsigned int i = base + 1; i < end; i++)
	{
	  while (i < end && is_joiner (info[i]))
	    i++;
1108
	  if (i == end || !is_halant (info[i]))
1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119
	    break;
	  i++; /* Skip halant. */
	  while (i < end && is_joiner (info[i]))
	    i++;
	  if (i < end && is_consonant (info[i]) && info[i].indic_position() == POS_BELOW_C)
	  {
	    base = i;
	    info[base].indic_position() = POS_BASE_C;
	  }
	}
      }
1120

1121 1122 1123 1124
      if (start < base && info[base].indic_position() > POS_BASE_C)
        base--;
      break;
    }
1125
  if (base == end && start < base &&
1126
      is_one_of (info[base - 1], FLAG (OT_ZWJ)))
1127
    base--;
1128 1129
  if (base < end)
    while (start < base &&
1130
	   is_one_of (info[base], (FLAG (OT_N) | FLAG (OT_H))))
1131
      base--;
1132

B
Minor  
Behdad Esfahbod 已提交
1133

1134
  /*   o Reorder matras:
1135 1136 1137 1138 1139 1140 1141
   *
   *     If a pre-base matra character had been reordered before applying basic
   *     features, the glyph can be moved closer to the main consonant based on
   *     whether half-forms had been formed. Actual position for the matra is
   *     defined as “after last standalone halant glyph, after initial matra
   *     position and before the main consonant”. If ZWJ or ZWNJ follow this
   *     halant, position is moved after it.
1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159
   *
   * IMPLEMENTATION NOTES:
   *
   * It looks like the last sentence is wrong.  Testing, with Windows 7 Uniscribe
   * and Devanagari shows that the behavior is best described as:
   *
   * "If ZWJ follows this halant, matra is NOT repositioned after this halant.
   *  If ZWNJ follows this halant, position is moved after it."
   *
   * Test case, with Adobe Devanagari or Nirmala UI:
   *
   *   U+091F,U+094D,U+200C,U+092F,U+093F
   *   (Matra moves to the middle, after ZWNJ.)
   *
   *   U+091F,U+094D,U+200D,U+092F,U+093F
   *   (Matra does NOT move, stays to the left.)
   *
   * https://github.com/harfbuzz/harfbuzz/issues/1070
1160 1161
   */

1162
  if (start + 1 < end && start < base) /* Otherwise there can't be any pre-base matra characters. */
1163
  {
1164 1165 1166
    /* If we lost track of base, alas, position before last thingy. */
    unsigned int new_pos = base == end ? base - 2 : base - 1;

1167 1168 1169
    /* Malayalam / Tamil do not have "half" forms or explicit virama forms.
     * The glyphs formed by 'half' are Chillus or ligated explicit viramas.
     * We want to position matra after them.
1170
     */
1171
    if (buffer->props.script != HB_SCRIPT_MALAYALAM && buffer->props.script != HB_SCRIPT_TAMIL)
1172
    {
1173
    search:
1174
      while (new_pos > start &&
1175
	     !(is_one_of (info[new_pos], (FLAG (OT_M) | FLAG (OT_H)))))
1176 1177 1178 1179 1180
	new_pos--;

      /* If we found no Halant we are done.
       * Otherwise only proceed if the Halant does
       * not belong to the Matra itself! */
1181
      if (is_halant (info[new_pos]) &&
1182 1183
	  info[new_pos].indic_position() != POS_PRE_M)
      {
1184
#if 0 // See comment above
1185 1186 1187
	/* -> If ZWJ or ZWNJ follow this halant, position is moved after it. */
	if (new_pos + 1 < end && is_joiner (info[new_pos + 1]))
	  new_pos++;
1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204
#endif
	if (new_pos + 1 < end)
	{
	  /* -> If ZWJ follows this halant, matra is NOT repositioned after this halant. */
	  if (info[new_pos + 1].indic_category() == OT_ZWJ)
	  {
	    /* Keep searching. */
	    if (new_pos > start)
	    {
	      new_pos--;
	      goto search;
	    }
	  }
	  /* -> If ZWNJ follows this halant, position is moved after it. */
	  if (info[new_pos + 1].indic_category() == OT_ZWNJ)
	    new_pos++;
	}
1205 1206 1207 1208
      }
      else
        new_pos = start; /* No move. */
    }
1209

1210
    if (start < new_pos && info[new_pos].indic_position () != POS_PRE_M)
1211
    {
1212
      /* Now go see if there's actually any matras... */
B
Behdad Esfahbod 已提交
1213
      for (unsigned int i = new_pos; i > start; i--)
1214
	if (info[i - 1].indic_position () == POS_PRE_M)
1215
	{
B
Behdad Esfahbod 已提交
1216
	  unsigned int old_pos = i - 1;
1217 1218 1219
	  if (old_pos < base && base <= new_pos) /* Shouldn't actually happen. */
	    base--;

B
Behdad Esfahbod 已提交
1220 1221 1222
	  hb_glyph_info_t tmp = info[old_pos];
	  memmove (&info[old_pos], &info[old_pos + 1], (new_pos - old_pos) * sizeof (info[0]));
	  info[new_pos] = tmp;
1223 1224 1225

	  /* Note: this merge_clusters() is intentionally *after* the reordering.
	   * Indic matra reordering is special and tricky... */
1226
	  buffer->merge_clusters (new_pos, MIN (end, base + 1));
1227

B
Behdad Esfahbod 已提交
1228
	  new_pos--;
1229
	}
1230
    } else {
1231
      for (unsigned int i = start; i < base; i++)
1232
	if (info[i].indic_position () == POS_PRE_M) {
1233
	  buffer->merge_clusters (i, MIN (end, base + 1));
1234 1235
	  break;
	}
1236
    }
1237 1238 1239 1240
  }


  /*   o Reorder reph:
1241 1242 1243 1244 1245 1246
   *
   *     Reph’s original position is always at the beginning of the syllable,
   *     (i.e. it is not reordered at the character reordering stage). However,
   *     it will be reordered according to the basic-forms shaping results.
   *     Possible positions for reph, depending on the script, are; after main,
   *     before post-base consonant forms, and after post-base consonant forms.
1247 1248
   */

1249 1250 1251 1252 1253 1254 1255 1256 1257
  /* Two cases:
   *
   * - If repha is encoded as a sequence of characters (Ra,H or Ra,H,ZWJ), then
   *   we should only move it if the sequence ligated to the repha form.
   *
   * - If repha is encoded separately and in the logical position, we should only
   *   move it if it did NOT ligate.  If it ligated, it's probably the font trying
   *   to make it work without the reordering.
   */
B
Behdad Esfahbod 已提交
1258 1259
  if (start + 1 < end &&
      info[start].indic_position() == POS_RA_TO_BECOME_REPH &&
B
Behdad Esfahbod 已提交
1260
      ((info[start].indic_category() == OT_Repha) ^
1261
       _hb_glyph_info_ligated_and_didnt_multiply (&info[start])))
1262
  {
1263 1264 1265
    unsigned int new_reph_pos;
    reph_position_t reph_pos = indic_plan->config->reph_pos;

1266 1267
    /*       1. If reph should be positioned after post-base consonant forms,
     *          proceed to step 5.
1268
     */
1269
    if (reph_pos == REPH_POS_AFTER_POST)
1270
    {
1271
      goto reph_step_5;
1272 1273 1274
    }

    /*       2. If the reph repositioning class is not after post-base: target
1275 1276 1277 1278 1279 1280 1281 1282 1283
     *          position is after the first explicit halant glyph between the
     *          first post-reph consonant and last main consonant. If ZWJ or ZWNJ
     *          are following this halant, position is moved after it. If such
     *          position is found, this is the target position. Otherwise,
     *          proceed to the next step.
     *
     *          Note: in old-implementation fonts, where classifications were
     *          fixed in shaping engine, there was no case where reph position
     *          will be found on this step.
1284 1285 1286
     */
    {
      new_reph_pos = start + 1;
1287
      while (new_reph_pos < base && !is_halant (info[new_reph_pos]))
1288 1289
	new_reph_pos++;

1290
      if (new_reph_pos < base && is_halant (info[new_reph_pos]))
B
Indent  
Behdad Esfahbod 已提交
1291
      {
1292 1293 1294 1295 1296 1297 1298 1299
	/* ->If ZWJ or ZWNJ are following this halant, position is moved after it. */
	if (new_reph_pos + 1 < base && is_joiner (info[new_reph_pos + 1]))
	  new_reph_pos++;
	goto reph_move;
      }
    }

    /*       3. If reph should be repositioned after the main consonant: find the
1300
     *          first consonant not ligated with main, or find the first
1301
     *          consonant that is not a potential pre-base-reordering Ra.
1302
     */
1303
    if (reph_pos == REPH_POS_AFTER_MAIN)
1304
    {
1305
      new_reph_pos = base;
1306
      while (new_reph_pos + 1 < end && info[new_reph_pos + 1].indic_position() <= POS_AFTER_MAIN)
1307 1308 1309
	new_reph_pos++;
      if (new_reph_pos < end)
        goto reph_move;
1310 1311 1312
    }

    /*       4. If reph should be positioned before post-base consonant, find
1313 1314 1315
     *          first post-base classified consonant not ligated with main. If no
     *          consonant is found, the target position should be before the
     *          first matra, syllable modifier sign or vedic sign.
1316
     */
1317
    /* This is our take on what step 4 is trying to say (and failing, BADLY). */
1318
    if (reph_pos == REPH_POS_AFTER_SUB)
1319
    {
1320
      new_reph_pos = base;
1321
      while (new_reph_pos + 1 < end &&
B
Behdad Esfahbod 已提交
1322
	     !( FLAG_UNSAFE (info[new_reph_pos + 1].indic_position()) & (FLAG (POS_POST_C) | FLAG (POS_AFTER_POST) | FLAG (POS_SMVD))))
1323 1324 1325
	new_reph_pos++;
      if (new_reph_pos < end)
        goto reph_move;
1326 1327 1328
    }

    /*       5. If no consonant is found in steps 3 or 4, move reph to a position
1329 1330 1331 1332 1333 1334
     *          immediately before the first post-base matra, syllable modifier
     *          sign or vedic sign that has a reordering class after the intended
     *          reph position. For example, if the reordering position for reph
     *          is post-main, it will skip above-base matras that also have a
     *          post-main position.
     */
1335 1336
    reph_step_5:
    {
1337 1338
      /* Copied from step 2. */
      new_reph_pos = start + 1;
1339
      while (new_reph_pos < base && !is_halant (info[new_reph_pos]))
1340 1341
	new_reph_pos++;

1342
      if (new_reph_pos < base && is_halant (info[new_reph_pos]))
B
Indent  
Behdad Esfahbod 已提交
1343
      {
1344 1345 1346 1347 1348
	/* ->If ZWJ or ZWNJ are following this halant, position is moved after it. */
	if (new_reph_pos + 1 < base && is_joiner (info[new_reph_pos + 1]))
	  new_reph_pos++;
	goto reph_move;
      }
1349
    }
1350

1351 1352 1353 1354 1355 1356 1357
    /*       6. Otherwise, reorder reph to the end of the syllable.
     */
    {
      new_reph_pos = end - 1;
      while (new_reph_pos > start && info[new_reph_pos].indic_position() == POS_SMVD)
	new_reph_pos--;

1358 1359 1360 1361 1362 1363 1364
      /*
       * If the Reph is to be ending up after a Matra,Halant sequence,
       * position it before that Halant so it can interact with the Matra.
       * However, if it's a plain Consonant,Halant we shouldn't do that.
       * Uniscribe doesn't do this.
       * TEST: U+0930,U+094D,U+0915,U+094B,U+094D
       */
1365
      if (!indic_plan->uniscribe_bug_compatible &&
1366
	  unlikely (is_halant (info[new_reph_pos]))) {
1367 1368 1369 1370 1371 1372 1373
	for (unsigned int i = base + 1; i < new_reph_pos; i++)
	  if (info[i].indic_category() == OT_M) {
	    /* Ok, got it. */
	    new_reph_pos--;
	  }
      }
      goto reph_move;
1374 1375
    }

1376 1377 1378
    reph_move:
    {
      /* Move */
1379
      buffer->merge_clusters (start, new_reph_pos + 1);
1380 1381 1382
      hb_glyph_info_t reph = info[start];
      memmove (&info[start], &info[start + 1], (new_reph_pos - start) * sizeof (info[0]));
      info[new_reph_pos] = reph;
1383

1384 1385
      if (start < base && base <= new_reph_pos)
	base--;
1386
    }
1387 1388 1389
  }


1390
  /*   o Reorder pre-base-reordering consonants:
1391
   *
1392
   *     If a pre-base-reordering consonant is found, reorder it according to
1393 1394 1395
   *     the following rules:
   */

1396
  if (try_pref && base + 1 < end) /* Otherwise there can't be any pre-base-reordering Ra. */
1397
  {
1398
    for (unsigned int i = base + 1; i < end; i++)
1399
      if ((info[i].mask & indic_plan->mask_array[PREF]) != 0)
1400
      {
1401 1402 1403 1404
	/*       1. Only reorder a glyph produced by substitution during application
	 *          of the <pref> feature. (Note that a font may shape a Ra consonant with
	 *          the feature generally but block it in certain contexts.)
	 */
1405
        /* Note: We just check that something got substituted.  We don't check that
1406 1407
	 * the <pref> feature actually did it...
	 *
1408 1409
	 * Reorder pref only if it ligated. */
	if (_hb_glyph_info_ligated_and_didnt_multiply (&info[i]))
1410 1411 1412 1413 1414 1415 1416 1417 1418 1419
	{
	  /*
	   *       2. Try to find a target position the same way as for pre-base matra.
	   *          If it is found, reorder pre-base consonant glyph.
	   *
	   *       3. If position is not found, reorder immediately before main
	   *          consonant.
	   */

	  unsigned int new_pos = base;
1420 1421 1422 1423 1424
	  /* Malayalam / Tamil do not have "half" forms or explicit virama forms.
	   * The glyphs formed by 'half' are Chillus or ligated explicit viramas.
	   * We want to position matra after them.
	   */
	  if (buffer->props.script != HB_SCRIPT_MALAYALAM && buffer->props.script != HB_SCRIPT_TAMIL)
1425
	  {
1426
	    while (new_pos > start &&
1427
		   !(is_one_of (info[new_pos - 1], FLAG(OT_M) | FLAG (OT_H))))
1428
	      new_pos--;
1429 1430
	  }

1431
	  if (new_pos > start && is_halant (info[new_pos - 1]))
B
Indent  
Behdad Esfahbod 已提交
1432
	  {
1433 1434 1435
	    /* -> If ZWJ or ZWNJ follow this halant, position is moved after it. */
	    if (new_pos < end && is_joiner (info[new_pos]))
	      new_pos++;
B
Indent  
Behdad Esfahbod 已提交
1436
	  }
1437 1438 1439

	  {
	    unsigned int old_pos = i;
1440

1441
	    buffer->merge_clusters (new_pos, old_pos + 1);
1442 1443 1444
	    hb_glyph_info_t tmp = info[old_pos];
	    memmove (&info[new_pos + 1], &info[new_pos], (old_pos - new_pos) * sizeof (info[0]));
	    info[new_pos] = tmp;
1445

1446 1447
	    if (new_pos <= base && base < old_pos)
	      base++;
1448 1449 1450 1451
	  }
	}

        break;
1452
      }
1453
  }
1454 1455


1456
  /* Apply 'init' to the Left Matra if it's a word start. */
1457 1458 1459 1460 1461 1462 1463 1464 1465
  if (info[start].indic_position () == POS_PRE_M)
  {
    if (!start ||
	!(FLAG_UNSAFE (_hb_glyph_info_get_general_category (&info[start - 1])) &
	 FLAG_RANGE (HB_UNICODE_GENERAL_CATEGORY_FORMAT, HB_UNICODE_GENERAL_CATEGORY_NON_SPACING_MARK)))
      info[start].mask |= indic_plan->mask_array[INIT];
    else
      buffer->unsafe_to_break (start - 1, start + 1);
  }
1466

1467

B
Behdad Esfahbod 已提交
1468 1469 1470
  /*
   * Finish off the clusters and go home!
   */
1471
  if (indic_plan->uniscribe_bug_compatible)
1472
  {
1473 1474 1475 1476 1477 1478 1479
    switch ((hb_tag_t) plan->props.script)
    {
      case HB_SCRIPT_TAMIL:
      case HB_SCRIPT_SINHALA:
        break;

      default:
1480 1481
	/* Uniscribe merges the entire syllable into a single cluster... Except for Tamil & Sinhala.
	 * This means, half forms are submerged into the main consonant's cluster.
1482 1483 1484 1485 1486
	 * This is unnecessary, and makes cursor positioning harder, but that's what
	 * Uniscribe does. */
	buffer->merge_clusters (start, end);
	break;
    }
1487
  }
1488
}
1489 1490


1491
static void
1492
final_reordering (const hb_ot_shape_plan_t *plan,
B
Behdad Esfahbod 已提交
1493
		  hb_font_t *font HB_UNUSED,
B
Behdad Esfahbod 已提交
1494
		  hb_buffer_t *buffer)
1495 1496
{
  unsigned int count = buffer->len;
1497
  if (unlikely (!count)) return;
1498

1499 1500
  foreach_syllable (buffer, start, end)
    final_reordering_syllable (plan, buffer, start, end);
1501

B
Behdad Esfahbod 已提交
1502 1503 1504 1505 1506
  HB_BUFFER_DEALLOCATE_VAR (buffer, indic_category);
  HB_BUFFER_DEALLOCATE_VAR (buffer, indic_position);
}


1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518
static void
clear_syllables (const hb_ot_shape_plan_t *plan HB_UNUSED,
		 hb_font_t *font HB_UNUSED,
		 hb_buffer_t *buffer)
{
  hb_glyph_info_t *info = buffer->info;
  unsigned int count = buffer->len;
  for (unsigned int i = 0; i < count; i++)
    info[i].syllable() = 0;
}


1519 1520
static bool
decompose_indic (const hb_ot_shape_normalize_context_t *c,
1521 1522 1523 1524 1525 1526 1527
		 hb_codepoint_t  ab,
		 hb_codepoint_t *a,
		 hb_codepoint_t *b)
{
  switch (ab)
  {
    /* Don't decompose these. */
B
Behdad Esfahbod 已提交
1528
    case 0x0931u  : return false; /* DEVANAGARI LETTER RRA */
1529 1530 1531
    // https://github.com/harfbuzz/harfbuzz/issues/779
    case 0x09DCu  : return false; /* BENGALI LETTER RRA */
    case 0x09DDu  : return false; /* BENGALI LETTER RHA */
B
Behdad Esfahbod 已提交
1532
    case 0x0B94u  : return false; /* TAMIL LETTER AU */
1533 1534 1535 1536 1537 1538 1539


    /*
     * Decompose split matras that don't have Unicode decompositions.
     */

#if 0
B
Behdad Esfahbod 已提交
1540
    /* Gujarati */
1541
    /* This one has no decomposition in Unicode, but needs no decomposition either. */
1542
    /* case 0x0AC9u  : return false; */
B
Behdad Esfahbod 已提交
1543 1544

    /* Oriya */
1545
    case 0x0B57u  : *a = no decomp, -> RIGHT; return true;
1546 1547 1548
#endif
  }

1549
  if ((ab == 0x0DDAu || hb_in_range<hb_codepoint_t> (ab, 0x0DDCu, 0x0DDEu)))
1550
  {
1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569
    /*
     * Sinhala split matras...  Let the fun begin.
     *
     * These four characters have Unicode decompositions.  However, Uniscribe
     * decomposes them "Khmer-style", that is, it uses the character itself to
     * get the second half.  The first half of all four decompositions is always
     * U+0DD9.
     *
     * Now, there are buggy fonts, namely, the widely used lklug.ttf, that are
     * broken with Uniscribe.  But we need to support them.  As such, we only
     * do the Uniscribe-style decomposition if the character is transformed into
     * its "sec.half" form by the 'pstf' feature.  Otherwise, we fall back to
     * Unicode decomposition.
     *
     * Note that we can't unconditionally use Unicode decomposition.  That would
     * break some other fonts, that are designed to work with Uniscribe, and
     * don't have positioning features for the Unicode-style decomposition.
     *
     * Argh...
1570 1571 1572 1573
     *
     * The Uniscribe behavior is now documented in the newly published Sinhala
     * spec in 2012:
     *
1574
     *   https://docs.microsoft.com/en-us/typography/script-development/sinhala#shaping
1575 1576 1577 1578 1579 1580
     */

    const indic_shape_plan_t *indic_plan = (const indic_shape_plan_t *) c->plan->data;

    hb_codepoint_t glyph;

1581
    if (hb_options ().uniscribe_bug_compatible ||
1582
	(c->font->get_nominal_glyph (ab, &glyph) &&
1583
	 indic_plan->pstf.would_substitute (&glyph, 1, c->font->face)))
1584 1585
    {
      /* Ok, safe to use Uniscribe-style decomposition. */
1586
      *a = 0x0DD9u;
1587 1588 1589
      *b = ab;
      return true;
    }
1590 1591
  }

1592
  return (bool) c->unicode->decompose (ab, a, b);
1593 1594
}

1595 1596
static bool
compose_indic (const hb_ot_shape_normalize_context_t *c,
1597 1598 1599 1600 1601
	       hb_codepoint_t  a,
	       hb_codepoint_t  b,
	       hb_codepoint_t *ab)
{
  /* Avoid recomposing split matras. */
1602
  if (HB_UNICODE_GENERAL_CATEGORY_IS_MARK (c->unicode->general_category (a)))
1603 1604 1605
    return false;

  /* Composition-exclusion exceptions that we want to recompose. */
1606
  if (a == 0x09AFu && b == 0x09BCu) { *ab = 0x09DFu; return true; }
1607

1608
  return (bool) c->unicode->compose (a, b, ab);
1609 1610 1611
}


1612 1613 1614 1615
const hb_ot_complex_shaper_t _hb_ot_complex_shaper_indic =
{
  collect_features_indic,
  override_features_indic,
1616 1617
  data_create_indic,
  data_destroy_indic,
B
Behdad Esfahbod 已提交
1618 1619
  nullptr, /* preprocess_text */
  nullptr, /* postprocess_glyphs */
1620
  HB_OT_SHAPE_NORMALIZATION_MODE_COMPOSED_DIACRITICS_NO_SHORT_CIRCUIT,
1621 1622
  decompose_indic,
  compose_indic,
1623
  setup_masks_indic,
B
Minor  
Behdad Esfahbod 已提交
1624
  HB_TAG_NONE, /* gpos_tag */
B
Behdad Esfahbod 已提交
1625
  nullptr, /* reorder_marks */
1626
  HB_OT_SHAPE_ZERO_WIDTH_MARKS_NONE,
1627
  false, /* fallback_position */
1628
};