The current code to set up the GART as an IOMMU enables GART
translations before it removes the aperture from the kernel memory
map, sets the GART PTEs to UC, sets up the guard and scratch
pages, or does a wbinvd().  This leaves the possibility of cache
aliasing open and can cause system crashes.

Re-order the code so as to enable the GART translations only
after all safeguards are in place and the tlb has been flushed.

AMD has tested this patch on both Istanbul systems and 1st
generation Opteron systems with APG enabled and seen no adverse
effects.  Istanbul systems with HT Assist enabled sometimes
see MCE errors due to cache artifacts with the unmodified
code.
Signed-off-by: NMark Langsdorf <mark.langsdorf@amd.com>
Cc: <stable@kernel.org>
Cc: Joerg Roedel <joerg.roedel@amd.com>
Cc: akpm@linux-foundation.org
Cc: jbarnes@virtuousgeek.org
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Merge branches 'amd-iommu/fixes', 'amd-iommu/debug', 'amd-iommu/suspend-resume' and 'amd-iommu/extended-allocator' into amd-iommu/2.6.31

Conflicts:
	arch/x86/kernel/amd_iommu.c
	arch/x86/kernel/amd_iommu_init.c

This will test the automatic aperture enlargement code. This is
important because only very few devices will ever trigger this code
path. So force it under CONFIG_IOMMU_STRESS.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This forces testing of on-demand page table allocation code.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

Disabling the round-robin allocator results in reusing the same
dma-addresses again very fast. This is a good test if the iotlb flushing
is working correctly.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This parameter is not longer necessary when aperture increases
dynamically.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

By dynamically increasing the aperture the extended allocator is now
ready for use.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This patch makes sure no reserved addresses are allocated in an dma_ops
domain when the aperture is increased dynamically.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This patch prepares the dynamic increasement of dma_ops domain
apertures.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

Simplify the code a little bit by using the same unit for all address
space related state in the dma_ops domain structure.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This patch changes the AMD IOMMU address allocator to allow up to 32
aperture ranges per dma_ops domain.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

The code will be required when the aperture size increases dynamically
in the extended address allocator.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This patch makes page table allocation usable for dma_ops code.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This is a preperation for extended address allocator.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This patch puts everything together and enables suspend/resume support
in the AMD IOMMU driver.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This patch makes sure that no function required for suspend/resume of
AMD IOMMU driver is thrown away after boot.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This function is required for suspend/resume support with AMD IOMMU
enabled.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This function is required for suspend/resume support with AMD IOMMU
enabled.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This function is required for suspend/resume support with AMD IOMMU
enabled.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

Current hardware uses msi instead of msi-x so this code it not necessary
and can not be tested. The best thing is to drop this code.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

It is not necessary to loop again over all IOMMUs in this code. So drop
the loop.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This patch restructures the AMD IOMMU initialization code to initialize
all hardware registers with one single function call.
This is helpful for suspend/resume support.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This patch introduces the for_each_iommu and for_each_iommu_safe macros
to simplify the developers life when having to iterate over all AMD
IOMMUs in the system.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

Some drivers may use the dma api during ->remove which will
cause a protection domain to get reattached to a device.  Delay the
detach until after the driver is completely unbound.

[ joro: added a little merge helper ]

[ Impact: fix too early device<->domain removal ]
Signed-off-by: NChris Wright <chrisw@redhat.com>
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

The bug never triggered. But it should be fixed to protect against
broken ACPI tables in the future.

[ Impact: protect against broken ivrs acpi table ]
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

The devid parameter to set_dev_entry_from_acpi is the requester ID
rather than the device ID since it is used to index the IOMMU device
table.  The handling of IVHD_DEV_ALIAS used to pass the device ID.
This patch fixes it to pass the requester ID.

[ Impact: fix setting the wrong req-id in acpi-table parsing ]
Signed-off-by: NNeil Turton <nturton@solarflare.com>
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

The variable amd_iommu_last_bdf holds the maximum bdf of any device
controlled by an IOMMU, so the number of device entries needed is
amd_iommu_last_bdf+1.  The function tbl_size used amd_iommu_last_bdf
instead.  This would be a problem if the last device were a large
enough power of 2.

[ Impact: fix amd_iommu_last_bdf off-by-one error ]
Signed-off-by: NNeil Turton <nturton@solarflare.com>
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

With device isolation disabled we can test better for race conditions in
dma_ops related code.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This Kconfig option is intended to enable various code paths or
parameters in IOMMU implementations to stress test the code and/or the
hardware. This can also be done by disabling optimizations in the code
when this option is switched on.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>

This information is only helpful for debugging. Don't print it anymore
unless explicitly requested.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

Add information about device memory mapping requirements for the IOMMU
as described in the IVRS ACPI table to the kernel log if amd_iommu_dump
was specified on the kernel command line.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

Add information about devices belonging to an IOMMU as described in the
IVRS ACPI table to the kernel log if amd_iommu_dump was specified on the
kernel command line.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

Add information about IOMMU devices described in the IVRS ACPI table to
the kernel log if amd_iommu_dump was specified on the kernel command
line.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

This kernel parameter will be useful to get some AMD IOMMU related
information in dmesg that is not necessary for the default user but may
be helpful in debug situations.
Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>

Merge reason: core/iommu was on an .30-rc1 base,
              update it to .30-rc5 to refresh.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

* git://git.infradead.org/mtd-2.6:
  mtd: fix timeout in M25P80 driver
  mtd: Bug in m25p80.c during whole-chip erase
  mtd: expose subpage size via sysfs
  mtd: mtd in mtd_release is unused without CONFIG_MTD_CHAR

Merge branch 'x86-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

* 'x86-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
  x86: MCE: make cmci_discover_lock irq-safe
  x86: xen, i386: reserve Xen pagetables
  x86, kexec: fix crashdump panic with CONFIG_KEXEC_JUMP
  x86-64: finish cleanup_highmaps()'s job wrt. _brk_end
  x86: fix boot hang in early_reserve_e820()
  x86: Fix a typo in a printk message
  x86, srat: do not register nodes beyond e820 map

* 'hwmon-for-linus' of git://jdelvare.pck.nerim.net/jdelvare-2.6:
  hwmon: (w83781d) Fix W83782D support (NULL pointer dereference)
  hwmon: (asus_atk0110) Fix compiler warning

* 'fixes-for-linus' of git://git.monstr.eu/linux-2.6-microblaze:
  microblaze: Fix return value for sys_ipc
  microblaze: Storage class should be before const qualifier