1. 12 5月, 2007 39 次提交
  2. 11 5月, 2007 1 次提交
    • N
      md: improve the is_mddev_idle test · 435b71be
      NeilBrown 提交于
      During a 'resync' or similar activity, md checks if the devices in the
      array are otherwise active and winds back resync activity when they are.
      This test in done in is_mddev_idle, and it is somewhat fragile - it
      sometimes thinks there is non-sync io when there isn't.
      
      The test compares the total sectors of io (disk_stat_read) with the sectors
      of resync io (disk->sync_io).  This has problems because total sectors gets
      updated when a request completes, while resync io gets updated when the
      request is submitted.  The time difference can cause large differenced
      between the two which do not actually imply non-resync activity.  The test
      currently allows for some fuzz (+/- 4096) but there are some cases when it
      is not enough.
      
      The test currently looks for any (non-fuzz) difference, either positive or
      negative.  This clearly is not needed.  Any non-sync activity will cause
      the total sectors to grow faster than the sync_io count (never slower) so
      we only need to look for a positive differences.
      
      If we do this then the amount of in-flight sync io will never cause the
      appearance of non-sync IO.  Once enough non-sync IO to worry about starts
      happening, resync will be slowed down and the measurements will thus be
      more precise (as there is less in-flight) and control of resync will still
      be suitably responsive.
      Signed-off-by: NNeil Brown <neilb@suse.de>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      435b71be