Skip to content

K
kernel_linux

OpenHarmony / kernel_linux
上一次同步 3 年多

通知 13
Star 8
Fork 2
K
kernel_linux
切换分支/标签
  1. 05 10月, 2008 1 次提交
    • J
      V4L/DVB (8955): bttv: Prevent NULL pointer dereference in radio_open · c37396c1
      由 Jean Delvare 提交于 
      Fix the following crash in the bttv driver:

BUG: unable to handle kernel NULL pointer dereference at 000000000000036c
IP: [<ffffffffa037860a>] radio_open+0x3a/0x170 [bttv]

This happens because radio_open assumes that all present bttv devices
have a radio function. If a bttv device without radio and one with
radio are installed on the same system, and the one without radio is
registered first, then radio_open checks for the radio device number
of a bttv device that has no radio function, and this breaks. All we
have to do to fix it is to skip bttv devices without a radio function.
Signed-off-by: NJean Delvare <khali@linux-fr.org>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      c37396c1
  3. 04 9月, 2008 1 次提交
  5. 27 7月, 2008 1 次提交
  7. 26 7月, 2008 1 次提交
  9. 24 7月, 2008 3 次提交
  11. 20 7月, 2008 3 次提交
  13. 21 5月, 2008 1 次提交
  15. 25 4月, 2008 3 次提交
  17. 02 4月, 2008 4 次提交
  19. 20 3月, 2008 1 次提交
  21. 18 2月, 2008 2 次提交
  23. 26 1月, 2008 14 次提交
  25. 07 1月, 2008 1 次提交
  27. 12 12月, 2007 2 次提交
  29. 05 11月, 2007 2 次提交
    • T
      V4L/DVB (6392): bttv: Update initial image size when set via V4L1 VIDIOCMCAPTURE · a8ab68bf
      由 Trent Piepho 提交于 
      The V4L1 spec says that the image size should be with with VIDIOCSWIN before
requesting buffers with VIDIOCGMBUF and capturing into them with
VIDIOCMCAPTURE.

But it seems that many apps don't do this.  They set the size using the fields
in the VIDIOCMCAPTURE ioctl.  The driver doesn't know what size to capture
until it actually starts to capture.  In particular, it doesn't know what size
to capture until it has already mmap the captured buffers.  Which is quite
stupid.  Why V4L1 has size and format fields for VIDIOCMCAPTURE I have no idea.

Many drivers don't support this, including those using v4l1-compat.

The bttv does, which is probably the only reason such broken software is so
prevalent.

But, the driver doesn't adjust its idea of what size is being captured when it
is set this way.  If you try to query the driver's current setting with
v4l2-ctl, it won't be correct.
Signed-off-by: NTrent Piepho <xyzzy@speakeasy.org>
Signed-off-by: NMauro Carvalho Chehab <mchehab@infradead.org>
      a8ab68bf
    • T
      V4L/DVB (6391): bttv: SPICT ioctl doesn't work with vlc · 35378434
      由 Trent Piepho 提交于 
      The bttv driver instists that the depth specified in the call to VIDIOCSPICT
match the pixel format specified in the same call.

vlc doesn't set the depth field, which makes the SPICT ioctl always fail.

The V4L1 standard is not clear on how most operation are supposed to work, and
this is no exception.  The depth field would appear to be entirely redundant,
as the pixel format specifies a specific depth.  It could be that this field
was only meant for output from the *G*PICT ioctl and should be ignored in
*S*PICT.  This is in fact what the v4l1-compat wrapper does.
Signed-off-by: NTrent Piepho <xyzzy@speakeasy.org>
Signed-off-by: NMauro Carvalho Chehab <mchehab@infradead.org>
      35378434