1. 08 3月, 2008 1 次提交
    • B
      ide-cd: mark REQ_TYPE_ATA_PC write requests with REQ_RW flag · b348487f
      Bartlomiej Zolnierkiewicz 提交于
      On Thursday 06 March 2008, walt wrote:
      
      > For me, this commit causes the problem it's intended to fix:
      > 
      > commit 9f10d9ee
      > Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      > Date:   Tue Feb 26 21:50:35 2008 +0100
      > 
      >      ide-cd: fix 'ireason' handling for REQ_TYPE_ATA_PC requests
      > 
      >      This fixes some hangs caused by not finishing the transfer before ending
      >      the request and also makes use of 'ireason == 1' quirk for spurious IRQs.
      > 
      > When I mount a CD there is a long delay, and I see this error message:
      > 
      > hdc: ide_cd_check_ireason: wrong transfer direction!
      > cdrom: failed setting lba address space
      > hdc: status error: status=0x58 { DriveReady SeekComplete DataRequest }
      > ide: failed opcode was: unknown
      > hdc: drive not ready for command
      > <repeated many times>
      > 
      > When I revert this commit everything works properly again, including
      > CD burning.
      
      It turned out that REQ_TYPE_ATA_PC write requests were not marked as such
      (the previous commit assumed them to be).
      Reported-by: Nwalt <w41ter@gmail.com>
      Tested-by: Nwalt <w41ter@gmail.com>
      Reviewed-by: NBorislav Petkov <petkovbb@googlemail.com>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      b348487f
  2. 02 2月, 2008 2 次提交