- 23 4月, 2018 40 次提交
-
-
由 NeilBrown 提交于
Linux has a resizeable hashtable implementation in lib, so we should use that instead of having one in libcfs. This patch converts the ptlrpc conn_hash to use rhashtable. In the process we gain lockless lookup. As connections are never deleted until the hash table is destroyed, there is no need to count the reference in the hash table. There is also no need to enable automatic_shrinking. Signed-off-by: NNeilBrown <neilb@suse.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 NeilBrown 提交于
This include file is only included in one place, and only contains a list of other include directives. So just move all those to the place where this file is included, and discard the file. One include directive uses a local name ("linux-cpu.h"), so that needs to be given a proper path. Probably many of these should be remove from here, and moved to just the files that need them. Signed-off-by: NNeilBrown <neilb@suse.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org> -
由 NeilBrown 提交于
CDEBUG_STACK() and CHECK_STACK() are macros to help with debugging, so move them from drivers/staging/lustre/include/linux/libcfs/linux/libcfs.h to drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h This seems a more fitting location, and is a step towards removing linux/libcfs.h and simplifying the include file structure. Signed-off-by: NNeilBrown <neilb@suse.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 James Simmons 提交于
In ll_xattr_set_common() detect the removexattr() case correctly by testing for a NULL value as well as XATTR_REPLACE. Signed-off-by: NJohn L. Hammond <john.hammond@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10787 Reviewed-on: https://review.whamcloud.com/Reviewed-by: NDmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: NJames Simmons <uja.ornl@yahoo.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 John L. Hammond 提交于
If struct xattr_handler has a name member then use it (rather than prefix) for the ACL xattrs. This avoids a bug where ACL operations failed for some kernels. Signed-off-by: NJohn L. Hammond <john.hammond@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10785 Reviewed-on: https://review.whamcloud.com/Reviewed-by: NDmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: NJames Simmons <uja.ornl@yahoo.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 James Simmons 提交于
Small style changes to match more the kernel code standard and it make it more readable. Signed-off-by: NJames Simmons <uja.ornl@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240Reviewed-by: NDmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: NBob Glossman <bob.glossman@intel.com> Reviewed-by: NSebastien Buisson <sbuisson@ddn.com> Reviewed-by: NOleg Drokin <oleg.drokin@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 James Simmons 提交于
Add proper punctuation to the comments. Change buf_size to size for comment in ll_listxattr() since buf_size doesn't exit which will confuse someone reading the code. Signed-off-by: NJames Simmons <uja.ornl@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240Reviewed-by: NDmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: NBob Glossman <bob.glossman@intel.com> Reviewed-by: NSebastien Buisson <sbuisson@ddn.com> Reviewed-by: NOleg Drokin <oleg.drokin@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 James Simmons 提交于
Convert __uXX types to uXX types since this is kernel code. The function ll_lov_user_md_size() returns ssize_t so change lum_size from int to ssize_t. Signed-off-by: NJames Simmons <uja.ornl@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240Reviewed-by: NDmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: NBob Glossman <bob.glossman@intel.com> Reviewed-by: NSebastien Buisson <sbuisson@ddn.com> Reviewed-by: NOleg Drokin <oleg.drokin@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 James Simmons 提交于
Having an extra ifdef makes the code harder to read. For the case of ll_xattr_get_common() we have a variable initialized at the start of the function but it is only used in XATTR_ACL_ACCESS_T code block. Lets move that variable to that location since its only used there and make the code look cleaner. Signed-off-by: NJames Simmons <uja.ornl@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240Reviewed-by: NDmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: NBob Glossman <bob.glossman@intel.com> Reviewed-by: NSebastien Buisson <sbuisson@ddn.com> Reviewed-by: NOleg Drokin <oleg.drokin@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 James Simmons 提交于
Keep track of attempted deletions as well as changing of the lma/link xattrs. Signed-off-by: NJames Simmons <uja.ornl@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240Reviewed-by: NDmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: NBob Glossman <bob.glossman@intel.com> Reviewed-by: NSebastien Buisson <sbuisson@ddn.com> Reviewed-by: NOleg Drokin <oleg.drokin@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 James Simmons 提交于
In creating the full name of a xattr a new line was added that was seen by the remote MDS server which confused it. Remove the newline. Signed-off-by: NJames Simmons <uja.ornl@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240Reviewed-by: NDmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: NBob Glossman <bob.glossman@intel.com> Reviewed-by: NSebastien Buisson <sbuisson@ddn.com> Reviewed-by: NOleg Drokin <oleg.drokin@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 James Simmons 提交于
The size check at the start of ll_setstripe_ea() is only valid for a directory. Move that check to the section of code handling the S_ISDIR case. Signed-off-by: NJames Simmons <uja.ornl@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240Reviewed-by: NDmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: NBob Glossman <bob.glossman@intel.com> Reviewed-by: NSebastien Buisson <sbuisson@ddn.com> Reviewed-by: NOleg Drokin <oleg.drokin@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Bobi Jam 提交于
Tools like rsync, tar, cp may copy and restore the xattrs on a file. The client previously ignored the setting of trusted.lov/lustre.lov if the layout had already been specified, to avoid causing these tools to fail for no reason. For PFL files we still need to silently eat -EEXIST on setting these attributes to avoid problems. Signed-off-by: NBobi Jam <bobijam.xu@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9484 Reviewed-on: https://review.whamcloud.com/27126Reviewed-by: NDmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: NNiu Yawei <yawei.niu@intel.com> Reviewed-by: NJames Simmons <uja.ornl@yahoo.com> Reviewed-by: NAndreas Dilger <andreas.dilger@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Bobi Jam 提交于
No need to check several times if lump is NULL. Just test once and return 0 if NULL. Signed-off-by: NBobi Jam <bobijam.xu@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9484 Reviewed-on: https://review.whamcloud.com/27126Reviewed-by: NDmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: NNiu Yawei <yawei.niu@intel.com> Reviewed-by: NJames Simmons <uja.ornl@yahoo.com> Reviewed-by: NAndreas Dilger <andreas.dilger@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Bobi Jam 提交于
Place all the handling of information of trusted.lov that is not stripe related into the new function ll_adjust_lum(). Now ll_setstripe_ea() only handles striping information. Signed-off-by: NBobi Jam <bobijam.xu@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9484 Reviewed-on: https://review.whamcloud.com/27126Reviewed-by: NDmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: NNiu Yawei <yawei.niu@intel.com> Reviewed-by: NJames Simmons <uja.ornl@yahoo.com> Reviewed-by: NAndreas Dilger <andreas.dilger@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Niu Yawei 提交于
Simple comment added to ll_xattr_set. Signed-off-by: NBobi Jam <bobijam.xu@intel.com> Signed-off-by: NNiu Yawei <yawei.niu@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8998 Reviewed-on: https://review.whamcloud.com/24851Reviewed-by: NAndreas Dilger <andreas.dilger@intel.com> Reviewed-by: NLai Siyao <lai.siyao@intel.com> Reviewed-by: NJinshan Xiong <jinshan.xiong@gmail.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Niu Yawei 提交于
The function ll_xattr_set() contains special code to handle the lustre specific xattr lustre.lov. Move all this code to a new function ll_setstripe_ea(). Signed-off-by: NBobi Jam <bobijam.xu@intel.com> Signed-off-by: NNiu Yawei <yawei.niu@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8998 Reviewed-on: https://review.whamcloud.com/24851Reviewed-by: NAndreas Dilger <andreas.dilger@intel.com> Reviewed-by: NLai Siyao <lai.siyao@intel.com> Reviewed-by: NJinshan Xiong <jinshan.xiong@gmail.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Robin Humble 提交于
The security.capability xattr is used to implement File Capabilities in recent Linux versions. Capabilities are a fine grained approach to granting executables elevated privileges. eg. /bin/ping can have capabilities cap_net_admin, cap_net_raw+ep instead of being setuid root. This xattr has long been filtered out by llite, initially for stability reasons (b15587), and later over performance concerns as this xattr is read for every file with eg. 'ls --color'. Since LU-2869 xattr's are cached on clients, alleviating most performance concerns. Removing llite's filtering of the security.capability xattr enables using Lustre as a root filesystem, which is used on some large clusters. Signed-off-by: NRobin Humble <plaguedbypenguins@gmail.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9562 Reviewed-on: https://review.whamcloud.com/27292Reviewed-by: NJohn L. Hammond <john.hammond@intel.com> Reviewed-by: NSebastien Buisson <sbuisson@ddn.com> Reviewed-by: NOleg Drokin <oleg.drokin@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 John L. Hammond 提交于
In ll_xattr_cache_refill() if the xattr cache was invalid (and no request was sent) then return -EAGAIN so that ll_getxattr_common() caller will fetch the xattr from the MDT. Signed-off-by: NJohn L. Hammond <john.hammond@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10132 Reviewed-on: https://review.whamcloud.com/29654Reviewed-by: NAndreas Dilger <andreas.dilger@intel.com> Reviewed-by: NLai Siyao <lai.siyao@intel.com> Reviewed-by: NOleg Drokin <oleg.drokin@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Vitaly Fertman 提交于
On the server side mdt_intent_getxattr() can return EFAULT if a buffer cannot be found, it is returned after lock_replace, where a new lock is installed into lockp. An error forces ldlm_lock_enqueue() to destroy the original lock, but ldlm_handle_enqueue0() drops the reference on the new lock. The xattr client code implied intent error is returned under a lock, which is immediately cancelled. Check if a lock obtained and cancel it properly for error cases. Note: we should support both cases for interop needs, an intent error under a lock and with a lock abort. Keep returning a lock with an intent error for interop purposes for now, to be dropped later when client will get old enough. make all intent ops to work through md_intent_lock: getxattr and layout, which should extract the intent error. Signed-off-by: NVitaly Fertman <vitaly.fertman@seagate.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7433 Seagate-bug-id: MRP-3072 MRP-3137 Reviewed-on: http://review.whamcloud.com/17220Reviewed-by: NAndrew Perepechko <andrew.perepechko@seagate.com> Reviewed-by: NAndriy Skulysh <andriy.skulysh@seagate.com> Tested-by: NElena V. Gryaznova <elena.gryaznova@seagate.com> Reviewed-by: NJohn L. Hammond <john.hammond@intel.com> Reviewed-by: NLai Siyao <lai.siyao@intel.com> Reviewed-by: NOleg Drokin <oleg.drokin@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Vitaly Fertman 提交于
Remove LL_IT2STR(it) from debug macros in lmv_enqueue(). The removal makes it possible to simplify the md_enqueue() functions. Signed-off-by: NVitaly Fertman <vitaly.fertman@seagate.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7433 Seagate-bug-id: MRP-3072 MRP-3137 Reviewed-on: http://review.whamcloud.com/17220Reviewed-by: NAndrew Perepechko <andrew.perepechko@seagate.com> Reviewed-by: NAndriy Skulysh <andriy.skulysh@seagate.com> Tested-by: NElena V. Gryaznova <elena.gryaznova@seagate.com> Reviewed-by: NJohn L. Hammond <john.hammond@intel.com> Reviewed-by: NLai Siyao <lai.siyao@intel.com> Reviewed-by: NOleg Drokin <oleg.drokin@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Vitaly Fertman 提交于
The lookup_intent it_op fields in many cases will be compared to the settings of IT_OPEN | IT_UNLINK | IT_LOOKUP | IT_GETATTR. Create a simple inline function for this common case. Signed-off-by: NVitaly Fertman <vitaly.fertman@seagate.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7433 Seagate-bug-id: MRP-3072 MRP-3137 Reviewed-on: http://review.whamcloud.com/17220Reviewed-by: NAndrew Perepechko <andrew.perepechko@seagate.com> Reviewed-by: NAndriy Skulysh <andriy.skulysh@seagate.com> Tested-by: NElena V. Gryaznova <elena.gryaznova@seagate.com> Reviewed-by: NJohn L. Hammond <john.hammond@intel.com> Reviewed-by: NLai Siyao <lai.siyao@intel.com> Reviewed-by: NOleg Drokin <oleg.drokin@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 James Simmons 提交于
When the allocation of xattr->xe_name was moved to kstrdup() setting xattr->xe_namelen was dropped. This field is used in several parts of the xattr cache code so it broke xattr handling. Initialize xattr->xe_namelen when allocating xattr->xe_name succeeds. Also change the debugging statement to really report the xattr name instead of its length which wasn't event being set. Fixes: b3dd8957 ("staging: lustre: lustre: llite: Use kstrdup" Signed-off-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 John L. Hammond 提交于
Request dynamic minor allocation when registering /dev/lnet and /dev/obd. Signed-off-by: NJohn L. Hammond <john.hammond@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-100086 Reviewed-on: https://review.whamcloud.com/29741Reviewed-by: NAndreas Dilger <andreas.dilger@intel.com> Reviewed-by: NJian Yu <jian.yu@intel.com> Reviewed-by: NOleg Drokin <oleg.drokin@intel.com> Signed-off-by: NJames Simmons <jsimmons@infradead.org> Reviewed-by: NNeilBrown <neilb@suse.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 NeilBrown 提交于
These defines are unused or nearly unused, and do not help at all. Signed-off-by: NNeilBrown <neilb@suse.com> Reviewed-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 NeilBrown 提交于
Very little is left in linux-time.h. Move CFS_TICK to libcfs.h discard the test. Signed-off-by: NNeilBrown <neilb@suse.com> Reviewed-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 NeilBrown 提交于
cfs_time_before_64 is the same as time_before64() similarly cfs_time_beforeq_64() matsches time_before_eq64() So just use the standard interfaces. Signed-off-by: NNeilBrown <neilb@suse.com> Reviewed-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 NeilBrown 提交于
cfs_duration_sec() simply divides by HZ. It is mostly used to report durations in debug messages. Remove and just use X/HZ. Signed-off-by: NNeilBrown <neilb@suse.com> Reviewed-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 NeilBrown 提交于
This wrapper is only used once, so open-code it as max(). This allows us to remove the libcfs_time.h include file. Signed-off-by: NNeilBrown <neilb@suse.com> Reviewed-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 NeilBrown 提交于
cfs_time_after() behaves exactly like time_after() similarly cfs_time_aftereq() matches time_after_eq() so discard the cfs versions. Signed-off-by: NNeilBrown <neilb@suse.com> Reviewed-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 NeilBrown 提交于
This function simply multiplies by HZ and adds jiffies. This is simple enough to be opencoded, and doing so makes the code easier to read. Same for cfs_time_shift_64() Signed-off-by: NNeilBrown <neilb@suse.com> Reviewed-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 NeilBrown 提交于
cfs_time_add adds its arguments. cfs_time_sub subtracts finds the difference. Discard these and use '+' and '-' directly. This change highlighted a type error. The structure field cr_queued_time was used to store jiffies, but was declared as time_t (meant for seconds). So the time is changed to "unsigned long". Signed-off-by: NNeilBrown <neilb@suse.com> Reviewed-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 NeilBrown 提交于
Discard cfs_time_current() and cfs_time_current64() and use jiffies and get_jiffies_64() like the rest of the kernel. Signed-off-by: NNeilBrown <neilb@suse.com> Reviewed-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Greg Hartman 提交于
The cuttlefish system is a virtual SoC architecture based on QEMU. It uses the QEMU ivshmem feature to share memory regions between guest and host with a custom protocol. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Arve Hjønnevåg <arve@android.com> Cc: Todd Kjos <tkjos@android.com> Cc: Martijn Coenen <maco@android.com> Cc: Dan Carpenter <dan.carpenter@oracle.com> Cc: devel@driverdev.osuosl.org Cc: kernel-team@android.com Signed-off-by: NGreg Hartman <ghartman@google.com> [astrachan: rebased against 4.16, added TODO, fixed checkpatch issues] Signed-off-by: NAlistair Strachan <astrachan@google.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Todd Poynor 提交于
As a result of various previous patches, ion_buffer_create() now has two sets of identical statements for initializing two fields of the buffer struct, next to each other. Remove one set. Move the initialization of these two fields together with the statements that initialize the other two fields from the function parameters, prior to the heap allocate() call, for consistency. Signed-off-by: NTodd Poynor <toddpoynor@google.com> Acked-by: NSumit Semwal <sumit.semwal@linaro.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 NeilBrown 提交于
ldlm_lock_create() gets a resource, but don't put it on all failure paths. It should. Signed-off-by: NNeilBrown <neilb@suse.com> Reviewed-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 NeilBrown 提交于
1/ the return value of ldlm_resource_putref() is never used, so change it to return 'void'. 2/ Move all of the code to run on the last putref to __ldlm_resource_putref_final(). This means a lock is taken in one function and dropped in another, but that isn't too uncommon, and will disappear in a future patch. Now that the code it together, it becomes apparent that we are dropping a ref on the namespace *before* the last use. So keep the ref until after. Signed-off-by: NNeilBrown <neilb@suse.com> Reviewed-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 NeilBrown 提交于
cfs_hash usage was removed from cl_object.c some time ago, so remove the #include as well. Signed-off-by: NNeilBrown <neilb@suse.com> Reviewed-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 NeilBrown 提交于
exp_lock_hash and exp_flock_hash are unused in the client, so remove all references. Also remove unused hashtable size definitions. Signed-off-by: NNeilBrown <neilb@suse.com> Reviewed-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 NeilBrown 提交于
This function is unused. Signed-off-by: NNeilBrown <neilb@suse.com> Reviewed-by: NJames Simmons <jsimmons@infradead.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-