1. 29 4月, 2009 1 次提交
  2. 31 3月, 2009 3 次提交
    • M
      regulator: Mark attributes table for virtual regulator static · fefdae42
      Mark Brown 提交于
      It's not exported.
      Signed-off-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
      Signed-off-by: NLiam Girdwood <lrg@slimlogic.co.uk>
      fefdae42
    • A
      regulator: minor cleanup of virtual consumer · 9485397a
      Andrew Morton 提交于
      On Thu, 15 Jan 2009 16:10:22 -0800
      Andrew Morton <akpm@linux-foundation.org> wrote:
      
      > On Wed, 14 Jan 2009 13:16:27 -0800
      > David Brownell <david-b@pacbell.net> wrote:
      >
      > > From: David Brownell <dbrownell@users.sourceforge.net>
      > >
      > > Minor cleanup to the regulator set_mode sysfs support:
      > > switch to sysfs_streq() in set_mode(), which is also
      > > a code shrink.  Use the same strings that get_mode()
      > > uses, shrinking data too.
      > >
      > > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
      > > ---
      > >  drivers/regulator/virtual.c |    8 ++++----
      > >  1 file changed, 4 insertions(+), 4 deletions(-)
      > >
      > > --- a/drivers/regulator/virtual.c
      > > +++ b/drivers/regulator/virtual.c
      > > @@ -226,13 +226,13 @@ static ssize_t set_mode(struct device *d
      > >  	unsigned int mode;
      > >  	int ret;
      > >
      > > -	if (strncmp(buf, "fast", strlen("fast")) == 0)
      > > +	if (sysfs_streq(buf, "fast\n") == 0)
      > >  		mode = REGULATOR_MODE_FAST;
      > > -	else if (strncmp(buf, "normal", strlen("normal")) == 0)
      > > +	else if (sysfs_streq(buf, "normal\n") == 0)
      > >  		mode = REGULATOR_MODE_NORMAL;
      > > -	else if (strncmp(buf, "idle", strlen("idle")) == 0)
      > > +	else if (sysfs_streq(buf, "idle\n") == 0)
      > >  		mode = REGULATOR_MODE_IDLE;
      > > -	else if (strncmp(buf, "standby", strlen("standby")) == 0)
      > > +	else if (sysfs_streq(buf, "standby\n") == 0)
      > >  		mode = REGULATOR_MODE_STANDBY;
      >
      > we don't need the \n's, do we?
      
      oh, it's for the string sharing.  Sneaky.
      
      I wonder how many people will try to fix that up for us?
      Acked-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
      Signed-off-by: NLiam Girdwood <lrg@slimlogic.co.uk>
      9485397a
    • D
      regulator: minor cleanup of virtual consumer · 93e14baa
      David Brownell 提交于
      Minor cleanup to the regulator set_mode sysfs support:
      switch to sysfs_streq() in set_mode(), which is also
      a code shrink.  Use the same strings that get_mode()
      uses, shrinking data too.
      Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      Acked-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
      Signed-off-by: NLiam Girdwood <lrg@slimlogic.co.uk>
      93e14baa
  3. 30 7月, 2008 1 次提交