1. 07 8月, 2012 1 次提交
    • I
      Revert "ARM: OMAP3530evm: set pendown_state and debounce time for ads7846" · c31cc1b7
      Igor Grinberg 提交于
      1) The above commit introduced a common ->get_pendown_state() function
      into the generic code, but that function was board-specific for the
      OMAP3EVM and thus broke most other boards using this code.
      
      2) The above commit was mis-merged introducing another bug which
      prevents the ads7846 driver probe function to succeed.
      The omap_ads7846_init() function frees the pendown GPIO in case there is
      no ->get_pendown_state() function set by the caller (board specific
      code), so it can be requested later by the ads7846 driver.
      The above commit add a common ->get_pendown_state() function without
      removing the gpio_free() call and thus once the ads7846 driver tries
      to use the pendown GPIO, it crashes as the pendown GPIO has not been
      requested.
      
      3) The above commit introduces NO new functionality as
      get_pendown_state() function is already implemented in a suitable way by
      the ads7846 driver and the debounce time handling has already been
      fixed by commit 97ee9f01 (ARM: OMAP: fix the ads7846 init code).
      
      This reverts commit 16aced80.
      
      Conflicts:
      	arch/arm/mach-omap2/common-board-devices.c
      
      Solved by taking the working version prior to the above commit.
      
      Cc: Zumeng Chen <zumeng.chen@windriver.com>
      Cc: Arnd Bergmann <arnd@arndb.de>
      Signed-off-by: NIgor Grinberg <grinberg@compulab.co.il>
      Reviewed-by: NKevin Hilman <khilman@ti.com>
      Tested-by: NKevin Hilman <khilman@ti.com>
      Signed-off-by: NKevin Hilman <khilman@ti.com>
      c31cc1b7
  2. 06 7月, 2012 1 次提交
    • Z
      ARM: OMAP3530evm: set pendown_state and debounce time for ads7846 · 16aced80
      Zumeng Chen 提交于
      Currently most ads7846 config definitions for OMAP3 series boards have
      been moved to common-board-devices.c, and it is transparent for init.
      And it's no very proper to do gpio_request based on get_pendown_state
      since omap_ads7846_init knows everything about ads7846_config.
      
      So it's more fit to request gpio according to the right gpio_pendown
      and set debounce time conditionally. If we don't set proper debouce
      time, there are flooded interrupt counters of ads7846 responding to
      one time touch on screen, then the driver couldn't work very well.
      
      This patch has been validated on 3530evm.
      Signed-off-by: NZumeng Chen <zumeng.chen@windriver.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      16aced80
  3. 04 7月, 2011 1 次提交
  4. 01 6月, 2011 1 次提交
  5. 03 5月, 2011 3 次提交