1. 21 5月, 2010 1 次提交
  2. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  3. 17 10月, 2007 1 次提交
    • A
      vt/vgacon: Check if screen resize request comes from userspace · e400b6ec
      Antonino A. Daplas 提交于
      Various console drivers are able to resize the screen via the con_resize()
      hook.  This hook is also visible in userspace via the TIOCWINSZ, VT_RESIZE and
      VT_RESIZEX ioctl's.  One particular utility, SVGATextMode, expects that
      con_resize() of the VGA console will always return success even if the
      resulting screen is not compatible with the hardware.  However, this
      particular behavior of the VGA console, as reported in Kernel Bugzilla Bug
      7513, can cause undefined behavior if the user starts with a console size
      larger than 80x25.
      
      To work around this problem, add an extra parameter to con_resize().  This
      parameter is ignored by drivers except for vgacon.  If this parameter is
      non-zero, then the resize request came from a VT_RESIZE or VT_RESIZEX ioctl
      and vgacon will always return success.  If this parameter is zero, vgacon will
      return -EINVAL if the requested size is not compatible with the hardware.  The
      latter is the more correct behavior.
      
      With this change, SVGATextMode should still work correctly while in-kernel and
      stty resize calls can expect correct behavior from vgacon.
      Signed-off-by: NAntonino Daplas <adaplas@gmail.com>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      e400b6ec
  4. 13 10月, 2007 2 次提交
  5. 13 7月, 2007 1 次提交
    • A
      USB: prevent char device open/deregister race · d4ead16f
      Alan Stern 提交于
      This patch (as908) adds central protection in usbcore for the
      prototypical race between opening and unregistering a char device.
      The spinlock used to protect the minor-numbers array is replaced with
      an rwsem, which can remain locked across a call to a driver's open()
      method.  This guarantees that open() and deregister() will be mutually
      exclusive.
      
      The private locks currently used in several individual drivers for
      this purpose are no longer necessary, and the patch removes them.  The
      following USB drivers are affected: usblcd, idmouse, auerswald,
      legousbtower, sisusbvga/sisusb, ldusb, adutux, iowarrior, and
      usb-skeleton.
      
      As a side effect of this change, usb_deregister_dev() must not be
      called while holding a lock that is acquired by open().  Unfortunately
      a number of drivers do this, but luckily the solution is simple: call
      usb_deregister_dev() before acquiring the lock.
      
      In addition to these changes (and their consequent code
      simplifications), the patch fixes a use-after-free bug in adutux and a
      race between open() and release() in iowarrior.
      Signed-off-by: NAlan Stern <stern@rowland.harvard.edu>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      d4ead16f
  6. 09 5月, 2007 2 次提交
  7. 15 2月, 2007 1 次提交
    • T
      [PATCH] remove many unneeded #includes of sched.h · cd354f1a
      Tim Schmielau 提交于
      After Al Viro (finally) succeeded in removing the sched.h #include in module.h
      recently, it makes sense again to remove other superfluous sched.h includes.
      There are quite a lot of files which include it but don't actually need
      anything defined in there.  Presumably these includes were once needed for
      macros that used to live in sched.h, but moved to other header files in the
      course of cleaning it up.
      
      To ease the pain, this time I did not fiddle with any header files and only
      removed #includes from .c-files, which tend to cause less trouble.
      
      Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
      arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
      allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
      configs in arch/arm/configs on arm.  I also checked that no new warnings were
      introduced by the patch (actually, some warnings are removed that were emitted
      by unnecessarily included header files).
      Signed-off-by: NTim Schmielau <tim@physik3.uni-rostock.de>
      Acked-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      cd354f1a
  8. 06 1月, 2007 1 次提交
    • A
      sisusb_con warning fixes · c067dfc6
      Andrew Morton 提交于
      x86_64:
      
      drivers/usb/misc/sisusbvga/sisusb_con.c: In function 'sisusbcon_putc':
      drivers/usb/misc/sisusbvga/sisusb_con.c:405: warning: cast from pointer to integer of different size
      drivers/usb/misc/sisusbvga/sisusb_con.c: In function 'sisusbcon_putcs':
      drivers/usb/misc/sisusbvga/sisusb_con.c:440: warning: cast from pointer to integer of different size
      drivers/usb/misc/sisusbvga/sisusb_con.c: In function 'sisusbcon_clear':
      drivers/usb/misc/sisusbvga/sisusb_con.c:494: warning: cast from pointer to integer of different size
      drivers/usb/misc/sisusbvga/sisusb_con.c: In function 'sisusbcon_bmove':
      drivers/usb/misc/sisusbvga/sisusb_con.c:566: warning: cast from pointer to integer of different size
      drivers/usb/misc/sisusbvga/sisusb_con.c: In function 'sisusbcon_switch':
      drivers/usb/misc/sisusbvga/sisusb_con.c:614: warning: cast from pointer to integer of different size
      drivers/usb/misc/sisusbvga/sisusb_con.c: In function 'sisusbcon_scroll_area':
      drivers/usb/misc/sisusbvga/sisusb_con.c:941: warning: cast from pointer to integer of different size
      
      Cc: Thomas Winischhofer <thomas@winischhofer.net>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      c067dfc6
  9. 04 10月, 2006 1 次提交
  10. 22 6月, 2006 2 次提交
  11. 09 11月, 2005 1 次提交
    • O
      [PATCH] changing CONFIG_LOCALVERSION rebuilds too much, for no good reason · 733482e4
      Olaf Hering 提交于
      This patch removes almost all inclusions of linux/version.h.  The 3
      #defines are unused in most of the touched files.
      
      A few drivers use the simple KERNEL_VERSION(a,b,c) macro, which is
      unfortunatly in linux/version.h.
      
      There are also lots of #ifdef for long obsolete kernels, this was not
      touched.  In a few places, the linux/version.h include was move to where
      the LINUX_VERSION_CODE was used.
      
      quilt vi `find * -type f -name "*.[ch]"|xargs grep -El '(UTS_RELEASE|LINUX_VERSION_CODE|KERNEL_VERSION|linux/version.h)'|grep -Ev '(/(boot|coda|drm)/|~$)'`
      
      search pattern:
      /UTS_RELEASE\|LINUX_VERSION_CODE\|KERNEL_VERSION\|linux\/\(utsname\|version\).h
      Signed-off-by: NOlaf Hering <olh@suse.de>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      733482e4
  12. 13 9月, 2005 1 次提交
    • T
      [PATCH] USB: sisusb[vga] update · 1bbb4f20
      Thomas Winischhofer 提交于
      here is a new and extended version of the sisusbvga (previously: sisusb)
      driver. The patch is against 2.6.13 and updates the driver to version 0.0.8.
      
      Additions include complete VGA/EGA text console support and a build-in
      display mode infrastructure for userland applications that don't know
       about the graphics internals.
      
      Fixes include some BE/LE issues and a get/put_dev bug in the previous
      version.
      
      Other changes include a change of the module name from "sisusb" to
      "sisusbvga". The previous one was too generic IMHO.
      
      Please note that the patch also affects the Makefile in
      drivers/video/console as the driver requires the VGA 8x16 font in case
      the text console part is selected.
      
      Heavily tested, as usual. Please apply.
      
      One thing though: I already prepared for removal of the "mode" field and
      the changed "name" field in the usb_class_driver structure. This will
      perhaps need some refinement depending on whether you/Linus merge the
      respective core changes before or after 2.6.14.
      Signed-off-by: NThomas Winischhofer <thomas@winischhofer.net>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      1bbb4f20