Move some code from atlx.c to atl1.c to prevent build conflict with
the upcoming atl2 code.  No changes, just movement.
Signed-off-by: NChris Snook <csnook@redhat.com>
Signed-off-by: NJeff Garzik <jgarzik@redhat.com>

There's no good reason to manually set the flash vendor in a module
parameter, outside of an Atheros hardware lab.  Remove it, so nobody
accidentally bricks their board using it incorrectly.
Signed-off-by: NChris Snook <csnook@redhat.com>
Signed-off-by: NJeff Garzik <jgarzik@redhat.com>

Rearrange functions to allow removal of some forward declarations.
Make certain global functions static along the way.
Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net>
Acked-by: NChris Snook <csnook@redhat.com>
Signed-off-by: NJeff Garzik <jeff@garzik.org>

Make needlessly global functions static.  In a couple of cases this
requires removing forward declarations and reordering functions.
Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net>
Acked-by: NChris Snook <csnook@redhat.com>
Signed-off-by: NJeff Garzik <jeff@garzik.org>

Add some debug printks if we encounter a potentially bad receive
return descriptor.
Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net>
Acked-by: NChris Snook <csnook@redhat.com>
Signed-off-by: NJeff Garzik <jeff@garzik.org>

Use netif_msg_* for console messages emitted by the driver. Add a
parameter to allow control of messaging at driver startup, and also
add the ability to control it with ethtool.
Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net>
Acked-by: NChris Snook <csnook@redhat.com>
Signed-off-by: NJeff Garzik <jeff@garzik.org>

Use skb->csum_start for tx checksum offload preparation. Also swap
the variables css and cso so they hold the intended values of csum
start and offset, respectively.
Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net>
Acked-by: NChris Snook <csnook@redhat.com>
Signed-off-by: NJeff Garzik <jeff@garzik.org>

The transmit packet descriptor consists of four 32-bit words, with word 3
upper bits overloaded depending upon the condition of its bits 3 and 4.
The driver currently duplicates all word 2 and some word 3 register bit
definitions unnecessarily and also uses a set of nested structures in its
definition of the TPD without good cause. This patch adds a lengthy
comment describing the TPD, eliminates duplicate TPD bit definitions,
and simplifies the TPD structure itself. It also expands the TSO check
to correctly handle custom checksum versus TSO processing using the revised
TPD definitions. Finally, shorten some variable names in the transmit
processing path to reduce line lengths, rename some variables to better
describe their purpose (e.g., nseg versus m), and add a comment or two
to better describe what the code is doing.
Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net>
Acked-by: NChris Snook <csnook@redhat.com>
Signed-off-by: NJeff Garzik <jeff@garzik.org>

Add the ethtool register dump option to the atl1 driver.
Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net>
Acked-by: NChris Snook <csnook@redhat.com>
Signed-off-by: NJeff Garzik <jeff@garzik.org>

The L1 tx packet descriptor expects TCP Header Length to be expressed as a
number of 32-bit dwords.  The atl1 driver uses tcp_hdrlen() to populate the
field, but tcp_hdrlen() returns the header length in bytes, not in dwords.
Add a shift to convert tcp_hdrlen() to dwords when we write it to the tpd.

Also, some of our bit assignments are made to the wrong tpd words.  Change
those to the correct words.

Finally, since all this fixes TSO, enable TSO by default.
Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net>
Acked-by: NChris Snook <csnook@redhat.com>
Signed-off-by: NJeff Garzik <jeff@garzik.org>

The future atl2 driver and the existing atl1 driver can share certain
functions and definitions.  Move these shareable functions and definitions
out of atl1-specific files and into atlx.c and atlx.h.  Some transitory
hackery will be present until atl2 is merged.

Reduce the number of source files by moving ethtool, hw, and param
functions from separate files into atl1_main.c, then rename it to just
atl1.c.

Move all atl1-specific definitions from atl1_hw.h to atl1.h.

Finally, clean up to make checkpatch.pl happy.
Signed-off-by: NChris Snook <csnook@redhat.com>
Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net>
Signed-off-by: NJeff Garzik <jeff@garzik.org>

In preparation for a future Atheros L2 NIC driver (called atl2), relocate
the atl1 driver into a new /drivers/net/atlx directory that will ultimately
be shared with the future atl2 driver.
Signed-off-by: NChris Snook <csnook@redhat.com>
Signed-off-by: NJay Cliburn <jacliburn@bellsouth.net>
Signed-off-by: NJeff Garzik <jeff@garzik.org>