1. 21 11月, 2012 1 次提交
  2. 29 10月, 2012 1 次提交
    • K
      [media] v4l2: Fix typo in struct v4l2_captureparm description · 2e74598d
      Kirill Smelkov 提交于
      Judging from what drivers do and from my experience temeperframe
      fraction is set in seconds - look e.g. here
          static int bttv_g_parm(struct file *file, void *f,
                                          struct v4l2_streamparm *parm)
          {
                  struct bttv_fh *fh = f;
                  struct bttv *btv = fh->btv;
                  v4l2_video_std_frame_period(bttv_tvnorms[btv->tvnorm].v4l2_id,
                                              &parm->parm.capture.timeperframe);
          ...
          void v4l2_video_std_frame_period(int id, struct v4l2_fract *frameperiod)
          {
                  if (id & V4L2_STD_525_60) {
                          frameperiod->numerator = 1001;
                          frameperiod->denominator = 30000;
                  } else {
                          frameperiod->numerator = 1;
                          frameperiod->denominator = 25;
                  }
      and also v4l2-ctl in userspace decodes this as seconds:
          if (doioctl(fd, VIDIOC_G_PARM, &parm, "VIDIOC_G_PARM") == 0) {
                  const struct v4l2_fract &tf = parm.parm.capture.timeperframe;
                  ...
                  printf("\tFrames per second: %.3f (%d/%d)\n",
                                  (1.0 * tf.denominator) / tf.numerator,
                                  tf.denominator, tf.numerator);
      The typo was there from day 1 - added in 2002 in e028b61b ([PATCH]
      add v4l2 api)(*)
      (*) found in history tree
          git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.gitSigned-off-by: NKirill Smelkov <kirr@mns.spb.ru>
      Acked-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      2e74598d
  3. 27 10月, 2012 1 次提交
    • D
      [media] rc-core: add separate defines for protocol bitmaps and numbers · c003ab1b
      David Härdeman 提交于
      The RC_TYPE_* defines are currently used both where a single protocol is
      expected and where a bitmap of protocols is expected.
      
      Functions like rc_keydown() and functions which add/remove entries to the
      keytable want a single protocol. Future userspace APIs would also
      benefit from numeric protocols (rather than bitmap ones). Keytables are
      smaller if they can use a small(ish) integer rather than a bitmap.
      
      Other functions or struct members (e.g. allowed_protos,
      enabled_protocols, etc) accept multiple protocols and need a bitmap.
      
      Using different types reduces the risk of programmer error. Using a
      protocol enum whereever possible also makes for a more future-proof
      user-space API as we don't need to worry about a sufficient number of
      bits being available (e.g. in structs used for ioctl() calls).
      
      The use of both a number and a corresponding bit is dalso one in e.g.
      the input subsystem as well (see all the references to set/clear bit when
      changing keytables for example).
      
      This patch separate the different usages in preparation for
      upcoming patches.
      
      Where a single protocol is expected, enum rc_type is used; where one or more
      protocol(s) are expected, something like u64 is used.
      
      The patch has been rewritten so that the format of the sysfs "protocols"
      file is no longer altered (at the loss of some detail). The file itself
      should probably be deprecated in the future though.
      Signed-off-by: NDavid Härdeman <david@hardeman.nu>
      Cc: Andy Walls <awalls@md.metrocast.net>
      Cc: Maxim Levitsky <maximlevitsky@gmail.com>
      Cc: Antti Palosaari <crope@iki.fi>
      Cc: Mike Isely <isely@pobox.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      c003ab1b
  4. 19 10月, 2012 2 次提交
  5. 17 10月, 2012 1 次提交
  6. 13 10月, 2012 10 次提交
  7. 12 10月, 2012 10 次提交
  8. 11 10月, 2012 8 次提交
  9. 10 10月, 2012 6 次提交