settle_time and debounce_period are u8 and thus can not be greater than
TC3589x_MAX_DEBOUNCE_SETTLE which is 255.

There also no need to mask out nibbles form board->krow and board->kcol
as we validate that they are in correct range.
Reported-by: NWerner <w.landgraf@ru.ru>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

This adds two missing kerneldoc entries for the TC3589x
keypad driver.
Signed-off-by: NNaga Radhesh <naga.radheshy@stericsson.com>
Reviewed-by: NSrinidhi Kasagar <srinidhi.kasagar@stericsson.com>
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Commit 940ab889 introduced a new macro to
save some platform_driver boilerplate code. Use it.
Signed-off-by: NJJ Ding <dgdunix@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

WARNING: drivers/input/keyboard/built-in.o(.text+0xb55b): Section mismatch in reference from the function tc3589x_keypad_open() to the function .devinit.text:tc3589x_keypad_init_key_hardware()
The function tc3589x_keypad_open() references
the function __devinit tc3589x_keypad_init_key_hardware().
This is often because tc3589x_keypad_open lacks a __devinit
annotation or the annotation of tc3589x_keypad_init_key_hardware is wrong.
Signed-off-by: NHarvey Yang <harvey.huawei.yang@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Also rearrange driver structure initializer a bit.
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

There was a semi-colon missing and it broke the compile.
Signed-off-by: NDan Carpenter <error27@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: NLinus Walleij <linus.walleij@stericsson.com>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

Add support for the keypad controller module found on the
TC3589X devices. This driver default adds the support for
TC35893 device.
Signed-off-by: NSundar Iyer <sundar.iyer@stericsson.com>
Acked-by: NDmitry Torokhov <dtor@mail.ru>
[Some minor fixups for compilation]
Signed-off-by: NLinus Walleij <linus.walleij@stericsson.com>