1. 23 8月, 2013 1 次提交
    • W
      i2c: move OF helpers into the core · 687b81d0
      Wolfram Sang 提交于
      I2C of helpers used to live in of_i2c.c but experience (from SPI) shows
      that it is much cleaner to have this in the core. This also removes a
      circular dependency between the helpers and the core, and so we can
      finally register child nodes in the core instead of doing this manually
      in each driver. So, fix the drivers and documentation, too.
      Signed-off-by: NWolfram Sang <wsa@the-dreams.de>
      687b81d0
  2. 20 8月, 2013 1 次提交
  3. 11 2月, 2013 4 次提交
  4. 23 12月, 2012 1 次提交
  5. 16 11月, 2012 4 次提交
    • S
      i2c: i2c-sh_mobile: fix spurious transfer request timed out · 29fb08c3
      Shinya Kuribayashi 提交于
      Ensure that any of preceding register write operations to the I2C
      hardware block reached the module, and the write data is reflected
      in the registers, before leaving the interrupt handler.
      
      Otherwise, we'll suffer from spurious WAIT interrupts that lead to
      'Transfer request timed out' message, and the transaction failed.
      Reported-by: NTeppei Kamijou <teppei.kamijou.yb@renesas.com>
      Signed-off-by: NShinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
      Signed-off-by: NWolfram Sang <w.sang@pengutronix.de>
      29fb08c3
    • S
      i2c: i2c-sh_mobile: support I2C hardware block with a faster operating clock · ebd5ac16
      Shinya Kuribayashi 提交于
      On newer SH-/R-Mobile SoCs, a clock supply to the I2C hardware block,
      which is used to generate the SCL clock output, is getting faster than
      before, while on the other hand, the SCL clock control registers, ICCH
      and ICCL, stay unchanged in 9-bit-wide (8+1).
      
      On such silicons, the internal SCL clock counter gets incremented every
      2 clocks of the operating clock.
      
      This patch makes it configurable through platform data.
      Signed-off-by: NShinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
      Signed-off-by: NWolfram Sang <w.sang@pengutronix.de>
      ebd5ac16
    • S
      i2c: i2c-sh_mobile: optimize ICCH/ICCL values according to I2C bus speed · 23a61291
      Shinya Kuribayashi 提交于
      ICCH/ICCL values is supposed to be calculated/optimized to strictly meet
      the timing specs required by the I2C standard. The resulting I2C bus
      speed does not matter at all, if it's less than 100 or 400 kHz.
      
      With this change, sh_mobile_i2c_icch() is virtually identical to
      sh_mobile_i2c_iccl(), but they're providing good descriptions of
      SH-/R-Mobile I2C hardware spec, and I'd leave them as separated.
      
      Also fix a typo in the comment, print icch/iccl values at probe, etc.
      Signed-off-by: NShinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
      
      [wsa: squashed two patches for bisectability]
      Signed-off-by: NWolfram Sang <w.sang@pengutronix.de>
      23a61291
    • S
      i2c: i2c-sh_mobile: calculate clock parameters at driver probing time · 7b0e6292
      Shinya Kuribayashi 提交于
      Currently SCL clock parameters (ICCH/ICCL) are calculated in
      activate_ch(), which gets called every time sh_mobile_i2c_xfer() is
      processed, while each I2C bus speed is system-defined and in general
      those parameters do not have to be updated over I2C transactions.
      
      The only reason I could see having it transaction-time is to adjust
      ICCH/ICCL values according to the operating frequency of the I2C
      hardware block, in the face of DFS (Dynamic Frequency Scaling).
      
      However, this won't be necessary.
      
      The operating frequency of the I2C hardware block can change _even_
      in the middle of I2C transactions.  There is no way to prevent it
      from happening, and I2C hardware block can work with such dynamic
      frequency change, of course.
      
      Another is that ICCH/ICCL clock parameters optimized for the faster
      operating frequency, can also be applied to the slower operating
      frequency, as long as slave devices work.  However, the converse is
      not true.  It would violate SCL timing specs of the I2C standard.
      
      What we can do now is to calculate the ICCH/ICCL clock parameters
      according to the fastest operating clock of the I2C hardware block.
      And if that's the case, that calculation should be done just once
      at driver-module-init time.
      
      This patch moves ICCH/ICCL calculating part from activate_ch() into
      sh_mobile_i2c_init(), and call it from sh_mobile_i2c_probe().
      
      Note that sh_mobile_i2c_init() just prepares clock parameters using
      the clock rate and platform data provided, but does _not_ make any
      hardware I/O accesses.  We don't have to care about run-time PM
      maintenance here.
      Signed-off-by: NShinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
      Signed-off-by: NWolfram Sang <w.sang@pengutronix.de>
      7b0e6292
  6. 12 5月, 2012 1 次提交
  7. 29 10月, 2011 1 次提交
  8. 11 5月, 2011 2 次提交
  9. 18 4月, 2011 1 次提交
  10. 04 8月, 2010 1 次提交
  11. 07 4月, 2010 2 次提交
  12. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  13. 16 12月, 2009 1 次提交
  14. 23 8月, 2009 1 次提交
  15. 30 7月, 2009 1 次提交
    • M
      i2c-sh_mobile: change module_init() to subsys_initcall() · ccb3bc16
      Magnus Damm 提交于
      Convert the i2c-sh_mobile i2c bus driver to use
      subsys_initcall() instead of module_init().
      
      This change makes the driver register a bit earlier which
      together with earlier platform data moves the time for probe().
      The earlier probe() makes it possible to use i2c_get_adapter()
      and i2c_transfer() from device_initcall().
      
      The same strategy is used by other i2c bus drivers such as
      i2c-pxa.c and i2c-s3c2410.c.
      Signed-off-by: NMagnus Damm <damm@igel.co.jp>
      [ben-linux@fluff.org: minor subject updaye]
      Signed-off-by: NBen Dooks <ben-linux@fluff.org>
      ccb3bc16
  16. 23 7月, 2009 1 次提交
  17. 15 7月, 2009 1 次提交
  18. 07 1月, 2009 1 次提交
  19. 22 12月, 2008 1 次提交
  20. 13 11月, 2008 1 次提交
  21. 05 9月, 2008 1 次提交
    • M
      i2c: fix i2c-sh_mobile timing issues · 4eb00c9f
      Magnus Damm 提交于
      This patch teaches the i2c-sh_mobile driver to make use of wait irqs.
      Without this patch only dte irqs are used which may lead to overruns
      and cases of missing stop and extra bytes being read on the i2c bus.
      
      Use of wait irqs forces the hardware to pause and wait until the cpu
      is ready. Polling is also reworked in this patch to fix ms delay issues.
      
      Verified with bus analyzer and tested on MigoR and AP325RXA boards.
      Signed-off-by: NMagnus Damm <damm@igel.co.jp>
      Signed-off-by: NPaul Mundt <lethal@linux-sh.org>
      4eb00c9f
  22. 23 4月, 2008 1 次提交