1. 07 12月, 2010 1 次提交
  2. 22 4月, 2010 1 次提交
  3. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  4. 04 12月, 2009 1 次提交
  5. 23 9月, 2009 1 次提交
    • K
      walk system ram range · 908eedc6
      KAMEZAWA Hiroyuki 提交于
      Originally, walk_memory_resource() was introduced to traverse all memory
      of "System RAM" for detecting memory hotplug/unplug range.  For doing so,
      flags of IORESOUCE_MEM|IORESOURCE_BUSY was used and this was enough for
      memory hotplug.
      
      But for using other purpose, /proc/kcore, this may includes some firmware
      area marked as IORESOURCE_BUSY | IORESOUCE_MEM.  This patch makes the
      check strict to find out busy "System RAM".
      
      Note: PPC64 keeps their own walk_memory_resouce(), which walk through
      ppc64's lmb informaton.  Because old kclist_add() is called per lmb, this
      patch makes no difference in behavior, finally.
      
      And this patch removes CONFIG_MEMORY_HOTPLUG check from this function.
      Because pfn_valid() just show "there is memmap or not* and cannot be used
      for "there is physical memory or not", this function is useful in generic
      to scan physical memory range.
      Signed-off-by: NKAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
      Cc: Ralf Baechle <ralf@linux-mips.org>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: WANG Cong <xiyou.wangcong@gmail.com>
      Cc: Américo Wang <xiyou.wangcong@gmail.com>
      Cc: David Rientjes <rientjes@google.com>
      Cc: Roland Dreier <rolandd@cisco.com>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      908eedc6
  6. 22 1月, 2009 1 次提交
  7. 13 1月, 2009 1 次提交
  8. 26 12月, 2008 2 次提交
    • N
      ehea: use get_zeroed_page for alignment-sensitive allocation · d76e56b4
      Nathan Lynch 提交于
      With slub debug enabled, I see the following errors and crash with
      2.6.28-rc9:
      
      IBM eHEA ethernet device driver (Release EHEA_0095)
      ehea: Error in ehea_h_register_rpage_mr: not on pageboundary
      ehea: Error in ehea_reg_mr_section: register_rpage_mr failed
      ehea: Error in ehea_reg_kernel_mr: registering mr failed
      ehea: Error in ehea_setup_ports: creating MR failed
      ehea 23c00100.lhea: setup_ports failed
      Unable to handle kernel paging request for data at address 0x6b6b6b6b6b6bbdcb
      Faulting instruction address: 0xd000000000064a24
      cpu 0x0: Vector: 300 (Data Access) at [c0000000740e7190]
          pc: d000000000064a24: .ehea_update_firmware_handles+0x84/0x47c [ehea]
          lr: d00000000006df34: .ehea_probe_adapter+0x35c/0x39c [ehea]
          sp: c0000000740e7410
         msr: 8000000000009032
         dar: 6b6b6b6b6b6bbdcb
       dsisr: 40000000
        current = 0xc000000074233780
        paca    = 0xc0000000008a3300
          pid   = 2046, comm = modprobe
      enter ? for help
      [c0000000740e74f0] d00000000006df34 .ehea_probe_adapter+0x35c/0x39c [ehea]
      [c0000000740e75a0] c00000000041d5a4 .of_platform_device_probe+0x78/0xb0
      [c0000000740e7630] c0000000002d8b38 .driver_probe_device+0x13c/0x200
      [c0000000740e76c0] c0000000002d8c90 .__driver_attach+0x94/0xd8
      [c0000000740e7750] c0000000002d7d64 .bus_for_each_dev+0x80/0xd8
      [c0000000740e7800] c0000000002d889c .driver_attach+0x28/0x40
      [c0000000740e7880] c0000000002d8340 .bus_add_driver+0xd4/0x284
      [c0000000740e7920] c0000000002d90a0 .driver_register+0xc4/0x198
      [c0000000740e79d0] c00000000041d45c .of_register_driver+0x4c/0x60
      [c0000000740e7a50] c000000000020ef8 .ibmebus_register_driver+0x30/0x4c
      [c0000000740e7ae0] d00000000006e108 .ehea_module_init+0x194/0x208c [ehea]
      [c0000000740e7b90] c000000000009028 .do_one_initcall+0x90/0x1ac
      [c0000000740e7d90] c00000000008619c .sys_init_module+0xc4/0x200
      [c0000000740e7e30] c0000000000084ac syscall_exit+0x0/0x40
      
      (When slub debug is disabled it works fine.)
      
      PAGE_SIZE allocations via slab are not guaranteed to be page-aligned;
      use get_zeroed_page for the 'pt' buffer (I don't really know what this
      is, only that it is passed to firmware and that the first error
      message complains about its alignment).  This allows the system to
      boot.
      Signed-off-by: NNathan Lynch <ntl@pobox.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      d76e56b4
    • J
      drivers/net/ehea: Remove redundant test · 662f44af
      Julia Lawall 提交于
      In each case, vpage is checked not to be NULL just after it is initialized
      at the beginning of each loop iteration.
      
      A simplified version of the semantic patch that makes this change is as
      follows: (http://www.emn.fr/x-info/coccinelle/)
      
      // <smpl>
      @r exists@
      local idexpression x;
      expression E;
      position p1,p2;
      @@
      
      if (x@p1 == NULL || ...) { ... when forall
         return ...; }
      ... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\)
      (
      x@p2 == NULL
      |
      x@p2 != NULL
      )
      
      // another path to the test that is not through p1?
      @s exists@
      local idexpression r.x;
      position r.p1,r.p2;
      @@
      
      ... when != x@p1
      (
      x@p2 == NULL
      |
      x@p2 != NULL
      )
      
      @fix depends on !s@
      position r.p1,r.p2;
      expression x,E;
      statement S1,S2;
      @@
      
      (
      - if ((x@p2 != NULL) || ...)
        S1
      |
      - if ((x@p2 == NULL) && ...) S1
      |
      - BUG_ON(x@p2 == NULL);
      )
      // </smpl>
      Signed-off-by: NJulia Lawall <julia@diku.dk>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      662f44af
  9. 06 11月, 2008 1 次提交
  10. 28 10月, 2008 1 次提交
  11. 22 10月, 2008 1 次提交
  12. 25 9月, 2008 1 次提交
  13. 13 5月, 2008 1 次提交
  14. 03 2月, 2008 1 次提交
  15. 11 10月, 2007 2 次提交
  16. 25 8月, 2007 1 次提交
  17. 17 7月, 2007 1 次提交
    • T
      eHEA: Introducing support vor DLPAR memory add · 44c82152
      Thomas Klein 提交于
      This patch adds support for DLPAR memory add to the eHEA driver. To detect
      whether memory was added the driver uses its own memory mapping table and
      checks for kernel addresses whether they're located in already known memory
      sections. If not the function ehea_rereg_mrs() is triggered which performs
      a rebuild of the mapping table and a re-registration of the global memory
      region.
      Signed-off-by: NThomas Klein <tklein@de.ibm.com>
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      44c82152
  18. 09 7月, 2007 1 次提交
  19. 28 4月, 2007 1 次提交
  20. 10 2月, 2007 1 次提交
  21. 04 12月, 2006 1 次提交
  22. 06 11月, 2006 2 次提交
  23. 14 9月, 2006 1 次提交
    • J
      [PATCH] ehea: IBM eHEA Ethernet Device Driver · 7a291083
      Jan-Bernd Themann 提交于
      Hi Jeff,
      
      I fixed the __iomem issue and tested the driver with sparse. Looks good so far.
      Thanks for your effort.
      
      Jan-Bernd Themann
      Signed-off-by: NJan-Bernd Themann <themann@de.ibm.com>
      
       drivers/net/Kconfig             |    9
       drivers/net/Makefile            |    1
       drivers/net/ehea/Makefile       |    6
       drivers/net/ehea/ehea.h         |  447 ++++++
       drivers/net/ehea/ehea_ethtool.c |  294 ++++
       drivers/net/ehea/ehea_hcall.h   |   51
       drivers/net/ehea/ehea_hw.h      |  287 ++++
       drivers/net/ehea/ehea_main.c    | 2654 ++++++++++++++++++++++++++++++++++++++++
       drivers/net/ehea/ehea_phyp.c    |  705 ++++++++++
       drivers/net/ehea/ehea_phyp.h    |  455 ++++++
       drivers/net/ehea/ehea_qmr.c     |  582 ++++++++
       drivers/net/ehea/ehea_qmr.h     |  358 +++++
       12 files changed, 5849 insertions(+)
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      7a291083