1. 26 6月, 2010 1 次提交
  2. 15 6月, 2010 1 次提交
  3. 06 6月, 2010 1 次提交
  4. 14 5月, 2010 1 次提交
  5. 11 5月, 2010 2 次提交
  6. 01 5月, 2010 1 次提交
  7. 17 4月, 2010 1 次提交
  8. 10 4月, 2010 3 次提交
  9. 24 2月, 2010 1 次提交
  10. 12 2月, 2010 1 次提交
  11. 26 1月, 2010 3 次提交
  12. 20 1月, 2010 2 次提交
  13. 13 1月, 2010 2 次提交
  14. 22 12月, 2009 1 次提交
  15. 19 11月, 2009 4 次提交
  16. 12 11月, 2009 1 次提交
  17. 03 11月, 2009 2 次提交
  18. 28 10月, 2009 6 次提交
  19. 08 10月, 2009 2 次提交
  20. 29 8月, 2009 2 次提交
  21. 20 8月, 2009 2 次提交
    • D
      iwlwifi: fix erroneous use of iwl_rx_packet.len as a length · 396887a2
      Daniel C Halperin 提交于
      The field called 'len' in struct iwl_rx_packet is in fact not just a length
      field but also includes some flags from the flow handler.  In several places
      throughout the driver, this causes incorrect values to be interpreted as
      lengths when the field is improperly masked.
      
      In most situations the improper use is for debugging output, and simply results
      in an erroneous message, such as:
      
      [551933.070224] ieee80211 phy0: I iwl_rx_statistics Statistics notification received (480 vs -1367342620).
      
      which should read '(480 vs 484)'.
      
      In at least one case this could case bad things to happen:
      
      void iwl_rx_pm_debug_statistics_notif(struct iwl_priv *priv,
                                            struct iwl_rx_mem_buffer *rxb)
      {
              struct iwl_rx_packet *pkt = (struct iwl_rx_packet *)rxb->skb->data;
              IWL_DEBUG_RADIO(priv, "Dumping %d bytes of unhandled "
                              "notification for %s:\n",
                              le32_to_cpu(pkt->len), get_cmd_string(pkt->hdr.cmd));
              iwl_print_hex_dump(priv, IWL_DL_RADIO, pkt->u.raw, le32_to_cpu(pkt->len)
      );
      }
      EXPORT_SYMBOL(iwl_rx_pm_debug_statistics_notif);
      
      Given the rampant misuse of this field without proper masking throughout the
      driver (every use but one), this patch renames the field from 'len' to
      'len_n_flags' to reduce confusion.  It also adds the proper masking when
      this field is used as a length value.
      Signed-off-by: NDaniel C Halperin <daniel.c.halperin@intel.com>
      Signed-off-by: NReinette Chatre <reinette.chatre@intel.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      396887a2
    • D
      iwlwifi: refactor packet reception code · 9f30e04e
      Daniel C Halperin 提交于
      This patch fixes a number of issues in iwl_rx_reply_rx and
      iwl_pass_packet_to_mac80211.  These issues stem from the complexities of
      managing two different types of packet commands for different hardware.
      
      - Unify code handling rx_phy_res in SKB or cached to eliminate redundancy and
      remove potential NULL pointer accesses
      - Replace magic number with proper constant
      - Optimize functions by moving early exit conditions before computation
      - Comment code and improve some variable names
      - Remove redundant computation in iwl_pass_packet_to_mac80211 by passing in the
      correct, already-computed arguments.
      Signed-off-by: NDaniel C Halperin <daniel.c.halperin@intel.com>
      Signed-off-by: NReinette Chatre <reinette.chatre@intel.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      9f30e04e