1. 03 2月, 2006 1 次提交
    • H
      [IPV6]: Don't hold extra ref count in ipv6_ifa_notify · 4641e7a3
      Herbert Xu 提交于
      Currently the logic in ipv6_ifa_notify is to hold an extra reference
      count for addrconf dst's that get added to the routing table.  Thus,
      when addrconf dst entries are taken out of the routing table, we need
      to drop that dst.  However, addrconf dst entries may be removed from
      the routing table by means other than __ipv6_ifa_notify.
      
      So we're faced with the choice of either fixing up all places where
      addrconf dst entries are removed, or dropping the extra reference count
      altogether.
      
      I chose the latter because the ifp itself always holds a dst reference
      count of 1 while it's alive.  This is dropped just before we kfree the
      ifp object.  Therefore we know that in __ipv6_ifa_notify we will always
      hold that count.
      
      This bug was found by Eric W. Biederman.
      Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      4641e7a3
  2. 17 1月, 2006 1 次提交
  3. 14 1月, 2006 1 次提交
    • J
      [NET]: Use NIP6_FMT in kernel.h · 46b86a2d
      Joe Perches 提交于
      There are errors and inconsistency in the display of NIP6 strings.
      	ie: net/ipv6/ip6_flowlabel.c
      
      There are errors and inconsistency in the display of NIPQUAD strings too.
      	ie: net/netfilter/nf_conntrack_ftp.c
      
      This patch:
      	adds NIP6_FMT to kernel.h
      	changes all code to use NIP6_FMT
      	fixes net/ipv6/ip6_flowlabel.c
      	adds NIPQUAD_FMT to kernel.h
      	fixes net/netfilter/nf_conntrack_ftp.c
      	changes a few uses of "%u.%u.%u.%u" to NIPQUAD_FMT for symmetry to NIP6_FMT
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      46b86a2d
  4. 12 1月, 2006 1 次提交
  5. 08 1月, 2006 1 次提交
  6. 04 1月, 2006 1 次提交
  7. 28 12月, 2005 1 次提交
  8. 24 12月, 2005 2 次提交
  9. 22 12月, 2005 1 次提交
    • K
      [IPV6]: Fix address deletion · 1d142804
      Kristian Slavov 提交于
      If you add more than one IPv6 address belonging to the same prefix and 
      delete the address that was last added, routing table entry for that 
      prefix is also deleted.
      Tested on 2.6.14.4
      
      To reproduce:
      ip addr add 3ffe::1/64 dev eth0
      ip addr add 3ffe::2/64 dev eth0
      /* wait DAD */
      sleep 1
      ip addr del 3ffe::2/64 dev eth0
      ip -6 route
      
      (route to 3ffe::/64 should be gone)
      
      In ipv6_del_addr(), if ifa == ifp, we set ifa->if_next to NULL, and later 
      assign ifap = &ifa->if_next, effectively terminating the for-loop.
      This prevents us from checking if there are other addresses using the same 
      prefix that are valid, and thus resulting in deletion of the prefix.
      This applies only if the first entry in idev->addr_list is the address to 
      be deleted.
      Signed-off-by: NKristian Slavov <kristian.slavov@nomadiclab.com>
      Acked-by: NYOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      1d142804
  10. 21 12月, 2005 3 次提交
  11. 20 12月, 2005 1 次提交
    • Y
      [IPV6]: Fix route lifetime. · 3dd4bc68
      YOSHIFUJI Hideaki 提交于
      The route expiration time is stored in rt6i_expires in jiffies.
      The argument of rt6_route_add() for adding a route is not the
      expiration time in jiffies nor in clock_t, but the lifetime
      (or time left before expiration) in clock_t.
      
      Because of the confusion, we sometimes saw several strange errors
      (FAILs) in TAHI IPv6 Ready Logo Phase-2 Self Test.
      The symptoms were analyzed by Mitsuru Chinen <CHINEN@jp.ibm.com>.
      Signed-off-by: NYOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      3dd4bc68
  12. 14 12月, 2005 1 次提交
  13. 29 11月, 2005 1 次提交
  14. 21 11月, 2005 1 次提交
  15. 15 11月, 2005 1 次提交
  16. 10 11月, 2005 1 次提交
  17. 09 11月, 2005 3 次提交
  18. 03 11月, 2005 1 次提交
  19. 30 10月, 2005 1 次提交
  20. 04 10月, 2005 1 次提交
    • H
      [IPV4]: Replace __in_dev_get with __in_dev_get_rcu/rtnl · e5ed6399
      Herbert Xu 提交于
      The following patch renames __in_dev_get() to __in_dev_get_rtnl() and
      introduces __in_dev_get_rcu() to cover the second case.
      
      1) RCU with refcnt should use in_dev_get().
      2) RCU without refcnt should use __in_dev_get_rcu().
      3) All others must hold RTNL and use __in_dev_get_rtnl().
      
      There is one exception in net/ipv4/route.c which is in fact a pre-existing
      race condition.  I've marked it as such so that we remember to fix it.
      
      This patch is based on suggestions and prior work by Suzanne Wood and
      Paul McKenney.
      Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      e5ed6399
  21. 27 9月, 2005 1 次提交
  22. 10 9月, 2005 1 次提交
  23. 02 9月, 2005 1 次提交
    • J
      [CRYPTO]: crypto_free_tfm() callers no longer need to check for NULL · 573dbd95
      Jesper Juhl 提交于
      Since the patch to add a NULL short-circuit to crypto_free_tfm() went in,
      there's no longer any need for callers of that function to check for NULL.
      This patch removes the redundant NULL checks and also a few similar checks
      for NULL before calls to kfree() that I ran into while doing the
      crypto_free_tfm bits.
      
      I've succesfuly compile tested this patch, and a kernel with the patch 
      applied boots and runs just fine.
      
      When I posted the patch to LKML (and other lists/people on Cc) it drew the
      following comments :
      
       J. Bruce Fields commented
        "I've no problem with the auth_gss or nfsv4 bits.--b."
      
       Sridhar Samudrala said
        "sctp change looks fine."
      
       Herbert Xu signed off on the patch.
      
      So, I guess this is ready to be dropped into -mm and eventually mainline.
      Signed-off-by: NJesper Juhl <jesper.juhl@gmail.com>
      Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      573dbd95
  24. 30 8月, 2005 4 次提交
  25. 29 6月, 2005 3 次提交
  26. 24 6月, 2005 1 次提交
  27. 22 6月, 2005 1 次提交
  28. 19 6月, 2005 3 次提交