1. 18 12月, 2015 2 次提交
  2. 17 12月, 2015 1 次提交
  3. 14 12月, 2015 1 次提交
  4. 14 5月, 2015 1 次提交
    • N
      perf report: Fix some option handling on --stdio · 4fd113b5
      Namhyung Kim 提交于
      There's a bug that perf report sometimes ignore some options on --stdio
      output.  This bug is triggered only if a related config variable is set.
      For example, let's assume we have a following config file.
      
        $ cat ~/.perfconfig
        [call-graph]
          print-type = graph
        [hist]
          percentage = absolute
      
      Then, following perf config will not honor some options.
      
        $ perf record -ag sleep 1
        [ perf record: Woken up 1 times to write data ]
        [ perf record: Captured and wrote 0.199 MB perf.data (77 samples) ]
      
        $ perf report -g none --stdio
        # To display the perf.data header info, please use --header/--header-only options.
        #
        # Samples: 77  of event 'cycles'
        # Event count (approx.): 25425383
        #
        # Overhead  Command          Shared Object            Symbol
        # ........  ...............  .......................  ..............
        #
            16.34%  swapper          [kernel.vmlinux]         [k] intel_idle
                            |
                            ---intel_idle
                               cpuidle_enter_state
                               cpuidle_enter
                               cpu_startup_entry
         ...
      
      With '-g none' option, it should not show callchains, but it still shows
      callchains.  However it works as expected on --tui output.
      
      Similarly, '--percentage relative' option is not work and still shows a
      absolute percentage values.
      
      Looking at the source, I found that those setting were overwritten by
      config variables when setup_pager() called.  The setup_pager() is to
      start a pager process so that it can manage long lines of output on the
      stdio mode.  But as it calls the perf_config() after parsing arguments,
      the settings were overwritten regardless of command line options.
      
      The reason it calls perf_config() is to find the 'pager_program' which
      might be set by a config variable, I guess.  However current perf code
      does not provide the config variable for it, so it's just meaningless
      IMHO.  Eliminating the call makes the option working as expected.
      Signed-off-by: NNamhyung Kim <namhyung@kernel.org>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Taeung Song <treeze.taeung@gmail.com>
      Link: http://lkml.kernel.org/r/1431529406-6762-1-git-send-email-namhyung@kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      4fd113b5
  5. 21 5月, 2014 1 次提交
  6. 31 5月, 2012 1 次提交
  7. 27 6月, 2009 1 次提交
    • I
      perf_counter tools: Remove dead code · fde953c1
      Ingo Molnar 提交于
      Vince Weaver reported that there's a handful of #ifdef __MINGW32__
      sections in the code.
      
      Remove them as they are in essence dead code - as unlike upstream
      Git, the perf tool is unlikely to be ported to Windows.
      Reported-by: NVince Weaver <vince@deater.net>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      LKML-Reference: <new-submission>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      fde953c1
  8. 07 6月, 2009 1 次提交
  9. 27 5月, 2009 1 次提交
    • I
      perf_counter tools: Add built-in pager support · a930d2c0
      Ingo Molnar 提交于
      Add Git's pager.c (and sigchain) code. A command only
      has to call setup_pager() to get paged interactive
      output.
      
      Non-interactive (redirected, command-piped, etc.) uses
      are not affected.
      
      Update perf-report to make use of this.
      
      [ Impact: new feature ]
      
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
      Cc: Marcelo Tosatti <mtosatti@redhat.com>
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: John Kacur <jkacur@redhat.com>
      LKML-Reference: <new-submission>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      a930d2c0