1. 28 2月, 2012 1 次提交
  2. 31 7月, 2010 1 次提交
  3. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  4. 08 3月, 2010 1 次提交
  5. 27 3月, 2009 1 次提交
  6. 21 3月, 2009 2 次提交
    • A
      PCI Hotplug: rename legacy_fakephp to fakephp · 8ffd2545
      Alex Chiang 提交于
      We wanted to replace fakephp wholesale, so rename legacy_fakephp back
      to fakephp. Yes, this is a silly commit, but it produces a much easier
      patch to read and review.
      Signed-off-by: NAlex Chiang <achiang@hp.com>
      Signed-off-by: NJesse Barnes <jbarnes@virtuousgeek.org>
      8ffd2545
    • T
      PCI Hotplug: restore fakephp interface with complete reimplementation · 83dbf66f
      Trent Piepho 提交于
      A complete re-implementation of fakephp is necessary if it is to
      present its former interface (pre-2.6.27, when it broke). The
      reason is that PCI hotplug drivers call pci_hp_register(), which
      enforces the rule that only one /sys/bus/pci/slots/ file may be
      created per physical slot.
      
      The change breaks the old fakephp's assumption that it could
      create a file per function. So we re-implement fakephp to avoid
      using the standard PCI hotplug API so that we can restore the old
      fakephp user interface.
      
      It puts entries in /sys/bus/pci/slots with the names of all PCI
      devices/functions, exactly symmetrical to what is shown in
      /sys/bus/pci/devices. Each slots/ entry has a "power" attribute,
      which works the same way as the fakephp driver's power attribute
      has worked.
      
      There are a few improvements over old fakephp, which couldn't handle
      PCI devices being added or removed via a means outside of
      fakephp's knowledge.  If a device was added another way, old fakephp
      didn't notice and didn't create the fake slot for it.  If a
      device was removed another way, old fakephp didn't delete the fake
      slot for it (and accessing the stale slot caused an oops).
      
      The new implementation overcomes these limitations. As a
      consequence, removing a bridge with other devices behind it now
      works as well, which is something else old fakephp couldn't do
      previously.
      
      This duplicates a tiny bit of the code in the PCI core that does
      this same function.  Re-using that code ends up being more
      complex than duplicating it, and it makes code in the PCI core
      more ugly just to support this legacy fakephp interface
      compatibility layer.
      Reviewed-by: NJames Cameron <qz@hp.com>
      Signed-off-by: NTrent Piepho <xyzzy@speakeasy.org>
      Signed-off-by: NAlex Chiang <achiang@hp.com>
      Signed-off-by: NJesse Barnes <jbarnes@virtuousgeek.org>
      83dbf66f