1. 04 12月, 2012 1 次提交
  2. 07 6月, 2012 1 次提交
    • J
      ethernet: Remove casts to same type · 64699336
      Joe Perches 提交于
      Adding casts of objects to the same type is unnecessary
      and confusing for a human reader.
      
      For example, this cast:
      
              int y;
              int *p = (int *)&y;
      
      I used the coccinelle script below to find and remove these
      unnecessary casts.  I manually removed the conversions this
      script produces of casts with __force, __iomem and __user.
      
      @@
      type T;
      T *p;
      @@
      
      -       (T *)p
      +       p
      
      A function in atl1e_main.c was passed a const pointer
      when it actually modified elements of the structure.
      
      Change the argument to a non-const pointer.
      
      A function in stmmac needed a __force to avoid a sparse
      warning.  Added it.
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      64699336
  3. 29 3月, 2012 1 次提交
  4. 07 2月, 2012 1 次提交
  5. 01 2月, 2012 1 次提交
  6. 18 8月, 2011 1 次提交
  7. 11 8月, 2011 1 次提交
    • J
      amd: Move AMD (Lance) chipset drivers · b955f6ca
      Jeff Kirsher 提交于
      Moves the drivers for the AMD chipsets into drivers/net/ethernet/amd/
      and the necessary Kconfig and Makfile changes.
      
      The au1000 (Alchemy) driver was also moved into the same directory
      even though it is not a "Lance" driver.
      
      CC: Peter Maydell <pmaydell@chiark.greenend.org.uk>
      CC: Roman Hodek <Roman.Hodek@informatik.uni-erlangen.de>
      CC: "Maciej W. Rozycki" <macro@linux-mips.org>
      CC: Donald Becker <becker@scyld.com>
      CC: Sam Creasey <sammy@users.qual.net>
      CC: Miguel de Icaza <miguel@nuclecu.unam.mx>
      CC: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
      CC: Don Fry <pcnet32@frontier.com>
      CC: Geert Uytterhoeven <geert@linux-m68k.org>
      CC: Russell King <linux@arm.linux.org.uk>
      CC: David Davies <davies@maniac.ultranet.com>
      CC: "M.Hipp" <hippm@informatik.uni-tuebingen.de>
      CC: Pete Popov <ppopov@embeddedalley.com>
      CC: David Hinds <dahinds@users.sourceforge.net>
      CC: "Roger C. Pao" <rpao@paonet.org>
      Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>
      b955f6ca
  8. 09 7月, 2011 1 次提交
  9. 22 6月, 2011 1 次提交
  10. 26 8月, 2010 1 次提交
  11. 27 7月, 2010 1 次提交
    • R
      NET: declance: Fix section mismatches · 3852cc33
      Ralf Baechle 提交于
      WARNING: drivers/net/built-in.o(.data+0x24): Section mismatch in reference from
      the variable dec_lance_tc_driver to the function .init.text:dec_lance_tc_probe()
      The variable dec_lance_tc_driver references
      the function __init dec_lance_tc_probe()
      If the reference is valid then annotate the
      variable with __init* or __refdata (see linux/init.h) or name the variable:
      *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
      
      Fixing this one results in a new mismatch:
      
      WARNING: drivers/net/built-in.o(.devinit.text+0x14): Section mismatch in reference from the function dec_lance_tc_probe() to the function .init.text:dec_lance_probe()
      The function __devinit dec_lance_tc_probe() references
      a function __init dec_lance_probe().
      If dec_lance_probe is only used by dec_lance_tc_probe then
      annotate dec_lance_probe with a matching annotation.
      Signed-off-by: NRalf Baechle <ralf@linux-mips.org>
      3852cc33
  12. 14 5月, 2010 1 次提交
    • J
      drivers/net: Remove unnecessary returns from void function()s · a4b77097
      Joe Perches 提交于
      This patch removes from drivers/net/ all the unnecessary
      return; statements that precede the last closing brace of
      void functions.
      
      It does not remove the returns that are immediately
      preceded by a label as gcc doesn't like that.
      
      It also does not remove null void functions with return.
      
      Done via:
      $ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
        xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'
      
      with some cleanups by hand.
      
      Compile tested x86 allmodconfig only.
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      a4b77097
  13. 10 5月, 2010 1 次提交
  14. 04 4月, 2010 1 次提交
    • J
      net: convert multicast list to list_head · 22bedad3
      Jiri Pirko 提交于
      Converts the list and the core manipulating with it to be the same as uc_list.
      
      +uses two functions for adding/removing mc address (normal and "global"
       variant) instead of a function parameter.
      +removes dev_mcast.c completely.
      +exposes netdev_hw_addr_list_* macros along with __hw_addr_* functions for
       manipulation with lists on a sandbox (used in bonding and 80211 drivers)
      Signed-off-by: NJiri Pirko <jpirko@redhat.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      22bedad3
  15. 18 2月, 2010 1 次提交
  16. 13 2月, 2010 1 次提交
  17. 19 11月, 2009 1 次提交
  18. 06 7月, 2009 1 次提交
  19. 08 6月, 2009 1 次提交
    • M
      declance: Restore tx descriptor ring locking · 963267bc
      Maciej W. Rozycki 提交于
      A driver overhaul on 29 Feb 2000 (!) broke locking around fiddling with 
      the tx descriptor ring in start_xmit(); a follow-on "fix" removed the 
      broken remnants altogether.  Here's a patch to restore proper locking in 
      the function -- the complement in the interrupt handler has been correct 
      all the time.
      
       This *may* have been the reason for the occasional confusion of the chip 
      -- triggering a tx timeout followed by a chip reset sequence -- seen on 
      R4k-based DECstations with the onboard Ethernet interface.  Another theory 
      is the confusion is due to an unindentified problem -- perhaps a silicon 
      erratum -- associated with the variation of the MT ASIC used to interface 
      the R4k CPU to the rest of the system on these computers; with its 
      aggressive write-back buffering the design is particularly weakly ordered 
      when it comes to MMIO (in the absence of ordering barriers uncached reads 
      are allowed to bypass earlier uncached writes, even if to the same 
      location), which may trigger all kinds of corner cases in peripheral 
      hardware as well as software.
      
      Either way this piece of code is buggy.
      Signed-off-by: NMaciej W. Rozycki <macro@linux-mips.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      963267bc
  20. 15 4月, 2009 1 次提交
  21. 25 3月, 2009 1 次提交
  22. 27 1月, 2009 1 次提交
  23. 13 11月, 2008 1 次提交
    • W
      netdevice: safe convert to netdev_priv() #part-2 · 4cf1653a
      Wang Chen 提交于
      We have some reasons to kill netdev->priv:
      1. netdev->priv is equal to netdev_priv().
      2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously
         netdev_priv() is more flexible than netdev->priv.
      But we cann't kill netdev->priv, because so many drivers reference to it
      directly.
      
      This patch is a safe convert for netdev->priv to netdev_priv(netdev).
      Since all of the netdev->priv is only for read.
      But it is too big to be sent in one mail.
      I split it to 4 parts and make every part smaller than 100,000 bytes,
      which is max size allowed by vger.
      Signed-off-by: NWang Chen <wangchen@cn.fujitsu.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      4cf1653a
  24. 04 11月, 2008 1 次提交
  25. 28 10月, 2008 1 次提交
  26. 12 6月, 2008 1 次提交
  27. 29 1月, 2008 1 次提交
    • J
      [netdrvr] irq handler minor cleanups in several drivers · 28fc1f5a
      Jeff Garzik 提交于
      * use irq_handler_t where appropriate
      
      * no need to use 'irq' function arg, its already stored in a data struct
      
      * rename irq handler 'irq' argument to 'dummy', where the function
        has been analyzed and proven not to use its first argument.
      
      * remove always-false "dev_id == NULL" test from irq handlers
      
      * remove pointless casts from void*
      
      * declance: irq argument is not const
      
      * add KERN_xxx printk prefix
      
      * fix minor whitespace weirdness
      Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
      28fc1f5a
  28. 11 10月, 2007 2 次提交
  29. 22 5月, 2007 1 次提交
  30. 26 4月, 2007 1 次提交
  31. 08 2月, 2007 1 次提交
  32. 05 12月, 2006 2 次提交
  33. 07 10月, 2006 1 次提交
  34. 05 10月, 2006 1 次提交
    • D
      IRQ: Maintain regs pointer globally rather than passing to IRQ handlers · 7d12e780
      David Howells 提交于
      Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
      of passing regs around manually through all ~1800 interrupt handlers in the
      Linux kernel.
      
      The regs pointer is used in few places, but it potentially costs both stack
      space and code to pass it around.  On the FRV arch, removing the regs parameter
      from all the genirq function results in a 20% speed up of the IRQ exit path
      (ie: from leaving timer_interrupt() to leaving do_IRQ()).
      
      Where appropriate, an arch may override the generic storage facility and do
      something different with the variable.  On FRV, for instance, the address is
      maintained in GR28 at all times inside the kernel as part of general exception
      handling.
      
      Having looked over the code, it appears that the parameter may be handed down
      through up to twenty or so layers of functions.  Consider a USB character
      device attached to a USB hub, attached to a USB controller that posts its
      interrupts through a cascaded auxiliary interrupt controller.  A character
      device driver may want to pass regs to the sysrq handler through the input
      layer which adds another few layers of parameter passing.
      
      I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
      main part of the code on FRV and i386, though I can't test most of the drivers.
      I've also done partial conversion for powerpc and MIPS - these at least compile
      with minimal configurations.
      
      This will affect all archs.  Mostly the changes should be relatively easy.
      Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
      
      	struct pt_regs *old_regs = set_irq_regs(regs);
      
      And put the old one back at the end:
      
      	set_irq_regs(old_regs);
      
      Don't pass regs through to generic_handle_irq() or __do_IRQ().
      
      In timer_interrupt(), this sort of change will be necessary:
      
      	-	update_process_times(user_mode(regs));
      	-	profile_tick(CPU_PROFILING, regs);
      	+	update_process_times(user_mode(get_irq_regs()));
      	+	profile_tick(CPU_PROFILING);
      
      I'd like to move update_process_times()'s use of get_irq_regs() into itself,
      except that i386, alone of the archs, uses something other than user_mode().
      
      Some notes on the interrupt handling in the drivers:
      
       (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
           the input_dev struct.
      
       (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
           something different depending on whether it's been supplied with a regs
           pointer or not.
      
       (*) Various IRQ handler function pointers have been moved to type
           irq_handler_t.
      Signed-Off-By: NDavid Howells <dhowells@redhat.com>
      (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
      7d12e780
  35. 14 9月, 2006 1 次提交
  36. 06 7月, 2006 1 次提交
  37. 01 7月, 2006 1 次提交
  38. 23 6月, 2006 1 次提交
    • H
      [NET]: Avoid allocating skb in skb_pad · 5b057c6b
      Herbert Xu 提交于
      First of all it is unnecessary to allocate a new skb in skb_pad since
      the existing one is not shared.  More importantly, our hard_start_xmit
      interface does not allow a new skb to be allocated since that breaks
      requeueing.
      
      This patch uses pskb_expand_head to expand the existing skb and linearize
      it if needed.  Actually, someone should sift through every instance of
      skb_pad on a non-linear skb as they do not fit the reasons why this was
      originally created.
      
      Incidentally, this fixes a minor bug when the skb is cloned (tcpdump,
      TCP, etc.).  As it is skb_pad will simply write over a cloned skb.  Because
      of the position of the write it is unlikely to cause problems but still
      it's best if we don't do it.
      Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      5b057c6b