1. 29 12月, 2009 6 次提交
    • J
      mac80211: proper bss private data handling · 0c1ad2ca
      Johannes Berg 提交于
      cfg80211 offers private data for each BSS struct,
      which mac80211 uses. However, mac80211 uses internal
      and external (cfg80211) BSS pointers interchangeably
      and has a hack to put the cfg80211 bss struct into
      the private struct.
      
      Remove this hack, properly converting between the
      pointers wherever necessary.
      Signed-off-by: NJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      0c1ad2ca
    • J
      mac80211: split up and insert custom IEs correctly · 8e664fb3
      Johannes Berg 提交于
      Currently, we insert all user-specified IEs before the HT
      IE for association, and after the HT IE for probe requests.
      For association, that's correct only if the user-specified
      IEs are RSN only, incorrect in all other cases including
      WPA. Change this to split apart the user-specified IEs in
      two places for association: before the HT IE (e.g. RSN),
      after the HT IE (generally empty right now I think?) and
      after WMM (all other vendor-specific IEs). For probes,
      split the IEs in different places to be correct according
      to the spec.
      Signed-off-by: NJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      8e664fb3
    • J
      mac80211: generalise work handling · af6b6374
      Johannes Berg 提交于
      In order to use auth/assoc for different purposes
      other than MLME, it needs to be split up. For other
      purposes, a generic work handling (potentially on
      another channel) will be useful.
      
      To achieve that, this patch moves much of the MLME
      work handling out of mlme into a new work API. The
      API can currently handle probing a specific AP,
      authentication and association. The MLME previously
      handled probe/authentication as one step and will
      continue to do so, but they are separate in the new
      work handling.
      
      Work items are RCU-managed to be able to check for
      existence of an item for a specific frame in the RX
      path, but they can be re-used which the MLME right
      now will do for its combined probe/auth step.
      Signed-off-by: NJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      af6b6374
    • J
      mac80211: generalise management work a bit · f679f65d
      Johannes Berg 提交于
      As a first step of generalising management work,
      this renames a few things and puts more information
      directly into the struct so that auth/assoc need
      not access the BSS pointer as often -- in fact it
      can be removed from auth completely. Also since the
      previous patch made sure a new work item is used
      for association, we can make the different data a
      union.
      Signed-off-by: NJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      f679f65d
    • J
      mac80211: let cfg80211 manage auth state · 63f170e0
      Johannes Berg 提交于
      mac80211 currently hangs on to the auth state by
      keeping it on the work list. That can lead to
      confusing behaviour like rejecting scans while
      authenticated to any AP (but not yet associated.)
      It also means that it needs to keep track of the
      work struct while associated for when it gets
      disassociated (or disassociates.)
      
      Change this to free the work struct after the
      authentication completed successfully and
      allocate a new one for associating, thereby
      letting cfg80211 manage the auth state. Another
      change necessary for this is to tell cfg80211
      about all unicast deauth frames sent to mac80211
      since now it can no longer check the auth state,
      but that check was racy anyway.
      Signed-off-by: NJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      63f170e0
    • J
      mac80211: add ieee80211_sdata_running · 9607e6b6
      Johannes Berg 提交于
      Instead of always using netif_running(sdata->dev)
      use ieee80211_sdata_running(sdata) now which is
      just an inline containing netif_running() for now.
      Signed-off-by: NJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      9607e6b6
  2. 23 12月, 2009 2 次提交
  3. 22 12月, 2009 1 次提交
    • J
      mac80211: reduce reliance on netdev · 47846c9b
      Johannes Berg 提交于
      For bluetooth 3, we will most likely not have
      a netdev for a virtual interface (sdata), so
      prepare for that by reducing the reliance on
      having a netdev. This patch moves the name
      and address fields into the sdata struct and
      uses them from there all over. Some work is
      needed to keep them sync'ed, but that's not
      a lot of work and in slow paths anyway.
      
      In doing so, this also reduces the number of
      pointer dereferences in many places, because
      of things like sdata->dev->dev_addr becoming
      sdata->vif.addr.
      Signed-off-by: NJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      47846c9b
  4. 08 12月, 2009 1 次提交
  5. 01 12月, 2009 1 次提交
    • J
      mac80211: fix spurious delBA handling · 827d42c9
      Johannes Berg 提交于
      Lennert Buytenhek noticed that delBA handling in mac80211
      was broken and has remotely triggerable problems, some of
      which are due to some code shuffling I did that ended up
      changing the order in which things were done -- this was
      
        commit d75636ef
        Author: Johannes Berg <johannes@sipsolutions.net>
        Date:   Tue Feb 10 21:25:53 2009 +0100
      
          mac80211: RX aggregation: clean up stop session
      
      and other parts were already present in the original
      
        commit d92684e6
        Author: Ron Rindjunsky <ron.rindjunsky@intel.com>
        Date:   Mon Jan 28 14:07:22 2008 +0200
      
            mac80211: A-MPDU Tx add delBA from recipient support
      
      The first problem is that I moved a BUG_ON before various
      checks -- thereby making it possible to hit. As the comment
      indicates, the BUG_ON can be removed since the ampdu_action
      callback must already exist when the state is != IDLE.
      
      The second problem isn't easily exploitable but there's a
      race condition due to unconditionally setting the state to
      OPERATIONAL when a delBA frame is received, even when no
      aggregation session was ever initiated. All the drivers
      accept stopping the session even then, but that opens a
      race window where crashes could happen before the driver
      accepts it. Right now, a WARN_ON may happen with non-HT
      drivers, while the race opens only for HT drivers.
      
      For this case, there are two things necessary to fix it:
       1) don't process spurious delBA frames, and be more careful
          about the session state; don't drop the lock
      
       2) HT drivers need to be prepared to handle a session stop
          even before the session was really started -- this is
          true for all drivers (that support aggregation) but
          iwlwifi which can be fixed easily. The other HT drivers
          (ath9k and ar9170) are behaving properly already.
      Reported-by: NLennert Buytenhek <buytenh@marvell.com>
      Cc: stable@kernel.org
      Signed-off-by: NJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      827d42c9
  6. 29 11月, 2009 2 次提交
  7. 24 11月, 2009 1 次提交
  8. 20 11月, 2009 2 次提交
    • J
      cfg80211: introduce capability for 4addr mode · 9bc383de
      Johannes Berg 提交于
      It's very likely that not many devices will support
      four-address mode in station or AP mode so introduce
      capability bits for both modes, set them in mac80211
      and check them when userspace tries to use the mode.
      Also, keep track of 4addr in cfg80211 (wireless_dev)
      and not in mac80211 any more. mac80211 can also be
      improved for the VLAN case by not looking at the
      4addr flag but maintaining the station pointer for
      it correctly. However, keep track of use_4addr for
      station mode in mac80211 to avoid all the derefs.
      Signed-off-by: NJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      9bc383de
    • J
      mac80211: fix resume · ceb99fe0
      Johannes Berg 提交于
      When mac80211 resumes, it currently first sets suspended
      to false so the driver can start doing things and we can
      receive frames.
      
      However, if we actually receive frames then it can end
      up starting some work which adds timers and then later
      runs into a BUG_ON in the timer code because it tries
      add_timer() on a pending timer.
      
      Fix this by keeping track of the resuming process by
      introducing a new variable 'resuming' which gets set to
      true early on instead of setting 'suspended' to false,
      and allow queueing work but not receiving frames while
      resuming.
      Reported-by: NMaxim Levitsky <maximlevitsky@gmail.com>
      Signed-off-by: NJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      ceb99fe0
  9. 19 11月, 2009 6 次提交
  10. 14 11月, 2009 3 次提交
  11. 12 11月, 2009 2 次提交
  12. 31 10月, 2009 3 次提交
    • J
      mac80211: remove sent_ps_buffered · ff9458d3
      Johannes Berg 提交于
      This variable is set once, and tested once.
      However, the code path that can set it is
      mutually exclusive with the code path that
      tests it, so the test is always true. Thus
      we also don't need to set it either and can
      just remove the variable.
      Signed-off-by: NJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      ff9458d3
    • J
      mac80211: split hardware scan by band · 4d36ec58
      Johannes Berg 提交于
      There's currently a very odd bug in mac80211 -- a
      hardware scan that is done while the hardware is
      really operating on 2.4 GHz will include CCK rates
      in the probe request frame, even on 5 GHz (if the
      driver uses the mac80211 IEs). Vice versa, if the
      hardware is operating on 5 GHz the 2.4 GHz probe
      requests will not include CCK rates even though
      they should.
      
      Fix this by splitting up cfg80211 scan requests by
      band -- recalculating the IEs every time -- and
      requesting only per-band scans from the driver.
      
      Apparently this bug hasn't been a problem yet, but
      it is imaginable that some older access points get
      confused if confronted with such behaviour.
      Signed-off-by: NJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      4d36ec58
    • J
      cfg80211/mac80211: use debugfs_remove_recursive · 7bcfaf2f
      Johannes Berg 提交于
      We can save a lot of code and pointers in the structs
      by using debugfs_remove_recursive().
      
      First, change cfg80211 to use debugfs_remove_recursive()
      so that drivers do not need to clean up any files they
      added to the per-wiphy debugfs (if and only if they are
      ok to be accessed until after wiphy_unregister!).
      
      Then also make mac80211 use debugfs_remove_recursive()
      where necessary -- it need not remove per-wiphy files
      as cfg80211 now removes those, but netdev etc. files
      still need to be handled but can now be removed without
      needing struct dentry pointers to all of them.
      Signed-off-by: NJohannes Berg <johannes@sipsolutions.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      7bcfaf2f
  13. 01 9月, 2009 1 次提交
  14. 29 8月, 2009 3 次提交
  15. 20 8月, 2009 2 次提交
  16. 14 8月, 2009 4 次提交