It is useful to remove IV/ICV from rtl88eu_mon_recv_hook().
Also unprotect_frame() will be very short without skb_(pull|trim).
Signed-off-by: NIvan Safonov <insafonov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

staging:r8188eu: use different mon_recv_decrypted() inside rtl88eu_mon_recv_hook() and rtl88eu_mon_xmit_hook().

Create mon_recv_decrypted_recv() to change rtl88eu_mon_recv_hook()
without affect to rtl88eu_mon_xmit_hook().
Signed-off-by: NIvan Safonov <insafonov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

staging:r8188eu: move IV/ICV trimming into decrypt() and also place it after rtl88eu_mon_recv_hook()

IV/ICV should be trimmed immediately after decoding
(this is a decryptor job).

Trim IV/ICV inside decrypt() for SW decrypted frames,
for HW decrypted - before rtl88eu_mon_recv_hook().

Adopt frames receive process to work without IV/ICV fields.
Signed-off-by: NIvan Safonov <insafonov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace CamelCase association_request_t and association_response_t
struct field names with underscores to comply with the standard kernel
coding style.
Signed-off-by: NJanusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: NTobin C. Harding <me@tobin.cc>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace CamelCase variable name with underscores to comply
with the standard kernel coding style.
Signed-off-by: NJanusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: NTobin C. Harding <me@tobin.cc>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace CamelCase struct field names with underscores to comply
with the standard kernel coding style.
Changed:
- maxDuration
- durRemaining
Signed-off-by: NJanusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: NTobin C. Harding <me@tobin.cc>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace CamelCase struct field names with underscores to comply
with the standard kernel coding style.
Changed:
- FhParms_t
- DsParms_t
- CfParms_t
- IbssParms_t
- ErpParams_t
Signed-off-by: NJanusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: NTobin C. Harding <me@tobin.cc>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace CamelCase struct field names with underscores to comply
with the standard kernel coding style.
Changed:
- dwellTime
- hopSet
- hopPattern
- hopIndex
Signed-off-by: NJanusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: NTobin C. Harding <me@tobin.cc>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace CamelCase fields of struct with underscores to comply
with the standard kernel coding style
Signed-off-by: NJanusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: NTobin C. Harding <me@tobin.cc>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Sparse spits out a warnings about __le16 and unsigned short assignment.
Change the type of size and event members of struct hostif_hdr
to __le16 and correct conversion to the proper cpu type.
Signed-off-by: NCezary Gapinski <gapalinux@gmail.com>
Reviewed-by: NTobin C. Harding <me@tobin.cc>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

To ensure the bss is always synchronized only call on basic rate
change.
Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The key table is not intialized correctly without this call.
Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com>
Cc: <stable@vger.kernel.org> # v3.17+
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

short time change needs to synchronize parameters in vnt_update_ifs so
a call to the function is always necessary.
Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Short slot time is controlled by mac80211 so there is no need to find
odfm rates.

Merge PK_TYPE_11B and PK_TYPE_11GA & PK_TYPE_11GB into one else and
switch on short slot time.
Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Split struct definition across multiple line to fit in the 80 characters
limit
Signed-off-by: NVincent Siles <vincent.siles@provenrun.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Splitting function calls across multiple lines to fit in the 80
characters limit
Signed-off-by: NVincent Siles <vincent.siles@provenrun.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Splitting functions signature across several lines to fin in the
80 characters limit
Signed-off-by: NVincent Siles <vincent.siles@provenrun.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Removing some '-' comments to fit in the 80 characters limit
Signed-off-by: NVincent Siles <vincent.siles@provenrun.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Removing empty line at the end of the file
Signed-off-by: NVincent Siles <vincent.siles@provenrun.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This addresses the following sparse warnings:

drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51: warning: incorrect type in assignment (different base types)
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51:    expected unsigned short [unsigned] [assigned] [usertype] ht_capa_info
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51:    got restricted __le16 const [usertype] cap_info
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2011:52: warning: incorrect type in assignment (different base types)
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2011:52:    expected unsigned short [unsigned] [assigned] [usertype] ht_ext_params
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2011:52:    got restricted __le16 const [usertype] extended_ht_cap_info
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2012:51: warning: incorrect type in assignment (different base types)
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2012:51:    expected unsigned int [unsigned] [assigned] [usertype] ht_tx_bf_cap
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2012:51:    got restricted __le32 const [usertype] tx_BF_cap_info
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2078:51: warning: incorrect type in assignment (different base types)
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2078:51:    expected unsigned short [unsigned] [assigned] [usertype] ht_capa_info
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2078:51:    got restricted __le16 const [usertype] cap_info
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2083:52: warning: incorrect type in assignment (different base types)
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2083:52:    expected unsigned short [unsigned] [assigned] [usertype] ht_ext_params
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2083:52:    got restricted __le16 const [usertype] extended_ht_cap_info
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2084:51: warning: incorrect type in assignment (different base types)
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2084:51:    expected unsigned int [unsigned] [assigned] [usertype] ht_tx_bf_cap
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2084:51:    got restricted __le32 const [usertype] tx_BF_cap_info

This is not the first attempt to address this problem:
    https://lkml.org/lkml/2017/3/7/808

First, the current code works because the final use of the
ht_capa values (in host_interface.c: WILC_HostIf_PackStaParam) packs them
into a buffer in little-endian format. Since this matches the byte-order of
struct ieee80211_ht_cap, all is seemingly well.

What the current code does not do, and what these warnings expose, is
clearly communicate what the fields in struct add_sta_param
represent -- values with a specific (little endian) byte order.
This will lead to problems if the values are ever actually used by the
host, and that host is not little endian.

The proposed change addresses this by embedding a
struct ieee80211_ht_cap into struct add_sta_param.  When the values
are later packed out, the newly embedded struct is copied directly
into the outbound buffer.  All 16 and 32 bit types are treated as
little endian and marked as such.  Future use of the values by the
host would still require conversion, or sparse would flag them again.

The following items are required for this to be correct:
    1.  The data is not currently used by the host.
    2.  struct ieee80211_ht_cap is packed.
    3.  The packing of the fields matches the order in
        struct ieee80211_ht_cap.

This is similar, I believe, to how the same data is handled in
marvell/mwifiex/11n.c.

Test-compiled/loaded against staging-next on x86_64
Test-compiled against staging-next for ARM.
Applied/built against staging-testing.

Testing consists of compilation for the above trees/targets, and a
sparse check, no functional testing.
Signed-off-by: NJason Litzinger <jlitzingerdev@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch warning:
WARNING: Prefer using '"%s...", __func__' to using 'INTERFACE'
Signed-off-by: NCraig Kewley <craigkewley@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The following commit fixes the following sparse report:

drivers/staging//unisys/visorhba/visorhba_main.c:660:29: warning: cast to restricted __le64

by casting readq (which is unsigned long on x86) to u64, as expected by the seq_printf call.
Signed-off-by: NMarcos Paulo de Souza <marcos.souza.org@gmail.com>
Acked-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Ensure checkpatch compliance
Signed-off-by: NJustin Vreeland <justin@jvreeland.com>
Reviewed-by: NBastien Nocera <hadess@hadess.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Ensure checkpatch compliance
Signed-off-by: NJustin Vreeland <justin@jvreeland.com>
Reviewed-by: NBastien Nocera <hadess@hadess.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix "(foo*)" should be "(foo *)"
Fix "foo * bar" should be "foo *bar"
Signed-off-by: NJustin Vreeland <justin@jvreeland.com>
Reviewed-by: NBastien Nocera <hadess@hadess.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Ensure checkpatch compliance
Signed-off-by: NJustin Vreeland <justin@jvreeland.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Enclosing macros with complex values ensures expression is evaluated as
expected.
Signed-off-by: NJustin Vreeland <justin@jvreeland.com>
Reviewed-by: NBastien Nocera <hadess@hadess.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Wrapping in do-while ensures macros are executed as expected.
Signed-off-by: NJustin Vreeland <justin@jvreeland.com>
Reviewed-by: NBastien Nocera <hadess@hadess.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Do not initialize static to 0
Do not initialize static to false
Signed-off-by: NJustin Vreeland <justin@jvreeland.com>
Reviewed-by: NBastien Nocera <hadess@hadess.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixed coding style issue
Signed-off-by: NJaya Durga <rjdurga@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

checkpatch.pl reported errors for use of extra whitespaces
in the function prototypes.

Removed extra spaces to meet the coding standards.
Signed-off-by: NAdheer Chandravanshi <adheerchandravanshi@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Detected the follow errors by checkpatch.pl -f

	ERROR: spaces required around that '<'
	ERROR: space required after that ';'
Signed-off-by: NBingyu Zhou <rain.by.zhou@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch.pl warning:

CHECK: Alignment should match open parenthesis
+		fd = ion_alloc(data.allocation.len,
+						data.allocation.heap_id_mask,
Signed-off-by: NRichard Porter <dick@acm.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Checks reported by the checkpatch.pl scripts are resolved.
This patch contains trivial changes like alignment and trailing
whitespace removal
Signed-off-by: NJaikumar Dhanapal <jai_krpv@yahoo.co.in>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixed multiple checkpatch.pl issues regarding open brace placement,
else (after a brace) placement, unnecessary braces (single statement branches)
and space before closing brace.

To get the list of errors, the following command has been executed:
./scripts/checkpatch.pl --show-types --strict \
	--types=else_after_brace,open_brace,braces --terse \
 	-f drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
Signed-off-by: NFabrizio Perria <fabrizio.perria@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The commit 9304b5b0 ("staging: rtl8192u: Fix sparse warnings in r8192U_dm.c")
adds casting of le16 from cpu endianness. Therefore constructing
u4bAcParam potentially using big-endian order.
This patch converts the u4bAcParam parameter back to little-endian after
it has been constructed. Hence on big-endian architectures the parameter
will remain as little-endian.
Signed-off-by: NTuomo Rinne <tuomo.rinne@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Split the u4bAcParam parameter construction to multiple lines for easier
readability.
Signed-off-by: NTuomo Rinne <tuomo.rinne@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove scope unnecessary scope that is already enforced by the if
statements scope.
Signed-off-by: NTuomo Rinne <tuomo.rinne@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Wrapping "offset" in macro definition to resolve checkpatch issue, ie:
CHECK: Macro argument 'offset' may be better as '(offset)' to avoid
precedence issues
Signed-off-by: NMatthew Giassa <matthew@giassa.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Modified comment to resolve 80+ characters warning from checkpatch. ie:
WARNING: line over 80 characters

Warnings no longer present after change.
Signed-off-by: NMatthew Giassa <matthew@giassa.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>