提交 fa5f509f 编写于 作者: L Laxman Dewangan 提交者: Mark Brown

regulator: max8973: get rid of extra variable for gpio validity

To find that dvs-gpio is valid or not, gpio API gpio_is_valid()
can be directly used instead of intermediate variable.

Removing the extra variable and using the gpio_is_valid().
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: NMark Brown <broonie@kernel.org>
上级 eaacaa09
...@@ -100,7 +100,6 @@ struct max8973_chip { ...@@ -100,7 +100,6 @@ struct max8973_chip {
int curr_vout_val[MAX8973_MAX_VOUT_REG]; int curr_vout_val[MAX8973_MAX_VOUT_REG];
int curr_vout_reg; int curr_vout_reg;
int curr_gpio_val; int curr_gpio_val;
bool valid_dvs_gpio;
struct regulator_ops ops; struct regulator_ops ops;
}; };
...@@ -174,7 +173,7 @@ static int max8973_dcdc_set_voltage_sel(struct regulator_dev *rdev, ...@@ -174,7 +173,7 @@ static int max8973_dcdc_set_voltage_sel(struct regulator_dev *rdev,
* If gpios are available to select the VOUT register then least * If gpios are available to select the VOUT register then least
* recently used register for new configuration. * recently used register for new configuration.
*/ */
if (max->valid_dvs_gpio) if (gpio_is_valid(max->dvs_gpio))
found = find_voltage_set_register(max, vsel, found = find_voltage_set_register(max, vsel,
&vout_reg, &gpio_val); &vout_reg, &gpio_val);
...@@ -191,7 +190,7 @@ static int max8973_dcdc_set_voltage_sel(struct regulator_dev *rdev, ...@@ -191,7 +190,7 @@ static int max8973_dcdc_set_voltage_sel(struct regulator_dev *rdev,
} }
/* Select proper VOUT register vio gpios */ /* Select proper VOUT register vio gpios */
if (max->valid_dvs_gpio) { if (gpio_is_valid(max->dvs_gpio)) {
gpio_set_value_cansleep(max->dvs_gpio, gpio_val & 0x1); gpio_set_value_cansleep(max->dvs_gpio, gpio_val & 0x1);
max->curr_gpio_val = gpio_val; max->curr_gpio_val = gpio_val;
} }
...@@ -438,7 +437,6 @@ static int max8973_probe(struct i2c_client *client, ...@@ -438,7 +437,6 @@ static int max8973_probe(struct i2c_client *client,
max->dvs_gpio, ret); max->dvs_gpio, ret);
return ret; return ret;
} }
max->valid_dvs_gpio = true;
/* /*
* Initialize the lru index with vout_reg id * Initialize the lru index with vout_reg id
...@@ -448,8 +446,6 @@ static int max8973_probe(struct i2c_client *client, ...@@ -448,8 +446,6 @@ static int max8973_probe(struct i2c_client *client,
max->lru_index[i] = i; max->lru_index[i] = i;
max->lru_index[0] = max->curr_vout_reg; max->lru_index[0] = max->curr_vout_reg;
max->lru_index[max->curr_vout_reg] = 0; max->lru_index[max->curr_vout_reg] = 0;
} else {
max->valid_dvs_gpio = false;
} }
if (pdata) { if (pdata) {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册