提交 f70b359b 编写于 作者: D Dan Carpenter 提交者: Herbert Xu

crypto: chtls - use after free in chtls_pt_recvmsg()

We call chtls_free_skb() but then we dereference it on the next lines.
Also "skb" can't be NULL, we just dereferenced it on the line before.

I have moved the free down a couple lines to fix this issue.

Fixes: 17a7d24a ("crypto: chtls - generic handling of data and hdr")
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
上级 b268b350
...@@ -1548,15 +1548,14 @@ static int chtls_pt_recvmsg(struct sock *sk, struct msghdr *msg, size_t len, ...@@ -1548,15 +1548,14 @@ static int chtls_pt_recvmsg(struct sock *sk, struct msghdr *msg, size_t len,
tp->urg_data = 0; tp->urg_data = 0;
if ((avail + offset) >= skb->len) { if ((avail + offset) >= skb->len) {
if (likely(skb))
chtls_free_skb(sk, skb);
buffers_freed++;
if (ULP_SKB_CB(skb)->flags & ULPCB_FLAG_TLS_HDR) { if (ULP_SKB_CB(skb)->flags & ULPCB_FLAG_TLS_HDR) {
tp->copied_seq += skb->len; tp->copied_seq += skb->len;
hws->rcvpld = skb->hdr_len; hws->rcvpld = skb->hdr_len;
} else { } else {
tp->copied_seq += hws->rcvpld; tp->copied_seq += hws->rcvpld;
} }
chtls_free_skb(sk, skb);
buffers_freed++;
hws->copied_seq = 0; hws->copied_seq = 0;
if (copied >= target && if (copied >= target &&
!skb_peek(&sk->sk_receive_queue)) !skb_peek(&sk->sk_receive_queue))
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册