提交 f6194bcf 编写于 作者: D David B. Robins 提交者: David S. Miller

net: usb: asix: Fix crash on skb alloc failure

If asix_rx_fixup_internal() fails to allocate rx->ax_skb, it will return
but not clear rx->size. rx points to driver private data. A later call
assumes that nonzero size means ax_skb was allocated and passes a null
ax_skb to skb_put. Changed allocation failure return to clear size first.

Found testing board with AX88772B devices.
Signed-off-by: NDavid B. Robins <linux@davidrobins.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 74910ea4
...@@ -91,8 +91,10 @@ int asix_rx_fixup_internal(struct usbnet *dev, struct sk_buff *skb, ...@@ -91,8 +91,10 @@ int asix_rx_fixup_internal(struct usbnet *dev, struct sk_buff *skb,
} }
rx->ax_skb = netdev_alloc_skb_ip_align(dev->net, rx->ax_skb = netdev_alloc_skb_ip_align(dev->net,
rx->size); rx->size);
if (!rx->ax_skb) if (!rx->ax_skb) {
rx->size = 0;
return 0; return 0;
}
} }
if (rx->size > dev->net->mtu + ETH_HLEN + VLAN_HLEN) { if (rx->size > dev->net->mtu + ETH_HLEN + VLAN_HLEN) {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册