提交 e31cd782 编写于 作者: U Uwe Kleine-König 提交者: Sebastian Reichel

power_supply: bq24257: use flags argument of devm_gpiod_get

Since 39b2bbe3 (gpio: add flags argument to gpiod_get*() functions)
which appeared in v3.17-rc1, the gpiod_get* functions take an additional
parameter that allows to specify direction and initial value for output.

Simplify driver accordingly. Furthermore this is one caller less that
stops us making the flags argument to gpiod_get*() mandatory.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: NSebastian Reichel <sre@kernel.org>
上级 0007fa36
...@@ -608,31 +608,26 @@ static int bq24257_power_supply_init(struct bq24257_device *bq) ...@@ -608,31 +608,26 @@ static int bq24257_power_supply_init(struct bq24257_device *bq)
static int bq24257_irq_probe(struct bq24257_device *bq) static int bq24257_irq_probe(struct bq24257_device *bq)
{ {
int ret;
struct gpio_desc *stat_irq; struct gpio_desc *stat_irq;
stat_irq = devm_gpiod_get_index(bq->dev, BQ24257_STAT_IRQ, 0); stat_irq = devm_gpiod_get_index(bq->dev, BQ24257_STAT_IRQ, 0, GPIOD_IN);
if (IS_ERR(stat_irq)) { if (IS_ERR(stat_irq)) {
dev_err(bq->dev, "could not probe stat_irq pin\n"); dev_err(bq->dev, "could not probe stat_irq pin\n");
return PTR_ERR(stat_irq); return PTR_ERR(stat_irq);
} }
ret = gpiod_direction_input(stat_irq);
if (ret < 0)
return ret;
return gpiod_to_irq(stat_irq); return gpiod_to_irq(stat_irq);
} }
static int bq24257_pg_gpio_probe(struct bq24257_device *bq) static int bq24257_pg_gpio_probe(struct bq24257_device *bq)
{ {
bq->pg = devm_gpiod_get_index(bq->dev, BQ24257_PG_GPIO, 0); bq->pg = devm_gpiod_get_index(bq->dev, BQ24257_PG_GPIO, 0, GPIOD_IN);
if (IS_ERR(bq->pg)) { if (IS_ERR(bq->pg)) {
dev_err(bq->dev, "could not probe PG pin\n"); dev_err(bq->dev, "could not probe PG pin\n");
return PTR_ERR(bq->pg); return PTR_ERR(bq->pg);
} }
return gpiod_direction_input(bq->pg); return 0;
} }
static int bq24257_fw_probe(struct bq24257_device *bq) static int bq24257_fw_probe(struct bq24257_device *bq)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册