提交 c9e854cf 编写于 作者: J John Crispin

GPIO: MIPS: lantiq: fix overflow inside stp-xway driver

The driver was using a 16 bit field for storing the shadow value of the shift
register cascade. This resulted in only the first 2 shift registeres receiving
the correct data. The third shift register would always receive 0x00.

Fix this by using a 32bit field for the shadow value.
Signed-off-by: NJohn Crispin <blogic@openwrt.org>
Cc: linux-kernel@vger.kernel.org
上级 6a88a0f7
...@@ -82,7 +82,7 @@ struct xway_stp { ...@@ -82,7 +82,7 @@ struct xway_stp {
struct gpio_chip gc; struct gpio_chip gc;
void __iomem *virt; void __iomem *virt;
u32 edge; /* rising or falling edge triggered shift register */ u32 edge; /* rising or falling edge triggered shift register */
u16 shadow; /* shadow the shift registers state */ u32 shadow; /* shadow the shift registers state */
u8 groups; /* we can drive 1-3 groups of 8bit each */ u8 groups; /* we can drive 1-3 groups of 8bit each */
u8 dsl; /* the 2 LSBs can be driven by the dsl core */ u8 dsl; /* the 2 LSBs can be driven by the dsl core */
u8 phy1; /* 3 bits can be driven by phy1 */ u8 phy1; /* 3 bits can be driven by phy1 */
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册