提交 b01079be 编写于 作者: G Geliang Tang 提交者: Alexandre Belloni

rtc: fix module reference count in rtc-proc

rtc-proc.c is not built as a module. Thus, rather than dealing with
THIS_MODULE's reference count, we should deal with rtc->owner's
reference count.
Signed-off-by: NGeliang Tang <geliangtang@163.com>
Signed-off-by: NAlexandre Belloni <alexandre.belloni@free-electrons.com>
上级 fbbf53f7
...@@ -112,19 +112,21 @@ static int rtc_proc_open(struct inode *inode, struct file *file) ...@@ -112,19 +112,21 @@ static int rtc_proc_open(struct inode *inode, struct file *file)
int ret; int ret;
struct rtc_device *rtc = PDE_DATA(inode); struct rtc_device *rtc = PDE_DATA(inode);
if (!try_module_get(THIS_MODULE)) if (!try_module_get(rtc->owner))
return -ENODEV; return -ENODEV;
ret = single_open(file, rtc_proc_show, rtc); ret = single_open(file, rtc_proc_show, rtc);
if (ret) if (ret)
module_put(THIS_MODULE); module_put(rtc->owner);
return ret; return ret;
} }
static int rtc_proc_release(struct inode *inode, struct file *file) static int rtc_proc_release(struct inode *inode, struct file *file)
{ {
int res = single_release(inode, file); int res = single_release(inode, file);
module_put(THIS_MODULE); struct rtc_device *rtc = PDE_DATA(inode);
module_put(rtc->owner);
return res; return res;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册