提交 9fe172b9 编写于 作者: R Roger Quadros 提交者: Chanwoo Choi

extcon: palmas: Check the parent instance to prevent the NULL

extcon-palmas must be child of palmas and expects parent's
drvdata to be valid. Check for non NULL parent drvdata and
fail if it is NULL. Not doing so will result in a NULL
pointer dereference later in the probe() parent drvdata
is NULL (e.g. misplaced extcon-palmas node in device tree).
Signed-off-by: NRoger Quadros <rogerq@ti.com>
Signed-off-by: NChanwoo Choi <cw00.choi@samsung.com>
上级 af57fa4d
...@@ -190,6 +190,11 @@ static int palmas_usb_probe(struct platform_device *pdev) ...@@ -190,6 +190,11 @@ static int palmas_usb_probe(struct platform_device *pdev)
struct palmas_usb *palmas_usb; struct palmas_usb *palmas_usb;
int status; int status;
if (!palmas) {
dev_err(&pdev->dev, "failed to get valid parent\n");
return -EINVAL;
}
palmas_usb = devm_kzalloc(&pdev->dev, sizeof(*palmas_usb), GFP_KERNEL); palmas_usb = devm_kzalloc(&pdev->dev, sizeof(*palmas_usb), GFP_KERNEL);
if (!palmas_usb) if (!palmas_usb)
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册