提交 91c5d67f 编写于 作者: D Dmitry Torokhov

Input: tca8418_keypad - increase severity of failures in probe()

Failures to build a keymap, request an IRQ, or register input device are
fatal for the driver, therefore the messages should have "error" severity
instead of "debug".
Reviewed-by: NAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
上级 5cc0dfe0
...@@ -348,7 +348,7 @@ static int tca8418_keypad_probe(struct i2c_client *client, ...@@ -348,7 +348,7 @@ static int tca8418_keypad_probe(struct i2c_client *client,
error = matrix_keypad_build_keymap(keymap_data, NULL, rows, cols, error = matrix_keypad_build_keymap(keymap_data, NULL, rows, cols,
keypad_data->keymap, input); keypad_data->keymap, input);
if (error) { if (error) {
dev_dbg(dev, "Failed to build keymap\n"); dev_err(dev, "Failed to build keymap\n");
goto fail2; goto fail2;
} }
...@@ -367,14 +367,14 @@ static int tca8418_keypad_probe(struct i2c_client *client, ...@@ -367,14 +367,14 @@ static int tca8418_keypad_probe(struct i2c_client *client,
IRQF_ONESHOT, IRQF_ONESHOT,
client->name, keypad_data); client->name, keypad_data);
if (error) { if (error) {
dev_dbg(dev, "Unable to claim irq %d; error %d\n", dev_err(dev, "Unable to claim irq %d; error %d\n",
client->irq, error); client->irq, error);
goto fail2; goto fail2;
} }
error = input_register_device(input); error = input_register_device(input);
if (error) { if (error) {
dev_dbg(dev, "Unable to register input device, error: %d\n", dev_err(dev, "Unable to register input device, error: %d\n",
error); error);
goto fail3; goto fail3;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册