提交 7047d813 编写于 作者: A Andy Shevchenko 提交者: Linus Torvalds

test_hexdump: switch to memcmp()

Better to use memcmp() against entire buffer to check that nothing is
happened to the data in the tail.
Signed-off-by: NAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
上级 ad27a755
...@@ -72,8 +72,6 @@ static void __init test_hexdump_prepare_test(size_t len, int rowsize, ...@@ -72,8 +72,6 @@ static void __init test_hexdump_prepare_test(size_t len, int rowsize,
else else
result = test_data_1_le; result = test_data_1_le;
memset(test, FILL_CHAR, testlen);
/* hex dump */ /* hex dump */
p = test; p = test;
for (i = 0; i < l / gs; i++) { for (i = 0; i < l / gs; i++) {
...@@ -109,13 +107,15 @@ static void __init test_hexdump(size_t len, int rowsize, int groupsize, ...@@ -109,13 +107,15 @@ static void __init test_hexdump(size_t len, int rowsize, int groupsize,
char test[TEST_HEXDUMP_BUF_SIZE]; char test[TEST_HEXDUMP_BUF_SIZE];
char real[TEST_HEXDUMP_BUF_SIZE]; char real[TEST_HEXDUMP_BUF_SIZE];
memset(real, FILL_CHAR, sizeof(real));
hex_dump_to_buffer(data_b, len, rowsize, groupsize, real, sizeof(real), hex_dump_to_buffer(data_b, len, rowsize, groupsize, real, sizeof(real),
ascii); ascii);
memset(test, FILL_CHAR, sizeof(test));
test_hexdump_prepare_test(len, rowsize, groupsize, test, sizeof(test), test_hexdump_prepare_test(len, rowsize, groupsize, test, sizeof(test),
ascii); ascii);
if (strcmp(test, real)) { if (memcmp(test, real, TEST_HEXDUMP_BUF_SIZE)) {
pr_err("Len: %zu row: %d group: %d\n", len, rowsize, groupsize); pr_err("Len: %zu row: %d group: %d\n", len, rowsize, groupsize);
pr_err("Result: '%s'\n", real); pr_err("Result: '%s'\n", real);
pr_err("Expect: '%s'\n", test); pr_err("Expect: '%s'\n", test);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册