提交 6c9a58e8 编写于 作者: A Andy Shevchenko 提交者: Rafael J. Wysocki

ACPI / boot: Correct address space of __acpi_map_table()

Sparse complains about wrong address space used in __acpi_map_table()
and in __acpi_unmap_table().

arch/x86/kernel/acpi/boot.c:127:29: warning: incorrect type in return expression (different address spaces)
arch/x86/kernel/acpi/boot.c:127:29:    expected char *
arch/x86/kernel/acpi/boot.c:127:29:    got void [noderef] <asn:2>*
arch/x86/kernel/acpi/boot.c:135:23: warning: incorrect type in argument 1 (different address spaces)
arch/x86/kernel/acpi/boot.c:135:23:    expected void [noderef] <asn:2>*addr
arch/x86/kernel/acpi/boot.c:135:23:    got char *map

Correct address space to be in align of type of returned and passed
parameter.
Reviewed-by: NHanjun Guo <guohanjun@huawei.com>
Signed-off-by: NAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
上级 861a6ee8
...@@ -95,7 +95,7 @@ static int __init dt_scan_depth1_nodes(unsigned long node, ...@@ -95,7 +95,7 @@ static int __init dt_scan_depth1_nodes(unsigned long node,
* __acpi_map_table() will be called before page_init(), so early_ioremap() * __acpi_map_table() will be called before page_init(), so early_ioremap()
* or early_memremap() should be called here to for ACPI table mapping. * or early_memremap() should be called here to for ACPI table mapping.
*/ */
char *__init __acpi_map_table(unsigned long phys, unsigned long size) void __init __iomem *__acpi_map_table(unsigned long phys, unsigned long size)
{ {
if (!size) if (!size)
return NULL; return NULL;
...@@ -103,7 +103,7 @@ char *__init __acpi_map_table(unsigned long phys, unsigned long size) ...@@ -103,7 +103,7 @@ char *__init __acpi_map_table(unsigned long phys, unsigned long size)
return early_memremap(phys, size); return early_memremap(phys, size);
} }
void __init __acpi_unmap_table(char *map, unsigned long size) void __init __acpi_unmap_table(void __iomem *map, unsigned long size)
{ {
if (!map || !size) if (!map || !size)
return; return;
......
...@@ -159,12 +159,12 @@ int acpi_request_vector(u32 int_type) ...@@ -159,12 +159,12 @@ int acpi_request_vector(u32 int_type)
return vector; return vector;
} }
char *__init __acpi_map_table(unsigned long phys_addr, unsigned long size) void __init __iomem *__acpi_map_table(unsigned long phys, unsigned long size)
{ {
return __va(phys_addr); return __va(phys);
} }
void __init __acpi_unmap_table(char *map, unsigned long size) void __init __acpi_unmap_table(void __iomem *map, unsigned long size)
{ {
} }
......
...@@ -118,7 +118,7 @@ static u32 isa_irq_to_gsi[NR_IRQS_LEGACY] __read_mostly = { ...@@ -118,7 +118,7 @@ static u32 isa_irq_to_gsi[NR_IRQS_LEGACY] __read_mostly = {
* This is just a simple wrapper around early_ioremap(), * This is just a simple wrapper around early_ioremap(),
* with sanity checks for phys == 0 and size == 0. * with sanity checks for phys == 0 and size == 0.
*/ */
char *__init __acpi_map_table(unsigned long phys, unsigned long size) void __init __iomem *__acpi_map_table(unsigned long phys, unsigned long size)
{ {
if (!phys || !size) if (!phys || !size)
...@@ -127,7 +127,7 @@ char *__init __acpi_map_table(unsigned long phys, unsigned long size) ...@@ -127,7 +127,7 @@ char *__init __acpi_map_table(unsigned long phys, unsigned long size)
return early_ioremap(phys, size); return early_ioremap(phys, size);
} }
void __init __acpi_unmap_table(char *map, unsigned long size) void __init __acpi_unmap_table(void __iomem *map, unsigned long size)
{ {
if (!map || !size) if (!map || !size)
return; return;
......
...@@ -228,8 +228,8 @@ struct acpi_subtable_proc { ...@@ -228,8 +228,8 @@ struct acpi_subtable_proc {
int count; int count;
}; };
char * __acpi_map_table (unsigned long phys_addr, unsigned long size); void __iomem *__acpi_map_table(unsigned long phys, unsigned long size);
void __acpi_unmap_table(char *map, unsigned long size); void __acpi_unmap_table(void __iomem *map, unsigned long size);
int early_acpi_boot_init(void); int early_acpi_boot_init(void);
int acpi_boot_init (void); int acpi_boot_init (void);
void acpi_boot_table_init (void); void acpi_boot_table_init (void);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册