You need to sign in or sign up before continuing.
提交 5d0c49ac 编写于 作者: D Derek Basehore 提交者: Lee Jones

backlight: pwm_bl: Fix overflow condition

This fixes an overflow condition that can happen with high max
brightness and period values in compute_duty_cycle. This fixes it by
using a 64 bit variable for computing the duty cycle.
Signed-off-by: NDerek Basehore <dbasehore@chromium.org>
Acked-by: NThierry Reding <thierry.reding@gmail.com>
Reviewed-by: NBrian Norris <briannorris@chromium.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>
上级 2bd6bf03
......@@ -79,14 +79,17 @@ static void pwm_backlight_power_off(struct pwm_bl_data *pb)
static int compute_duty_cycle(struct pwm_bl_data *pb, int brightness)
{
unsigned int lth = pb->lth_brightness;
int duty_cycle;
u64 duty_cycle;
if (pb->levels)
duty_cycle = pb->levels[brightness];
else
duty_cycle = brightness;
return (duty_cycle * (pb->period - lth) / pb->scale) + lth;
duty_cycle *= pb->period - lth;
do_div(duty_cycle, pb->scale);
return duty_cycle + lth;
}
static int pwm_backlight_update_status(struct backlight_device *bl)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册