提交 5a6c2208 编写于 作者: J Jonghwa Lee 提交者: Anton Vorontsov

charger-manager: Fix regulator_get() return check

This patch fixes return value checking of regulator_get() in
charger-manager driver. The API, regulator_get(), returns ERR_PTR() when
it fails to get regulator with given name, not NULL.
Signed-off-by: NJonghwa Lee <jonghwa3.lee@samsung.com>
Signed-off-by: NMyungjoo Ham <myungjoo.ham@samsung.com>
Acked-by: NChanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: NAnton Vorontsov <anton@enomsg.org>
上级 3cc9d269
...@@ -1239,11 +1239,10 @@ static int charger_manager_register_extcon(struct charger_manager *cm) ...@@ -1239,11 +1239,10 @@ static int charger_manager_register_extcon(struct charger_manager *cm)
charger->consumer = regulator_get(cm->dev, charger->consumer = regulator_get(cm->dev,
charger->regulator_name); charger->regulator_name);
if (charger->consumer == NULL) { if (IS_ERR(charger->consumer)) {
dev_err(cm->dev, "Cannot find charger(%s)\n", dev_err(cm->dev, "Cannot find charger(%s)\n",
charger->regulator_name); charger->regulator_name);
ret = -EINVAL; return PTR_ERR(charger->consumer);
goto err;
} }
charger->cm = cm; charger->cm = cm;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册