提交 47f07833 编写于 作者: C Colin Ian King 提交者: Greg Kroah-Hartman

Revert "staging: fsl-mc: be consistent when checking strcmp() return"

The previous fix removed the equal to zero comparisons by the strcmps and
now the function always returns true. Revert this change to restore the
original correctly functioning code.

Detected by CoverityScan, CID#1452267 ("Constant expression result")

This reverts commit b93ad9a0.

Fixes: b93ad9a0 ("staging: fsl-mc: be consistent when checking strcmp() return")
Signed-off-by: NColin Ian King <colin.king@canonical.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
上级 ef954844
...@@ -16,9 +16,9 @@ ...@@ -16,9 +16,9 @@
static bool __must_check fsl_mc_is_allocatable(const char *obj_type) static bool __must_check fsl_mc_is_allocatable(const char *obj_type)
{ {
return strcmp(obj_type, "dpbp") || return strcmp(obj_type, "dpbp") == 0 ||
strcmp(obj_type, "dpmcp") || strcmp(obj_type, "dpmcp") == 0 ||
strcmp(obj_type, "dpcon"); strcmp(obj_type, "dpcon") == 0;
} }
/** /**
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册