提交 3b89e4b7 编写于 作者: A Arnd Bergmann 提交者: Mark Brown

ASoC: lpass-platform: initialize dma channel number

A bugfix accidentally removed the implicit initialization of the
dma channel number, causing undefined behavior when
v->alloc_dma_channel is NULL:

sound/soc/qcom/lpass-platform.c: In function ‘lpass_platform_pcmops_open’:
sound/soc/qcom/lpass-platform.c:83:29: error: ‘dma_ch’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

This adds back an explicit initialization to zero, restoring the
previous behavior for that case.

Fixes: 022d00ee ("ASoC: lpass-platform: Fix broken pcm data usage")
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Acked-by: NKenneth Westfield <kwestfie@codeaurora.org>
Signed-off-by: NMark Brown <broonie@kernel.org>
上级 94201798
...@@ -77,6 +77,9 @@ static int lpass_platform_pcmops_open(struct snd_pcm_substream *substream) ...@@ -77,6 +77,9 @@ static int lpass_platform_pcmops_open(struct snd_pcm_substream *substream)
if (v->alloc_dma_channel) if (v->alloc_dma_channel)
dma_ch = v->alloc_dma_channel(drvdata, dir); dma_ch = v->alloc_dma_channel(drvdata, dir);
else
dma_ch = 0;
if (dma_ch < 0) if (dma_ch < 0)
return dma_ch; return dma_ch;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册