提交 35f8679f 编写于 作者: D Dmitry Torokhov

Input: omap-keypad - remove dead check

Commit da1f026b ("Keyboard: omap-keypad:
use matrix_keypad.h") switched the driver to use matrix keypad
infrastructure, which made array of keycodes to be unsigned short, and
caused the test for negativity never trigger. This leads to the following
static checker warning:

	drivers/input/keyboard/omap-keypad.c:158 omap_kp_tasklet()
	warn: 'keycodes[]' is never negative.

Given that we did not care about this check for a few years already let's
simply remove it.
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Acked-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Acked-by: NTony Lindgren <tony@atomide.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
上级 3b7474ec
...@@ -155,14 +155,6 @@ static void omap_kp_tasklet(unsigned long data) ...@@ -155,14 +155,6 @@ static void omap_kp_tasklet(unsigned long data)
"pressed" : "released"); "pressed" : "released");
#else #else
key = keycodes[MATRIX_SCAN_CODE(row, col, row_shift)]; key = keycodes[MATRIX_SCAN_CODE(row, col, row_shift)];
if (key < 0) {
printk(KERN_WARNING
"omap-keypad: Spurious key event %d-%d\n",
col, row);
/* We scan again after a couple of seconds */
spurious = 1;
continue;
}
if (!(kp_cur_group == (key & GROUP_MASK) || if (!(kp_cur_group == (key & GROUP_MASK) ||
kp_cur_group == -1)) kp_cur_group == -1))
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册