• L
    i2c: pca954x: Fix compilation without CONFIG_GPIOLIB · 642653d1
    Laurent Pinchart 提交于
    The pca954x driver recently switched to the GPIO descriptor API without
    including the correct <linux/gpio/consumer.h> header. This breaks
    compilation without CONFIG_GPIOLIB.
    
    drivers/i2c/muxes/i2c-mux-pca954x.c: In function ‘pca954x_probe’:
    drivers/i2c/muxes/i2c-mux-pca954x.c:204:2: error: implicit declaration
    of function ‘devm_gpiod_get’ [-Werror=implicit-function-declaration]
      gpio = devm_gpiod_get(&client->dev, "reset");
      ^
    drivers/i2c/muxes/i2c-mux-pca954x.c:204:7: warning: assignment makes
    pointer from integer without a cast [enabled by default]
      gpio = devm_gpiod_get(&client->dev, "reset");
           ^
    drivers/i2c/muxes/i2c-mux-pca954x.c:206:3: error: implicit declaration
    of function ‘gpiod_direction_output’
    [-Werror=implicit-function-declaration]
       gpiod_direction_output(gpio, 0);
       ^
    cc1: some warnings being treated as errors
    make[3]: *** [drivers/i2c/muxes/i2c-mux-pca954x.o] Error 1
    
    Fix it by including the right header.
    Reported-by: NJim Davis <jim.epost@gmail.com>
    Signed-off-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: NWolfram Sang <wsa@the-dreams.de>
    642653d1
i2c-mux-pca954x.c 6.9 KB