hp-wmi.c 15.3 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49
/*
 * HP WMI hotkeys
 *
 * Copyright (C) 2008 Red Hat <mjg@redhat.com>
 *
 * Portions based on wistron_btns.c:
 * Copyright (C) 2005 Miloslav Trmac <mitr@volny.cz>
 * Copyright (C) 2005 Bernhard Rosenkraenzer <bero@arklinux.org>
 * Copyright (C) 2005 Dmitry Torokhov <dtor@mail.ru>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or
 *  (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  You should have received a copy of the GNU General Public License
 *  along with this program; if not, write to the Free Software
 *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 */

#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/types.h>
#include <linux/input.h>
#include <acpi/acpi_drivers.h>
#include <linux/platform_device.h>
#include <linux/acpi.h>
#include <linux/rfkill.h>
#include <linux/string.h>

MODULE_AUTHOR("Matthew Garrett <mjg59@srcf.ucam.org>");
MODULE_DESCRIPTION("HP laptop WMI hotkeys driver");
MODULE_LICENSE("GPL");

MODULE_ALIAS("wmi:95F24279-4D7B-4334-9387-ACCDC67EF61C");
MODULE_ALIAS("wmi:5FB7F034-2C63-45e9-BE91-3D44E2C707E4");

#define HPWMI_EVENT_GUID "95F24279-4D7B-4334-9387-ACCDC67EF61C"
#define HPWMI_BIOS_GUID "5FB7F034-2C63-45e9-BE91-3D44E2C707E4"

#define HPWMI_DISPLAY_QUERY 0x1
#define HPWMI_HDDTEMP_QUERY 0x2
#define HPWMI_ALS_QUERY 0x3
50
#define HPWMI_HARDWARE_QUERY 0x4
51
#define HPWMI_WIRELESS_QUERY 0x5
52
#define HPWMI_HOTKEY_QUERY 0xc
53

A
Alan Jenkins 已提交
54 55 56 57 58 59
enum hp_wmi_radio {
	HPWMI_WIFI = 0,
	HPWMI_BLUETOOTH = 1,
	HPWMI_WWAN = 2,
};

60
static int __devinit hp_wmi_bios_setup(struct platform_device *device);
61
static int __exit hp_wmi_bios_remove(struct platform_device *device);
F
Frans Pop 已提交
62
static int hp_wmi_resume_handler(struct device *device);
63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79

struct bios_args {
	u32 signature;
	u32 command;
	u32 commandtype;
	u32 datasize;
	u32 data;
};

struct bios_return {
	u32 sigpass;
	u32 return_code;
	u32 value;
};

struct key_entry {
	char type;		/* See KE_* below */
80
	u16 code;
81 82 83
	u16 keycode;
};

84
enum { KE_KEY, KE_END };
85 86 87 88

static struct key_entry hp_wmi_keymap[] = {
	{KE_KEY, 0x02, KEY_BRIGHTNESSUP},
	{KE_KEY, 0x03, KEY_BRIGHTNESSDOWN},
89 90
	{KE_KEY, 0x20e6, KEY_PROG1},
	{KE_KEY, 0x2142, KEY_MEDIA},
E
Eric Piel 已提交
91
	{KE_KEY, 0x213b, KEY_INFO},
92
	{KE_KEY, 0x2169, KEY_DIRECTION},
93
	{KE_KEY, 0x231b, KEY_HELP},
94 95 96 97 98 99 100 101 102 103
	{KE_END, 0}
};

static struct input_dev *hp_wmi_input_dev;
static struct platform_device *hp_wmi_platform_dev;

static struct rfkill *wifi_rfkill;
static struct rfkill *bluetooth_rfkill;
static struct rfkill *wwan_rfkill;

104
static const struct dev_pm_ops hp_wmi_pm_ops = {
F
Frans Pop 已提交
105 106 107 108
	.resume  = hp_wmi_resume_handler,
	.restore  = hp_wmi_resume_handler,
};

109 110
static struct platform_driver hp_wmi_driver = {
	.driver = {
F
Frans Pop 已提交
111 112 113
		.name = "hp-wmi",
		.owner = THIS_MODULE,
		.pm = &hp_wmi_pm_ops,
114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137
	},
	.probe = hp_wmi_bios_setup,
	.remove = hp_wmi_bios_remove,
};

static int hp_wmi_perform_query(int query, int write, int value)
{
	struct bios_return bios_return;
	acpi_status status;
	union acpi_object *obj;
	struct bios_args args = {
		.signature = 0x55434553,
		.command = write ? 0x2 : 0x1,
		.commandtype = query,
		.datasize = write ? 0x4 : 0,
		.data = value,
	};
	struct acpi_buffer input = { sizeof(struct bios_args), &args };
	struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };

	status = wmi_evaluate_method(HPWMI_BIOS_GUID, 0, 0x3, &input, &output);

	obj = output.pointer;

T
Thomas Renninger 已提交
138
	if (!obj)
139
		return -EINVAL;
T
Thomas Renninger 已提交
140 141 142 143
	else if (obj->type != ACPI_TYPE_BUFFER) {
		kfree(obj);
		return -EINVAL;
	}
144 145

	bios_return = *((struct bios_return *)obj->buffer.pointer);
T
Thomas Renninger 已提交
146
	kfree(obj);
147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169
	if (bios_return.return_code > 0)
		return bios_return.return_code * -1;
	else
		return bios_return.value;
}

static int hp_wmi_display_state(void)
{
	return hp_wmi_perform_query(HPWMI_DISPLAY_QUERY, 0, 0);
}

static int hp_wmi_hddtemp_state(void)
{
	return hp_wmi_perform_query(HPWMI_HDDTEMP_QUERY, 0, 0);
}

static int hp_wmi_als_state(void)
{
	return hp_wmi_perform_query(HPWMI_ALS_QUERY, 0, 0);
}

static int hp_wmi_dock_state(void)
{
170
	int ret = hp_wmi_perform_query(HPWMI_HARDWARE_QUERY, 0, 0);
171

172 173 174 175
	if (ret < 0)
		return ret;

	return ret & 0x1;
176 177
}

178
static int hp_wmi_tablet_state(void)
179
{
180 181 182 183 184 185
	int ret = hp_wmi_perform_query(HPWMI_HARDWARE_QUERY, 0, 0);

	if (ret < 0)
		return ret;

	return (ret & 0x4) ? 1 : 0;
186 187
}

J
Johannes Berg 已提交
188
static int hp_wmi_set_block(void *data, bool blocked)
189
{
A
Alan Jenkins 已提交
190 191
	enum hp_wmi_radio r = (enum hp_wmi_radio) data;
	int query = BIT(r + 8) | ((!blocked) << r);
192

J
Johannes Berg 已提交
193
	return hp_wmi_perform_query(HPWMI_WIRELESS_QUERY, 1, query);
194 195
}

J
Johannes Berg 已提交
196 197 198
static const struct rfkill_ops hp_wmi_rfkill_ops = {
	.set_block = hp_wmi_set_block,
};
199

A
Alan Jenkins 已提交
200
static bool hp_wmi_get_sw_state(enum hp_wmi_radio r)
201 202
{
	int wireless = hp_wmi_perform_query(HPWMI_WIRELESS_QUERY, 0, 0);
A
Alan Jenkins 已提交
203
	int mask = 0x200 << (r * 8);
204

A
Alan Jenkins 已提交
205
	if (wireless & mask)
J
Johannes Berg 已提交
206
		return false;
207
	else
J
Johannes Berg 已提交
208
		return true;
209 210
}

A
Alan Jenkins 已提交
211
static bool hp_wmi_get_hw_state(enum hp_wmi_radio r)
212 213
{
	int wireless = hp_wmi_perform_query(HPWMI_WIRELESS_QUERY, 0, 0);
A
Alan Jenkins 已提交
214
	int mask = 0x800 << (r * 8);
215

A
Alan Jenkins 已提交
216
	if (wireless & mask)
J
Johannes Berg 已提交
217
		return false;
218
	else
J
Johannes Berg 已提交
219
		return true;
220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257
}

static ssize_t show_display(struct device *dev, struct device_attribute *attr,
			    char *buf)
{
	int value = hp_wmi_display_state();
	if (value < 0)
		return -EINVAL;
	return sprintf(buf, "%d\n", value);
}

static ssize_t show_hddtemp(struct device *dev, struct device_attribute *attr,
			    char *buf)
{
	int value = hp_wmi_hddtemp_state();
	if (value < 0)
		return -EINVAL;
	return sprintf(buf, "%d\n", value);
}

static ssize_t show_als(struct device *dev, struct device_attribute *attr,
			char *buf)
{
	int value = hp_wmi_als_state();
	if (value < 0)
		return -EINVAL;
	return sprintf(buf, "%d\n", value);
}

static ssize_t show_dock(struct device *dev, struct device_attribute *attr,
			 char *buf)
{
	int value = hp_wmi_dock_state();
	if (value < 0)
		return -EINVAL;
	return sprintf(buf, "%d\n", value);
}

258 259 260 261 262 263 264 265 266
static ssize_t show_tablet(struct device *dev, struct device_attribute *attr,
			 char *buf)
{
	int value = hp_wmi_tablet_state();
	if (value < 0)
		return -EINVAL;
	return sprintf(buf, "%d\n", value);
}

267 268 269 270 271 272 273 274 275 276 277 278
static ssize_t set_als(struct device *dev, struct device_attribute *attr,
		       const char *buf, size_t count)
{
	u32 tmp = simple_strtoul(buf, NULL, 10);
	hp_wmi_perform_query(HPWMI_ALS_QUERY, 1, tmp);
	return count;
}

static DEVICE_ATTR(display, S_IRUGO, show_display, NULL);
static DEVICE_ATTR(hddtemp, S_IRUGO, show_hddtemp, NULL);
static DEVICE_ATTR(als, S_IRUGO | S_IWUSR, show_als, set_als);
static DEVICE_ATTR(dock, S_IRUGO, show_dock, NULL);
279
static DEVICE_ATTR(tablet, S_IRUGO, show_tablet, NULL);
280

281
static struct key_entry *hp_wmi_get_entry_by_scancode(unsigned int code)
282 283 284 285 286 287 288 289 290 291
{
	struct key_entry *key;

	for (key = hp_wmi_keymap; key->type != KE_END; key++)
		if (code == key->code)
			return key;

	return NULL;
}

292
static struct key_entry *hp_wmi_get_entry_by_keycode(unsigned int keycode)
293 294 295 296 297 298 299 300 301 302
{
	struct key_entry *key;

	for (key = hp_wmi_keymap; key->type != KE_END; key++)
		if (key->type == KE_KEY && keycode == key->keycode)
			return key;

	return NULL;
}

303 304
static int hp_wmi_getkeycode(struct input_dev *dev,
			     unsigned int scancode, unsigned int *keycode)
305 306 307 308 309 310 311 312 313 314 315
{
	struct key_entry *key = hp_wmi_get_entry_by_scancode(scancode);

	if (key && key->type == KE_KEY) {
		*keycode = key->keycode;
		return 0;
	}

	return -EINVAL;
}

316 317
static int hp_wmi_setkeycode(struct input_dev *dev,
			     unsigned int scancode, unsigned int keycode)
318 319
{
	struct key_entry *key;
320
	unsigned int old_keycode;
321 322 323 324 325 326 327 328 329 330 331 332 333 334

	key = hp_wmi_get_entry_by_scancode(scancode);
	if (key && key->type == KE_KEY) {
		old_keycode = key->keycode;
		key->keycode = keycode;
		set_bit(keycode, dev->keybit);
		if (!hp_wmi_get_entry_by_keycode(old_keycode))
			clear_bit(old_keycode, dev->keybit);
		return 0;
	}

	return -EINVAL;
}

A
Adrian Bunk 已提交
335
static void hp_wmi_notify(u32 value, void *context)
336 337 338 339
{
	struct acpi_buffer response = { ACPI_ALLOCATE_BUFFER, NULL };
	static struct key_entry *key;
	union acpi_object *obj;
A
Alan Jenkins 已提交
340
	int eventcode;
341
	acpi_status status;
342

343 344 345 346 347
	status = wmi_get_event_data(value, &response);
	if (status != AE_OK) {
		printk(KERN_INFO "hp-wmi: bad event status 0x%x\n", status);
		return;
	}
348 349 350

	obj = (union acpi_object *)response.pointer;

A
Alan Jenkins 已提交
351 352
	if (!obj || obj->type != ACPI_TYPE_BUFFER || obj->buffer.length != 8) {
		printk(KERN_INFO "HP WMI: Unknown response received\n");
T
Thomas Renninger 已提交
353
		kfree(obj);
A
Alan Jenkins 已提交
354 355 356 357
		return;
	}

	eventcode = *((u8 *) obj->buffer.pointer);
T
Thomas Renninger 已提交
358
	kfree(obj);
A
Alan Jenkins 已提交
359 360 361 362 363 364 365 366 367 368 369 370
	if (eventcode == 0x4)
		eventcode = hp_wmi_perform_query(HPWMI_HOTKEY_QUERY, 0,
						0);
	key = hp_wmi_get_entry_by_scancode(eventcode);
	if (key) {
		switch (key->type) {
		case KE_KEY:
			input_report_key(hp_wmi_input_dev,
					 key->keycode, 1);
			input_sync(hp_wmi_input_dev);
			input_report_key(hp_wmi_input_dev,
					 key->keycode, 0);
371
			input_sync(hp_wmi_input_dev);
A
Alan Jenkins 已提交
372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392
			break;
		}
	} else if (eventcode == 0x1) {
		input_report_switch(hp_wmi_input_dev, SW_DOCK,
				    hp_wmi_dock_state());
		input_report_switch(hp_wmi_input_dev, SW_TABLET_MODE,
				    hp_wmi_tablet_state());
		input_sync(hp_wmi_input_dev);
	} else if (eventcode == 0x5) {
		if (wifi_rfkill)
			rfkill_set_states(wifi_rfkill,
					  hp_wmi_get_sw_state(HPWMI_WIFI),
					  hp_wmi_get_hw_state(HPWMI_WIFI));
		if (bluetooth_rfkill)
			rfkill_set_states(bluetooth_rfkill,
					  hp_wmi_get_sw_state(HPWMI_BLUETOOTH),
					  hp_wmi_get_hw_state(HPWMI_BLUETOOTH));
		if (wwan_rfkill)
			rfkill_set_states(wwan_rfkill,
					  hp_wmi_get_sw_state(HPWMI_WWAN),
					  hp_wmi_get_hw_state(HPWMI_WWAN));
393
	} else
A
Alan Jenkins 已提交
394 395
		printk(KERN_INFO "HP WMI: Unknown key pressed - %x\n",
			eventcode);
396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419
}

static int __init hp_wmi_input_setup(void)
{
	struct key_entry *key;
	int err;

	hp_wmi_input_dev = input_allocate_device();

	hp_wmi_input_dev->name = "HP WMI hotkeys";
	hp_wmi_input_dev->phys = "wmi/input0";
	hp_wmi_input_dev->id.bustype = BUS_HOST;
	hp_wmi_input_dev->getkeycode = hp_wmi_getkeycode;
	hp_wmi_input_dev->setkeycode = hp_wmi_setkeycode;

	for (key = hp_wmi_keymap; key->type != KE_END; key++) {
		switch (key->type) {
		case KE_KEY:
			set_bit(EV_KEY, hp_wmi_input_dev->evbit);
			set_bit(key->keycode, hp_wmi_input_dev->keybit);
			break;
		}
	}

420 421 422 423 424 425 426 427 428 429
	set_bit(EV_SW, hp_wmi_input_dev->evbit);
	set_bit(SW_DOCK, hp_wmi_input_dev->swbit);
	set_bit(SW_TABLET_MODE, hp_wmi_input_dev->swbit);

	/* Set initial hardware state */
	input_report_switch(hp_wmi_input_dev, SW_DOCK, hp_wmi_dock_state());
	input_report_switch(hp_wmi_input_dev, SW_TABLET_MODE,
			    hp_wmi_tablet_state());
	input_sync(hp_wmi_input_dev);

430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445
	err = input_register_device(hp_wmi_input_dev);

	if (err) {
		input_free_device(hp_wmi_input_dev);
		return err;
	}

	return 0;
}

static void cleanup_sysfs(struct platform_device *device)
{
	device_remove_file(&device->dev, &dev_attr_display);
	device_remove_file(&device->dev, &dev_attr_hddtemp);
	device_remove_file(&device->dev, &dev_attr_als);
	device_remove_file(&device->dev, &dev_attr_dock);
446
	device_remove_file(&device->dev, &dev_attr_tablet);
447 448
}

449
static int __devinit hp_wmi_bios_setup(struct platform_device *device)
450 451
{
	int err;
452
	int wireless = hp_wmi_perform_query(HPWMI_WIRELESS_QUERY, 0, 0);
453 454 455 456 457 458 459 460 461 462 463

	err = device_create_file(&device->dev, &dev_attr_display);
	if (err)
		goto add_sysfs_error;
	err = device_create_file(&device->dev, &dev_attr_hddtemp);
	if (err)
		goto add_sysfs_error;
	err = device_create_file(&device->dev, &dev_attr_als);
	if (err)
		goto add_sysfs_error;
	err = device_create_file(&device->dev, &dev_attr_dock);
464 465 466
	if (err)
		goto add_sysfs_error;
	err = device_create_file(&device->dev, &dev_attr_tablet);
467 468 469
	if (err)
		goto add_sysfs_error;

470
	if (wireless & 0x1) {
J
Johannes Berg 已提交
471 472 473
		wifi_rfkill = rfkill_alloc("hp-wifi", &device->dev,
					   RFKILL_TYPE_WLAN,
					   &hp_wmi_rfkill_ops,
A
Alan Jenkins 已提交
474 475 476 477 478
					   (void *) HPWMI_WIFI);
		rfkill_init_sw_state(wifi_rfkill,
				     hp_wmi_get_sw_state(HPWMI_WIFI));
		rfkill_set_hw_state(wifi_rfkill,
				    hp_wmi_get_hw_state(HPWMI_WIFI));
479 480
		err = rfkill_register(wifi_rfkill);
		if (err)
J
Johannes Berg 已提交
481
			goto register_wifi_error;
482 483 484
	}

	if (wireless & 0x2) {
J
Johannes Berg 已提交
485 486 487
		bluetooth_rfkill = rfkill_alloc("hp-bluetooth", &device->dev,
						RFKILL_TYPE_BLUETOOTH,
						&hp_wmi_rfkill_ops,
A
Alan Jenkins 已提交
488 489 490 491 492
						(void *) HPWMI_BLUETOOTH);
		rfkill_init_sw_state(bluetooth_rfkill,
				     hp_wmi_get_sw_state(HPWMI_BLUETOOTH));
		rfkill_set_hw_state(bluetooth_rfkill,
				    hp_wmi_get_hw_state(HPWMI_BLUETOOTH));
493
		err = rfkill_register(bluetooth_rfkill);
494
		if (err)
495
			goto register_bluetooth_error;
496 497 498
	}

	if (wireless & 0x4) {
J
Johannes Berg 已提交
499 500 501
		wwan_rfkill = rfkill_alloc("hp-wwan", &device->dev,
					   RFKILL_TYPE_WWAN,
					   &hp_wmi_rfkill_ops,
A
Alan Jenkins 已提交
502 503 504 505 506
					   (void *) HPWMI_WWAN);
		rfkill_init_sw_state(wwan_rfkill,
				     hp_wmi_get_sw_state(HPWMI_WWAN));
		rfkill_set_hw_state(wwan_rfkill,
				    hp_wmi_get_hw_state(HPWMI_WWAN));
507 508 509
		err = rfkill_register(wwan_rfkill);
		if (err)
			goto register_wwan_err;
510
	}
511 512

	return 0;
513
register_wwan_err:
J
Johannes Berg 已提交
514
	rfkill_destroy(wwan_rfkill);
515 516
	if (bluetooth_rfkill)
		rfkill_unregister(bluetooth_rfkill);
517
register_bluetooth_error:
J
Johannes Berg 已提交
518
	rfkill_destroy(bluetooth_rfkill);
519 520
	if (wifi_rfkill)
		rfkill_unregister(wifi_rfkill);
J
Johannes Berg 已提交
521 522
register_wifi_error:
	rfkill_destroy(wifi_rfkill);
523 524 525 526 527 528 529 530 531
add_sysfs_error:
	cleanup_sysfs(device);
	return err;
}

static int __exit hp_wmi_bios_remove(struct platform_device *device)
{
	cleanup_sysfs(device);

J
Johannes Berg 已提交
532
	if (wifi_rfkill) {
533
		rfkill_unregister(wifi_rfkill);
J
Johannes Berg 已提交
534 535 536
		rfkill_destroy(wifi_rfkill);
	}
	if (bluetooth_rfkill) {
537
		rfkill_unregister(bluetooth_rfkill);
538
		rfkill_destroy(bluetooth_rfkill);
J
Johannes Berg 已提交
539 540
	}
	if (wwan_rfkill) {
541
		rfkill_unregister(wwan_rfkill);
J
Johannes Berg 已提交
542 543
		rfkill_destroy(wwan_rfkill);
	}
544 545 546 547

	return 0;
}

F
Frans Pop 已提交
548
static int hp_wmi_resume_handler(struct device *device)
549 550
{
	/*
551 552
	 * Hardware state may have changed while suspended, so trigger
	 * input events for the current state. As this is a switch,
553 554 555
	 * the input layer will only actually pass it on if the state
	 * changed.
	 */
556 557 558 559 560 561 562
	if (hp_wmi_input_dev) {
		input_report_switch(hp_wmi_input_dev, SW_DOCK,
				    hp_wmi_dock_state());
		input_report_switch(hp_wmi_input_dev, SW_TABLET_MODE,
				    hp_wmi_tablet_state());
		input_sync(hp_wmi_input_dev);
	}
563

A
Alan Jenkins 已提交
564 565 566 567 568 569 570 571 572 573 574 575 576
	if (wifi_rfkill)
		rfkill_set_states(wifi_rfkill,
				  hp_wmi_get_sw_state(HPWMI_WIFI),
				  hp_wmi_get_hw_state(HPWMI_WIFI));
	if (bluetooth_rfkill)
		rfkill_set_states(bluetooth_rfkill,
				  hp_wmi_get_sw_state(HPWMI_BLUETOOTH),
				  hp_wmi_get_hw_state(HPWMI_BLUETOOTH));
	if (wwan_rfkill)
		rfkill_set_states(wwan_rfkill,
				  hp_wmi_get_sw_state(HPWMI_WWAN),
				  hp_wmi_get_hw_state(HPWMI_WWAN));

577 578 579
	return 0;
}

580 581 582 583 584 585 586
static int __init hp_wmi_init(void)
{
	int err;

	if (wmi_has_guid(HPWMI_EVENT_GUID)) {
		err = wmi_install_notify_handler(HPWMI_EVENT_GUID,
						 hp_wmi_notify, NULL);
587
		if (ACPI_SUCCESS(err))
588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619
			hp_wmi_input_setup();
	}

	if (wmi_has_guid(HPWMI_BIOS_GUID)) {
		err = platform_driver_register(&hp_wmi_driver);
		if (err)
			return 0;
		hp_wmi_platform_dev = platform_device_alloc("hp-wmi", -1);
		if (!hp_wmi_platform_dev) {
			platform_driver_unregister(&hp_wmi_driver);
			return 0;
		}
		platform_device_add(hp_wmi_platform_dev);
	}

	return 0;
}

static void __exit hp_wmi_exit(void)
{
	if (wmi_has_guid(HPWMI_EVENT_GUID)) {
		wmi_remove_notify_handler(HPWMI_EVENT_GUID);
		input_unregister_device(hp_wmi_input_dev);
	}
	if (hp_wmi_platform_dev) {
		platform_device_del(hp_wmi_platform_dev);
		platform_driver_unregister(&hp_wmi_driver);
	}
}

module_init(hp_wmi_init);
module_exit(hp_wmi_exit);