xattr.c 31.8 KB
Newer Older
L
Linus Torvalds 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32
/*
 * linux/fs/reiserfs/xattr.c
 *
 * Copyright (c) 2002 by Jeff Mahoney, <jeffm@suse.com>
 *
 */

/*
 * In order to implement EA/ACLs in a clean, backwards compatible manner,
 * they are implemented as files in a "private" directory.
 * Each EA is in it's own file, with the directory layout like so (/ is assumed
 * to be relative to fs root). Inside the /.reiserfs_priv/xattrs directory,
 * directories named using the capital-hex form of the objectid and
 * generation number are used. Inside each directory are individual files
 * named with the name of the extended attribute.
 *
 * So, for objectid 12648430, we could have:
 * /.reiserfs_priv/xattrs/C0FFEE.0/system.posix_acl_access
 * /.reiserfs_priv/xattrs/C0FFEE.0/system.posix_acl_default
 * /.reiserfs_priv/xattrs/C0FFEE.0/user.Content-Type
 * .. or similar.
 *
 * The file contents are the text of the EA. The size is known based on the
 * stat data describing the file.
 *
 * In the case of system.posix_acl_access and system.posix_acl_default, since
 * these are special cases for filesystem ACLs, they are interpreted by the
 * kernel, in addition, they are negatively and positively cached and attached
 * to the inode so that unnecessary lookups are avoided.
 */

#include <linux/reiserfs_fs.h>
33
#include <linux/capability.h>
L
Linus Torvalds 已提交
34 35 36 37 38 39 40 41 42 43
#include <linux/dcache.h>
#include <linux/namei.h>
#include <linux/errno.h>
#include <linux/fs.h>
#include <linux/file.h>
#include <linux/pagemap.h>
#include <linux/xattr.h>
#include <linux/reiserfs_xattr.h>
#include <linux/reiserfs_acl.h>
#include <asm/uaccess.h>
44
#include <net/checksum.h>
L
Linus Torvalds 已提交
45 46 47 48 49 50 51 52
#include <linux/smp_lock.h>
#include <linux/stat.h>

#define FL_READONLY 128
#define FL_DIR_SEM_HELD 256
#define PRIVROOT_NAME ".reiserfs_priv"
#define XAROOT_NAME   "xattrs"

53 54 55 56 57 58
/* Returns the dentry referring to the root of the extended attribute
 * directory tree. If it has already been retrieved, it is used. If it
 * hasn't been created and the flags indicate creation is allowed, we
 * attempt to create it. On error, we return a pointer-encoded error.
 */
static struct dentry *get_xa_root(struct super_block *sb, int flags)
L
Linus Torvalds 已提交
59
{
60 61 62 63 64
	struct dentry *privroot = dget(REISERFS_SB(sb)->priv_root);
	struct dentry *xaroot;

	/* This needs to be created at mount-time */
	if (!privroot)
65
		return ERR_PTR(-ENODATA);
66

67
	mutex_lock_nested(&privroot->d_inode->i_mutex, I_MUTEX_XATTR);
68 69
	if (REISERFS_SB(sb)->xattr_root) {
		xaroot = dget(REISERFS_SB(sb)->xattr_root);
70 71 72 73 74 75 76
		goto out;
	}

	xaroot = lookup_one_len(XAROOT_NAME, privroot, strlen(XAROOT_NAME));
	if (IS_ERR(xaroot)) {
		goto out;
	} else if (!xaroot->d_inode) {
77 78 79 80 81 82 83 84 85
		int err = -ENODATA;
		if (flags == 0 || flags & XATTR_CREATE)
			err = privroot->d_inode->i_op->mkdir(privroot->d_inode,
			                                     xaroot, 0700);
		if (err) {
			dput(xaroot);
			xaroot = ERR_PTR(err);
			goto out;
		}
86
	}
87
	REISERFS_SB(sb)->xattr_root = dget(xaroot);
88 89

      out:
90
	mutex_unlock(&privroot->d_inode->i_mutex);
91 92
	dput(privroot);
	return xaroot;
L
Linus Torvalds 已提交
93 94 95 96 97
}

/* Opens the directory corresponding to the inode's extended attribute store.
 * If flags allow, the tree to the directory may be created. If creation is
 * prohibited, -ENODATA is returned. */
98
static struct dentry *open_xa_dir(const struct inode *inode, int flags)
L
Linus Torvalds 已提交
99
{
100 101 102
	struct dentry *xaroot, *xadir;
	char namebuf[17];

103 104
	xaroot = get_xa_root(inode->i_sb, flags);
	if (IS_ERR(xaroot))
105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140
		return xaroot;

	/* ok, we have xaroot open */
	snprintf(namebuf, sizeof(namebuf), "%X.%X",
		 le32_to_cpu(INODE_PKEY(inode)->k_objectid),
		 inode->i_generation);
	xadir = lookup_one_len(namebuf, xaroot, strlen(namebuf));
	if (IS_ERR(xadir)) {
		dput(xaroot);
		return xadir;
	}

	if (!xadir->d_inode) {
		int err;
		if (flags == 0 || flags & XATTR_CREATE) {
			/* Although there is nothing else trying to create this directory,
			 * another directory with the same hash may be created, so we need
			 * to protect against that */
			err =
			    xaroot->d_inode->i_op->mkdir(xaroot->d_inode, xadir,
							 0700);
			if (err) {
				dput(xaroot);
				dput(xadir);
				return ERR_PTR(err);
			}
		}
		if (!xadir->d_inode) {
			dput(xaroot);
			dput(xadir);
			return ERR_PTR(-ENODATA);
		}
	}

	dput(xaroot);
	return xadir;
L
Linus Torvalds 已提交
141 142 143 144 145 146 147 148 149 150 151 152
}

/*
 * this is very similar to fs/reiserfs/dir.c:reiserfs_readdir, but
 * we need to drop the path before calling the filldir struct.  That
 * would be a big performance hit to the non-xattr case, so I've copied
 * the whole thing for now. --clm
 *
 * the big difference is that I go backwards through the directory,
 * and don't mess with f->f_pos, but the idea is the same.  Do some
 * action on each and every entry in the directory.
 *
153
 * we're called with i_mutex held, so there are no worries about the directory
L
Linus Torvalds 已提交
154 155
 * changing underneath us.
 */
156
static int __xattr_readdir(struct inode *inode, void *dirent, filldir_t filldir)
L
Linus Torvalds 已提交
157
{
158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192
	struct cpu_key pos_key;	/* key of current position in the directory (key of directory entry) */
	INITIALIZE_PATH(path_to_entry);
	struct buffer_head *bh;
	int entry_num;
	struct item_head *ih, tmp_ih;
	int search_res;
	char *local_buf;
	loff_t next_pos;
	char small_buf[32];	/* avoid kmalloc if we can */
	struct reiserfs_de_head *deh;
	int d_reclen;
	char *d_name;
	off_t d_off;
	ino_t d_ino;
	struct reiserfs_dir_entry de;

	/* form key for search the next directory entry using f_pos field of
	   file structure */
	next_pos = max_reiserfs_offset(inode);

	while (1) {
	      research:
		if (next_pos <= DOT_DOT_OFFSET)
			break;
		make_cpu_key(&pos_key, inode, next_pos, TYPE_DIRENTRY, 3);

		search_res =
		    search_by_entry_key(inode->i_sb, &pos_key, &path_to_entry,
					&de);
		if (search_res == IO_ERROR) {
			// FIXME: we could just skip part of directory which could
			// not be read
			pathrelse(&path_to_entry);
			return -EIO;
		}
L
Linus Torvalds 已提交
193

194 195
		if (search_res == NAME_NOT_FOUND)
			de.de_entry_num--;
L
Linus Torvalds 已提交
196

197 198 199
		set_de_name_and_namelen(&de);
		entry_num = de.de_entry_num;
		deh = &(de.de_deh[entry_num]);
L
Linus Torvalds 已提交
200

201 202
		bh = de.de_bh;
		ih = de.de_ih;
L
Linus Torvalds 已提交
203

204
		if (!is_direntry_le_ih(ih)) {
J
Jeff Mahoney 已提交
205 206
			reiserfs_error(inode->i_sb, "jdm-20000",
				       "not direntry %h", ih);
207 208 209
			break;
		}
		copy_item_head(&tmp_ih, ih);
L
Linus Torvalds 已提交
210

211 212 213 214
		/* we must have found item, that is item of this directory, */
		RFALSE(COMP_SHORT_KEYS(&(ih->ih_key), &pos_key),
		       "vs-9000: found item %h does not match to dir we readdir %K",
		       ih, &pos_key);
L
Linus Torvalds 已提交
215

216 217 218
		if (deh_offset(deh) <= DOT_DOT_OFFSET) {
			break;
		}
L
Linus Torvalds 已提交
219

220 221
		/* look for the previous entry in the directory */
		next_pos = deh_offset(deh) - 1;
L
Linus Torvalds 已提交
222

223 224 225
		if (!de_visible(deh))
			/* it is hidden entry */
			continue;
L
Linus Torvalds 已提交
226

227 228 229 230
		d_reclen = entry_length(bh, ih, entry_num);
		d_name = B_I_DEH_ENTRY_FILE_NAME(bh, ih, deh);
		d_off = deh_offset(deh);
		d_ino = deh_objectid(deh);
L
Linus Torvalds 已提交
231

232 233
		if (!d_name[d_reclen - 1])
			d_reclen = strlen(d_name);
L
Linus Torvalds 已提交
234

235 236 237 238
		if (d_reclen > REISERFS_MAX_NAME(inode->i_sb->s_blocksize)) {
			/* too big to send back to VFS */
			continue;
		}
L
Linus Torvalds 已提交
239

240 241 242 243 244 245 246 247 248 249 250 251
		/* Ignore the .reiserfs_priv entry */
		if (reiserfs_xattrs(inode->i_sb) &&
		    !old_format_only(inode->i_sb) &&
		    deh_objectid(deh) ==
		    le32_to_cpu(INODE_PKEY
				(REISERFS_SB(inode->i_sb)->priv_root->d_inode)->
				k_objectid))
			continue;

		if (d_reclen <= 32) {
			local_buf = small_buf;
		} else {
252
			local_buf = kmalloc(d_reclen, GFP_NOFS);
253 254 255 256 257
			if (!local_buf) {
				pathrelse(&path_to_entry);
				return -ENOMEM;
			}
			if (item_moved(&tmp_ih, &path_to_entry)) {
258
				kfree(local_buf);
259 260 261 262 263 264

				/* sigh, must retry.  Do this same offset again */
				next_pos = d_off;
				goto research;
			}
		}
L
Linus Torvalds 已提交
265

266 267 268 269 270
		// Note, that we copy name to user space via temporary
		// buffer (local_buf) because filldir will block if
		// user space buffer is swapped out. At that time
		// entry can move to somewhere else
		memcpy(local_buf, d_name, d_reclen);
L
Linus Torvalds 已提交
271

272 273 274 275 276 277 278 279 280
		/* the filldir function might need to start transactions,
		 * or do who knows what.  Release the path now that we've
		 * copied all the important stuff out of the deh
		 */
		pathrelse(&path_to_entry);

		if (filldir(dirent, local_buf, d_reclen, d_off, d_ino,
			    DT_UNKNOWN) < 0) {
			if (local_buf != small_buf) {
281
				kfree(local_buf);
282 283 284 285
			}
			goto end;
		}
		if (local_buf != small_buf) {
286
			kfree(local_buf);
287 288
		}
	}			/* while */
L
Linus Torvalds 已提交
289

290 291 292
      end:
	pathrelse(&path_to_entry);
	return 0;
L
Linus Torvalds 已提交
293 294 295 296 297 298 299 300 301
}

/*
 * this could be done with dedicated readdir ops for the xattr files,
 * but I want to get something working asap
 * this is stolen from vfs_readdir
 *
 */
static
302
int xattr_readdir(struct inode *inode, filldir_t filler, void *buf)
L
Linus Torvalds 已提交
303
{
304
	int res = -ENOENT;
I
Ingo Molnar 已提交
305
	mutex_lock_nested(&inode->i_mutex, I_MUTEX_XATTR);
306 307
	if (!IS_DEADDIR(inode)) {
		lock_kernel();
308
		res = __xattr_readdir(inode, buf, filler);
309 310
		unlock_kernel();
	}
311
	mutex_unlock(&inode->i_mutex);
312
	return res;
L
Linus Torvalds 已提交
313 314
}

315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559
static int
__reiserfs_xattr_del(struct dentry *xadir, const char *name, int namelen)
{
	struct dentry *dentry;
	struct inode *dir = xadir->d_inode;
	int err = 0;

	dentry = lookup_one_len(name, xadir, namelen);
	if (IS_ERR(dentry)) {
		err = PTR_ERR(dentry);
		goto out;
	} else if (!dentry->d_inode) {
		err = -ENODATA;
		goto out_file;
	}

	/* Skip directories.. */
	if (S_ISDIR(dentry->d_inode->i_mode))
		goto out_file;

	if (!IS_PRIVATE(dentry->d_inode)) {
		reiserfs_error(dir->i_sb, "jdm-20003",
			       "OID %08x [%.*s/%.*s] doesn't have "
			       "priv flag set [parent is %sset].",
			       le32_to_cpu(INODE_PKEY(dentry->d_inode)->
					   k_objectid), xadir->d_name.len,
			       xadir->d_name.name, namelen, name,
			       IS_PRIVATE(xadir->d_inode) ? "" :
			       "not ");
		dput(dentry);
		return -EIO;
	}

	err = dir->i_op->unlink(dir, dentry);
	if (!err)
		d_delete(dentry);

out_file:
	dput(dentry);

out:
	return err;
}

/* The following are side effects of other operations that aren't explicitly
 * modifying extended attributes. This includes operations such as permissions
 * or ownership changes, object deletions, etc. */

static int
reiserfs_delete_xattrs_filler(void *buf, const char *name, int namelen,
			      loff_t offset, u64 ino, unsigned int d_type)
{
	struct dentry *xadir = (struct dentry *)buf;

	return __reiserfs_xattr_del(xadir, name, namelen);

}

/* This is called w/ inode->i_mutex downed */
int reiserfs_delete_xattrs(struct inode *inode)
{
	struct dentry *dir, *root;
	int err = 0;

	/* Skip out, an xattr has no xattrs associated with it */
	if (IS_PRIVATE(inode) || get_inode_sd_version(inode) == STAT_DATA_V1)
		return 0;

	reiserfs_read_lock_xattrs(inode->i_sb);
	dir = open_xa_dir(inode, FL_READONLY);
	reiserfs_read_unlock_xattrs(inode->i_sb);
	if (IS_ERR(dir)) {
		err = PTR_ERR(dir);
		goto out;
	} else if (!dir->d_inode) {
		dput(dir);
		return 0;
	}

	lock_kernel();
	err = xattr_readdir(dir->d_inode, reiserfs_delete_xattrs_filler, dir);
	if (err) {
		unlock_kernel();
		goto out_dir;
	}

	/* Leftovers besides . and .. -- that's not good. */
	if (dir->d_inode->i_nlink <= 2) {
		root = get_xa_root(inode->i_sb, XATTR_REPLACE);
		reiserfs_write_lock_xattrs(inode->i_sb);
		err = vfs_rmdir(root->d_inode, dir);
		reiserfs_write_unlock_xattrs(inode->i_sb);
		dput(root);
	} else {
		reiserfs_warning(inode->i_sb, "jdm-20006",
				 "Couldn't remove all entries in directory");
	}
	unlock_kernel();

out_dir:
	dput(dir);

out:
	if (!err)
		REISERFS_I(inode)->i_flags =
		    REISERFS_I(inode)->i_flags & ~i_has_xattr_dir;
	return err;
}

struct reiserfs_chown_buf {
	struct inode *inode;
	struct dentry *xadir;
	struct iattr *attrs;
};

/* XXX: If there is a better way to do this, I'd love to hear about it */
static int
reiserfs_chown_xattrs_filler(void *buf, const char *name, int namelen,
			     loff_t offset, u64 ino, unsigned int d_type)
{
	struct reiserfs_chown_buf *chown_buf = (struct reiserfs_chown_buf *)buf;
	struct dentry *xafile, *xadir = chown_buf->xadir;
	struct iattr *attrs = chown_buf->attrs;
	int err = 0;

	xafile = lookup_one_len(name, xadir, namelen);
	if (IS_ERR(xafile))
		return PTR_ERR(xafile);
	else if (!xafile->d_inode) {
		dput(xafile);
		return -ENODATA;
	}

	if (!S_ISDIR(xafile->d_inode->i_mode))
		err = notify_change(xafile, attrs);
	dput(xafile);

	return err;
}

int reiserfs_chown_xattrs(struct inode *inode, struct iattr *attrs)
{
	struct dentry *dir;
	int err = 0;
	struct reiserfs_chown_buf buf;
	unsigned int ia_valid = attrs->ia_valid;

	/* Skip out, an xattr has no xattrs associated with it */
	if (IS_PRIVATE(inode) || get_inode_sd_version(inode) == STAT_DATA_V1)
		return 0;

	reiserfs_read_lock_xattrs(inode->i_sb);
	dir = open_xa_dir(inode, FL_READONLY);
	reiserfs_read_unlock_xattrs(inode->i_sb);
	if (IS_ERR(dir)) {
		if (PTR_ERR(dir) != -ENODATA)
			err = PTR_ERR(dir);
		goto out;
	} else if (!dir->d_inode) {
		dput(dir);
		goto out;
	}

	lock_kernel();

	attrs->ia_valid &= (ATTR_UID | ATTR_GID | ATTR_CTIME);
	buf.xadir = dir;
	buf.attrs = attrs;
	buf.inode = inode;

	err = xattr_readdir(dir->d_inode, reiserfs_chown_xattrs_filler, &buf);
	if (err) {
		unlock_kernel();
		goto out_dir;
	}

	err = notify_change(dir, attrs);
	unlock_kernel();

out_dir:
	dput(dir);

out:
	attrs->ia_valid = ia_valid;
	return err;
}

#ifdef CONFIG_REISERFS_FS_XATTR
static struct reiserfs_xattr_handler *find_xattr_handler_prefix(const char
								*prefix);

/* Returns a dentry corresponding to a specific extended attribute file
 * for the inode. If flags allow, the file is created. Otherwise, a
 * valid or negative dentry, or an error is returned. */
static struct dentry *get_xa_file_dentry(const struct inode *inode,
					 const char *name, int flags)
{
	struct dentry *xadir, *xafile;
	int err = 0;

	xadir = open_xa_dir(inode, flags);
	if (IS_ERR(xadir)) {
		return ERR_CAST(xadir);
	} else if (xadir && !xadir->d_inode) {
		dput(xadir);
		return ERR_PTR(-ENODATA);
	}

	xafile = lookup_one_len(name, xadir, strlen(name));
	if (IS_ERR(xafile)) {
		dput(xadir);
		return ERR_CAST(xafile);
	}

	if (xafile->d_inode) {	/* file exists */
		if (flags & XATTR_CREATE) {
			err = -EEXIST;
			dput(xafile);
			goto out;
		}
	} else if (flags & XATTR_REPLACE || flags & FL_READONLY) {
		goto out;
	} else {
		/* inode->i_mutex is down, so nothing else can try to create
		 * the same xattr */
		err = xadir->d_inode->i_op->create(xadir->d_inode, xafile,
						   0700 | S_IFREG, NULL);

		if (err) {
			dput(xafile);
			goto out;
		}
	}

out:
	dput(xadir);
	if (err)
		xafile = ERR_PTR(err);
	else if (!xafile->d_inode) {
		dput(xafile);
		xafile = ERR_PTR(-ENODATA);
	}
	return xafile;
}

L
Linus Torvalds 已提交
560
/* Internal operations on file data */
561
static inline void reiserfs_put_page(struct page *page)
L
Linus Torvalds 已提交
562
{
563 564
	kunmap(page);
	page_cache_release(page);
L
Linus Torvalds 已提交
565 566
}

567
static struct page *reiserfs_get_page(struct inode *dir, size_t n)
L
Linus Torvalds 已提交
568
{
569 570 571 572
	struct address_space *mapping = dir->i_mapping;
	struct page *page;
	/* We can deadlock if we try to free dentries,
	   and an unlink/rmdir has just occured - GFP_NOFS avoids this */
573
	mapping_set_gfp_mask(mapping, GFP_NOFS);
574
	page = read_mapping_page(mapping, n >> PAGE_CACHE_SHIFT, NULL);
575 576 577 578 579 580 581 582 583 584
	if (!IS_ERR(page)) {
		kmap(page);
		if (PageError(page))
			goto fail;
	}
	return page;

      fail:
	reiserfs_put_page(page);
	return ERR_PTR(-EIO);
L
Linus Torvalds 已提交
585 586
}

587
static inline __u32 xattr_hash(const char *msg, int len)
L
Linus Torvalds 已提交
588
{
589
	return csum_partial(msg, len, 0);
L
Linus Torvalds 已提交
590 591
}

V
Vladimir Saveliev 已提交
592 593 594 595 596 597
int reiserfs_commit_write(struct file *f, struct page *page,
			  unsigned from, unsigned to);
int reiserfs_prepare_write(struct file *f, struct page *page,
			   unsigned from, unsigned to);


L
Linus Torvalds 已提交
598 599 600
/* Generic extended attribute operations that can be used by xa plugins */

/*
601
 * inode->i_mutex: down
L
Linus Torvalds 已提交
602 603
 */
int
604 605
reiserfs_xattr_set(struct inode *inode, const char *name, const void *buffer,
		   size_t buffer_size, int flags)
L
Linus Torvalds 已提交
606
{
607
	int err = 0;
608
	struct dentry *dentry;
609 610 611 612 613 614 615 616 617 618 619 620 621 622
	struct page *page;
	char *data;
	size_t file_pos = 0;
	size_t buffer_pos = 0;
	struct iattr newattrs;
	__u32 xahash = 0;

	if (get_inode_sd_version(inode) == STAT_DATA_V1)
		return -EOPNOTSUPP;

	/* Empty xattrs are ok, they're just empty files, no hash */
	if (buffer && buffer_size)
		xahash = xattr_hash(buffer, buffer_size);

623 624 625
	dentry = get_xa_file_dentry(inode, name, flags);
	if (IS_ERR(dentry)) {
		err = PTR_ERR(dentry);
626 627 628 629 630 631 632 633
		goto out;
	}

	REISERFS_I(inode)->i_flags |= i_has_xattr_dir;

	/* Resize it so we're ok to write there */
	newattrs.ia_size = buffer_size;
	newattrs.ia_valid = ATTR_SIZE | ATTR_CTIME;
J
Jeff Mahoney 已提交
634
	mutex_lock_nested(&dentry->d_inode->i_mutex, I_MUTEX_XATTR);
635
	err = notify_change(dentry, &newattrs);
636 637 638 639 640 641 642 643 644 645 646 647
	if (err)
		goto out_filp;

	while (buffer_pos < buffer_size || buffer_pos == 0) {
		size_t chunk;
		size_t skip = 0;
		size_t page_offset = (file_pos & (PAGE_CACHE_SIZE - 1));
		if (buffer_size - buffer_pos > PAGE_CACHE_SIZE)
			chunk = PAGE_CACHE_SIZE;
		else
			chunk = buffer_size - buffer_pos;

648
		page = reiserfs_get_page(dentry->d_inode, file_pos);
649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666
		if (IS_ERR(page)) {
			err = PTR_ERR(page);
			goto out_filp;
		}

		lock_page(page);
		data = page_address(page);

		if (file_pos == 0) {
			struct reiserfs_xattr_header *rxh;
			skip = file_pos = sizeof(struct reiserfs_xattr_header);
			if (chunk + skip > PAGE_CACHE_SIZE)
				chunk = PAGE_CACHE_SIZE - skip;
			rxh = (struct reiserfs_xattr_header *)data;
			rxh->h_magic = cpu_to_le32(REISERFS_XATTR_MAGIC);
			rxh->h_hash = cpu_to_le32(xahash);
		}

667
		err = reiserfs_prepare_write(NULL, page, page_offset,
V
Vladimir Saveliev 已提交
668
					    page_offset + chunk + skip);
669 670 671
		if (!err) {
			if (buffer)
				memcpy(data + skip, buffer + buffer_pos, chunk);
672 673 674
			err = reiserfs_commit_write(NULL, page, page_offset,
						    page_offset + chunk +
						    skip);
675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691
		}
		unlock_page(page);
		reiserfs_put_page(page);
		buffer_pos += chunk;
		file_pos += chunk;
		skip = 0;
		if (err || buffer_size == 0 || !buffer)
			break;
	}

	/* We can't mark the inode dirty if it's not hashed. This is the case
	 * when we're inheriting the default ACL. If we dirty it, the inode
	 * gets marked dirty, but won't (ever) make it onto the dirty list until
	 * it's synced explicitly to clear I_DIRTY. This is bad. */
	if (!hlist_unhashed(&inode->i_hash)) {
		inode->i_ctime = CURRENT_TIME_SEC;
		mark_inode_dirty(inode);
L
Linus Torvalds 已提交
692
	}
693 694

      out_filp:
J
Jeff Mahoney 已提交
695
	mutex_unlock(&dentry->d_inode->i_mutex);
696
	dput(dentry);
697 698 699

      out:
	return err;
L
Linus Torvalds 已提交
700 701 702
}

/*
703
 * inode->i_mutex: down
L
Linus Torvalds 已提交
704 705
 */
int
706 707
reiserfs_xattr_get(const struct inode *inode, const char *name, void *buffer,
		   size_t buffer_size)
L
Linus Torvalds 已提交
708
{
709
	ssize_t err = 0;
710
	struct dentry *dentry;
711 712 713 714 715 716 717 718 719 720 721 722 723 724
	size_t isize;
	size_t file_pos = 0;
	size_t buffer_pos = 0;
	struct page *page;
	__u32 hash = 0;

	if (name == NULL)
		return -EINVAL;

	/* We can't have xattrs attached to v1 items since they don't have
	 * generation numbers */
	if (get_inode_sd_version(inode) == STAT_DATA_V1)
		return -EOPNOTSUPP;

725 726 727
	dentry = get_xa_file_dentry(inode, name, FL_READONLY);
	if (IS_ERR(dentry)) {
		err = PTR_ERR(dentry);
728 729 730
		goto out;
	}

J
Jeff Mahoney 已提交
731
	isize = i_size_read(dentry->d_inode);
732 733 734 735 736 737 738 739 740 741 742 743 744
	REISERFS_I(inode)->i_flags |= i_has_xattr_dir;

	/* Just return the size needed */
	if (buffer == NULL) {
		err = isize - sizeof(struct reiserfs_xattr_header);
		goto out_dput;
	}

	if (buffer_size < isize - sizeof(struct reiserfs_xattr_header)) {
		err = -ERANGE;
		goto out_dput;
	}

745 746 747 748 749 750 751 752
	while (file_pos < isize) {
		size_t chunk;
		char *data;
		size_t skip = 0;
		if (isize - file_pos > PAGE_CACHE_SIZE)
			chunk = PAGE_CACHE_SIZE;
		else
			chunk = isize - file_pos;
L
Linus Torvalds 已提交
753

754 755 756 757 758
		page = reiserfs_get_page(dentry->d_inode, file_pos);
		if (IS_ERR(page)) {
			err = PTR_ERR(page);
			goto out_dput;
		}
L
Linus Torvalds 已提交
759

760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787
		lock_page(page);
		data = page_address(page);
		if (file_pos == 0) {
			struct reiserfs_xattr_header *rxh =
			    (struct reiserfs_xattr_header *)data;
			skip = file_pos = sizeof(struct reiserfs_xattr_header);
			chunk -= skip;
			/* Magic doesn't match up.. */
			if (rxh->h_magic != cpu_to_le32(REISERFS_XATTR_MAGIC)) {
				unlock_page(page);
				reiserfs_put_page(page);
				reiserfs_warning(inode->i_sb, "jdm-20001",
						 "Invalid magic for xattr (%s) "
						 "associated with %k", name,
						 INODE_PKEY(inode));
				err = -EIO;
				goto out_dput;
			}
			hash = le32_to_cpu(rxh->h_hash);
		}
		memcpy(buffer + buffer_pos, data + skip, chunk);
		unlock_page(page);
		reiserfs_put_page(page);
		file_pos += chunk;
		buffer_pos += chunk;
		skip = 0;
	}
	err = isize - sizeof(struct reiserfs_xattr_header);
788

789 790 791 792 793 794
	if (xattr_hash(buffer, isize - sizeof(struct reiserfs_xattr_header)) !=
	    hash) {
		reiserfs_warning(inode->i_sb, "jdm-20002",
				 "Invalid hash for xattr (%s) associated "
				 "with %k", name, INODE_PKEY(inode));
		err = -EIO;
795 796
	}

797 798
out_dput:
	dput(dentry);
799

800
out:
801
	return err;
L
Linus Torvalds 已提交
802 803
}

804
int reiserfs_xattr_del(struct inode *inode, const char *name)
L
Linus Torvalds 已提交
805
{
806
	struct dentry *dir;
807
	int err;
808 809 810

	dir = open_xa_dir(inode, FL_READONLY);
	if (IS_ERR(dir)) {
811
		err = PTR_ERR(dir);
812 813 814
		goto out;
	}

815 816
	err = __reiserfs_xattr_del(dir, name, strlen(name));
	dput(dir);
817

818 819 820
	if (!err) {
		inode->i_ctime = CURRENT_TIME_SEC;
		mark_inode_dirty(inode);
821 822 823 824 825
	}

      out:
	return err;
}
L
Linus Torvalds 已提交
826 827 828 829 830

/* Actual operations that are exported to VFS-land */

/*
 * Inode operation getxattr()
831
 * Preliminary locking: we down dentry->d_inode->i_mutex
L
Linus Torvalds 已提交
832 833
 */
ssize_t
834 835
reiserfs_getxattr(struct dentry * dentry, const char *name, void *buffer,
		  size_t size)
L
Linus Torvalds 已提交
836
{
837 838 839 840 841 842 843 844 845 846 847 848 849
	struct reiserfs_xattr_handler *xah = find_xattr_handler_prefix(name);
	int err;

	if (!xah || !reiserfs_xattrs(dentry->d_sb) ||
	    get_inode_sd_version(dentry->d_inode) == STAT_DATA_V1)
		return -EOPNOTSUPP;

	reiserfs_read_lock_xattr_i(dentry->d_inode);
	reiserfs_read_lock_xattrs(dentry->d_sb);
	err = xah->get(dentry->d_inode, name, buffer, size);
	reiserfs_read_unlock_xattrs(dentry->d_sb);
	reiserfs_read_unlock_xattr_i(dentry->d_inode);
	return err;
L
Linus Torvalds 已提交
850 851 852 853 854
}

/*
 * Inode operation setxattr()
 *
855
 * dentry->d_inode->i_mutex down
L
Linus Torvalds 已提交
856 857
 */
int
858 859
reiserfs_setxattr(struct dentry *dentry, const char *name, const void *value,
		  size_t size, int flags)
L
Linus Torvalds 已提交
860
{
861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881
	struct reiserfs_xattr_handler *xah = find_xattr_handler_prefix(name);
	int err;
	int lock;

	if (!xah || !reiserfs_xattrs(dentry->d_sb) ||
	    get_inode_sd_version(dentry->d_inode) == STAT_DATA_V1)
		return -EOPNOTSUPP;

	reiserfs_write_lock_xattr_i(dentry->d_inode);
	lock = !has_xattr_dir(dentry->d_inode);
	if (lock)
		reiserfs_write_lock_xattrs(dentry->d_sb);
	else
		reiserfs_read_lock_xattrs(dentry->d_sb);
	err = xah->set(dentry->d_inode, name, value, size, flags);
	if (lock)
		reiserfs_write_unlock_xattrs(dentry->d_sb);
	else
		reiserfs_read_unlock_xattrs(dentry->d_sb);
	reiserfs_write_unlock_xattr_i(dentry->d_inode);
	return err;
L
Linus Torvalds 已提交
882 883 884 885 886
}

/*
 * Inode operation removexattr()
 *
887
 * dentry->d_inode->i_mutex down
L
Linus Torvalds 已提交
888
 */
889
int reiserfs_removexattr(struct dentry *dentry, const char *name)
L
Linus Torvalds 已提交
890
{
891 892
	int err;
	struct reiserfs_xattr_handler *xah = find_xattr_handler_prefix(name);
L
Linus Torvalds 已提交
893

894 895 896
	if (!xah || !reiserfs_xattrs(dentry->d_sb) ||
	    get_inode_sd_version(dentry->d_inode) == STAT_DATA_V1)
		return -EOPNOTSUPP;
L
Linus Torvalds 已提交
897

898 899
	reiserfs_write_lock_xattr_i(dentry->d_inode);
	reiserfs_read_lock_xattrs(dentry->d_sb);
L
Linus Torvalds 已提交
900

901 902 903 904 905 906
	/* Deletion pre-operation */
	if (xah->del) {
		err = xah->del(dentry->d_inode, name);
		if (err)
			goto out;
	}
L
Linus Torvalds 已提交
907

908
	err = reiserfs_xattr_del(dentry->d_inode, name);
L
Linus Torvalds 已提交
909

910 911
	dentry->d_inode->i_ctime = CURRENT_TIME_SEC;
	mark_inode_dirty(dentry->d_inode);
L
Linus Torvalds 已提交
912

913 914 915 916
      out:
	reiserfs_read_unlock_xattrs(dentry->d_sb);
	reiserfs_write_unlock_xattr_i(dentry->d_inode);
	return err;
L
Linus Torvalds 已提交
917 918 919 920 921 922 923 924
}

/* This is what filldir will use:
 * r_pos will always contain the amount of space required for the entire
 * list. If r_pos becomes larger than r_size, we need more space and we
 * return an error indicating this. If r_pos is less than r_size, then we've
 * filled the buffer successfully and we return success */
struct reiserfs_listxattr_buf {
925 926 927 928
	int r_pos;
	int r_size;
	char *r_buf;
	struct inode *r_inode;
L
Linus Torvalds 已提交
929 930 931
};

static int
932
reiserfs_listxattr_filler(void *buf, const char *name, int namelen,
933
			  loff_t offset, u64 ino, unsigned int d_type)
L
Linus Torvalds 已提交
934
{
935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958
	struct reiserfs_listxattr_buf *b = (struct reiserfs_listxattr_buf *)buf;
	int len = 0;
	if (name[0] != '.'
	    || (namelen != 1 && (name[1] != '.' || namelen != 2))) {
		struct reiserfs_xattr_handler *xah =
		    find_xattr_handler_prefix(name);
		if (!xah)
			return 0;	/* Unsupported xattr name, skip it */

		/* We call ->list() twice because the operation isn't required to just
		 * return the name back - we want to make sure we have enough space */
		len += xah->list(b->r_inode, name, namelen, NULL);

		if (len) {
			if (b->r_pos + len + 1 <= b->r_size) {
				char *p = b->r_buf + b->r_pos;
				p += xah->list(b->r_inode, name, namelen, p);
				*p++ = '\0';
			}
			b->r_pos += len + 1;
		}
	}

	return 0;
L
Linus Torvalds 已提交
959
}
960

L
Linus Torvalds 已提交
961 962 963
/*
 * Inode operation listxattr()
 *
964
 * Preliminary locking: we down dentry->d_inode->i_mutex
L
Linus Torvalds 已提交
965
 */
966
ssize_t reiserfs_listxattr(struct dentry * dentry, char *buffer, size_t size)
L
Linus Torvalds 已提交
967
{
968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996
	struct dentry *dir;
	int err = 0;
	struct reiserfs_listxattr_buf buf;

	if (!dentry->d_inode)
		return -EINVAL;

	if (!reiserfs_xattrs(dentry->d_sb) ||
	    get_inode_sd_version(dentry->d_inode) == STAT_DATA_V1)
		return -EOPNOTSUPP;

	reiserfs_read_lock_xattr_i(dentry->d_inode);
	reiserfs_read_lock_xattrs(dentry->d_sb);
	dir = open_xa_dir(dentry->d_inode, FL_READONLY);
	reiserfs_read_unlock_xattrs(dentry->d_sb);
	if (IS_ERR(dir)) {
		err = PTR_ERR(dir);
		if (err == -ENODATA)
			err = 0;	/* Not an error if there aren't any xattrs */
		goto out;
	}

	buf.r_buf = buffer;
	buf.r_size = buffer ? size : 0;
	buf.r_pos = 0;
	buf.r_inode = dentry->d_inode;

	REISERFS_I(dentry->d_inode)->i_flags |= i_has_xattr_dir;

997
	err = xattr_readdir(dir->d_inode, reiserfs_listxattr_filler, &buf);
998 999 1000 1001 1002 1003 1004 1005 1006
	if (err)
		goto out_dir;

	if (buf.r_pos > buf.r_size && buffer != NULL)
		err = -ERANGE;
	else
		err = buf.r_pos;

      out_dir:
1007
	dput(dir);
1008 1009 1010 1011

      out:
	reiserfs_read_unlock_xattr_i(dentry->d_inode);
	return err;
L
Linus Torvalds 已提交
1012 1013 1014
}

/* This is the implementation for the xattr plugin infrastructure */
1015
static LIST_HEAD(xattr_handlers);
L
Linus Torvalds 已提交
1016 1017
static DEFINE_RWLOCK(handler_lock);

1018 1019
static struct reiserfs_xattr_handler *find_xattr_handler_prefix(const char
								*prefix)
L
Linus Torvalds 已提交
1020
{
1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033
	struct reiserfs_xattr_handler *xah = NULL;
	struct list_head *p;

	read_lock(&handler_lock);
	list_for_each(p, &xattr_handlers) {
		xah = list_entry(p, struct reiserfs_xattr_handler, handlers);
		if (strncmp(xah->prefix, prefix, strlen(xah->prefix)) == 0)
			break;
		xah = NULL;
	}

	read_unlock(&handler_lock);
	return xah;
L
Linus Torvalds 已提交
1034 1035
}

1036
static void __unregister_handlers(void)
L
Linus Torvalds 已提交
1037
{
1038 1039
	struct reiserfs_xattr_handler *xah;
	struct list_head *p, *tmp;
L
Linus Torvalds 已提交
1040

1041 1042 1043 1044
	list_for_each_safe(p, tmp, &xattr_handlers) {
		xah = list_entry(p, struct reiserfs_xattr_handler, handlers);
		if (xah->exit)
			xah->exit();
L
Linus Torvalds 已提交
1045

1046 1047 1048
		list_del_init(p);
	}
	INIT_LIST_HEAD(&xattr_handlers);
L
Linus Torvalds 已提交
1049 1050
}

1051
int __init reiserfs_xattr_register_handlers(void)
L
Linus Torvalds 已提交
1052
{
1053 1054 1055
	int err = 0;
	struct reiserfs_xattr_handler *xah;
	struct list_head *p;
L
Linus Torvalds 已提交
1056

1057
	write_lock(&handler_lock);
L
Linus Torvalds 已提交
1058

1059 1060 1061 1062 1063
	/* If we're already initialized, nothing to do */
	if (!list_empty(&xattr_handlers)) {
		write_unlock(&handler_lock);
		return 0;
	}
L
Linus Torvalds 已提交
1064

1065 1066 1067
	/* Add the handlers */
	list_add_tail(&user_handler.handlers, &xattr_handlers);
	list_add_tail(&trusted_handler.handlers, &xattr_handlers);
L
Linus Torvalds 已提交
1068
#ifdef CONFIG_REISERFS_FS_SECURITY
1069
	list_add_tail(&security_handler.handlers, &xattr_handlers);
L
Linus Torvalds 已提交
1070 1071
#endif
#ifdef CONFIG_REISERFS_FS_POSIX_ACL
1072 1073
	list_add_tail(&posix_acl_access_handler.handlers, &xattr_handlers);
	list_add_tail(&posix_acl_default_handler.handlers, &xattr_handlers);
L
Linus Torvalds 已提交
1074 1075
#endif

1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093
	/* Run initializers, if available */
	list_for_each(p, &xattr_handlers) {
		xah = list_entry(p, struct reiserfs_xattr_handler, handlers);
		if (xah->init) {
			err = xah->init();
			if (err) {
				list_del_init(p);
				break;
			}
		}
	}

	/* Clean up other handlers, if any failed */
	if (err)
		__unregister_handlers();

	write_unlock(&handler_lock);
	return err;
L
Linus Torvalds 已提交
1094 1095
}

1096
void reiserfs_xattr_unregister_handlers(void)
L
Linus Torvalds 已提交
1097
{
1098 1099 1100
	write_lock(&handler_lock);
	__unregister_handlers();
	write_unlock(&handler_lock);
L
Linus Torvalds 已提交
1101 1102
}

1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190
static int reiserfs_check_acl(struct inode *inode, int mask)
{
	struct posix_acl *acl;
	int error = -EAGAIN; /* do regular unix permission checks by default */

	reiserfs_read_lock_xattr_i(inode);
	reiserfs_read_lock_xattrs(inode->i_sb);

	acl = reiserfs_get_acl(inode, ACL_TYPE_ACCESS);

	reiserfs_read_unlock_xattrs(inode->i_sb);
	reiserfs_read_unlock_xattr_i(inode);

	if (acl) {
		if (!IS_ERR(acl)) {
			error = posix_acl_permission(inode, acl, mask);
			posix_acl_release(acl);
		} else if (PTR_ERR(acl) != -ENODATA)
			error = PTR_ERR(acl);
	}

	return error;
}

int reiserfs_permission(struct inode *inode, int mask)
{
	/*
	 * We don't do permission checks on the internal objects.
	 * Permissions are determined by the "owning" object.
	 */
	if (IS_PRIVATE(inode))
		return 0;
	/*
	 * Stat data v1 doesn't support ACLs.
	 */
	if (get_inode_sd_version(inode) == STAT_DATA_V1)
		return generic_permission(inode, mask, NULL);
	else
		return generic_permission(inode, mask, reiserfs_check_acl);
}

static int create_privroot(struct dentry *dentry)
{
	int err;
	struct inode *inode = dentry->d_parent->d_inode;
	mutex_lock_nested(&inode->i_mutex, I_MUTEX_XATTR);
	err = inode->i_op->mkdir(inode, dentry, 0700);
	mutex_unlock(&inode->i_mutex);
	if (err) {
		dput(dentry);
		dentry = NULL;
	}

	if (dentry && dentry->d_inode)
		reiserfs_info(dentry->d_sb, "Created %s - reserved for xattr "
			      "storage.\n", PRIVROOT_NAME);

	return err;
}

static int xattr_mount_check(struct super_block *s)
{
	/* We need generation numbers to ensure that the oid mapping is correct
	 * v3.5 filesystems don't have them. */
	if (!old_format_only(s)) {
		set_bit(REISERFS_XATTRS, &(REISERFS_SB(s)->s_mount_opt));
	} else if (reiserfs_xattrs_optional(s)) {
		/* Old format filesystem, but optional xattrs have been enabled
		 * at mount time. Error out. */
		reiserfs_warning(s, "jdm-20005",
				 "xattrs/ACLs not supported on pre v3.6 "
				 "format filesystem. Failing mount.");
		return -EOPNOTSUPP;
	} else {
		/* Old format filesystem, but no optional xattrs have
		 * been enabled. This means we silently disable xattrs
		 * on the filesystem. */
		clear_bit(REISERFS_XATTRS, &(REISERFS_SB(s)->s_mount_opt));
	}

	return 0;
}

#else
int __init reiserfs_xattr_register_handlers(void) { return 0; }
void reiserfs_xattr_unregister_handlers(void) {}
#endif

L
Linus Torvalds 已提交
1191 1192
/* This will catch lookups from the fs root to .reiserfs_priv */
static int
1193
xattr_lookup_poison(struct dentry *dentry, struct qstr *q1, struct qstr *name)
L
Linus Torvalds 已提交
1194
{
1195 1196 1197 1198 1199 1200 1201 1202 1203
	struct dentry *priv_root = REISERFS_SB(dentry->d_sb)->priv_root;
	if (name->len == priv_root->d_name.len &&
	    name->hash == priv_root->d_name.hash &&
	    !memcmp(name->name, priv_root->d_name.name, name->len)) {
		return -ENOENT;
	} else if (q1->len == name->len &&
		   !memcmp(q1->name, name->name, name->len))
		return 0;
	return 1;
L
Linus Torvalds 已提交
1204 1205 1206
}

static struct dentry_operations xattr_lookup_poison_ops = {
1207
	.d_compare = xattr_lookup_poison,
L
Linus Torvalds 已提交
1208 1209 1210 1211 1212
};

/* We need to take a copy of the mount flags since things like
 * MS_RDONLY don't get set until *after* we're called.
 * mount_flags != mount_options */
1213
int reiserfs_xattr_init(struct super_block *s, int mount_flags)
L
Linus Torvalds 已提交
1214
{
1215 1216
	int err = 0;

1217 1218 1219
#ifdef CONFIG_REISERFS_FS_XATTR
	err = xattr_mount_check(s);
	if (err)
1220
		goto error;
1221
#endif
1222 1223

	/* If we don't have the privroot located yet - go find it */
1224
	if (!REISERFS_SB(s)->priv_root) {
1225 1226 1227 1228
		struct dentry *dentry;
		dentry = lookup_one_len(PRIVROOT_NAME, s->s_root,
					strlen(PRIVROOT_NAME));
		if (!IS_ERR(dentry)) {
1229 1230 1231 1232 1233
#ifdef CONFIG_REISERFS_FS_XATTR
			if (!(mount_flags & MS_RDONLY) && !dentry->d_inode)
				err = create_privroot(dentry);
#endif
			if (!dentry->d_inode) {
1234 1235 1236 1237 1238 1239 1240 1241
				dput(dentry);
				dentry = NULL;
			}
		} else
			err = PTR_ERR(dentry);

		if (!err && dentry) {
			s->s_root->d_op = &xattr_lookup_poison_ops;
1242
			dentry->d_inode->i_flags |= S_PRIVATE;
1243
			REISERFS_SB(s)->priv_root = dentry;
1244 1245 1246 1247 1248 1249 1250
#ifdef CONFIG_REISERFS_FS_XATTR
		/* xattrs are unavailable */
		} else if (!(mount_flags & MS_RDONLY)) {
			/* If we're read-only it just means that the dir
			 * hasn't been created. Not an error -- just no
			 * xattrs on the fs. We'll check again if we
			 * go read-write */
J
Jeff Mahoney 已提交
1251 1252 1253 1254
			reiserfs_warning(s, "jdm-20006",
					 "xattrs/ACLs enabled and couldn't "
					 "find/create .reiserfs_priv. "
					 "Failing mount.");
1255
			err = -EOPNOTSUPP;
1256
#endif
1257 1258 1259
		}
	}

1260 1261
#ifdef CONFIG_REISERFS_FS_XATTR
error:
1262 1263 1264 1265 1266
	if (err) {
		clear_bit(REISERFS_XATTRS, &(REISERFS_SB(s)->s_mount_opt));
		clear_bit(REISERFS_XATTRS_USER, &(REISERFS_SB(s)->s_mount_opt));
		clear_bit(REISERFS_POSIXACL, &(REISERFS_SB(s)->s_mount_opt));
	}
1267
#endif
1268 1269 1270

	/* The super_block MS_POSIXACL must mirror the (no)acl mount option. */
	s->s_flags = s->s_flags & ~MS_POSIXACL;
1271
#ifdef CONFIG_REISERFS_FS_POSIX_ACL
1272 1273
	if (reiserfs_posixacl(s))
		s->s_flags |= MS_POSIXACL;
1274
#endif
1275 1276

	return err;
L
Linus Torvalds 已提交
1277
}